diff --git a/dspace/CHANGES b/dspace/CHANGES index fc8dded265..82621496d1 100644 --- a/dspace/CHANGES +++ b/dspace/CHANGES @@ -1,5 +1,9 @@ 1.4 alpha 1 =========== +(Robert Tansley) +- Fix logic in EditItemServlet to enable removal of blank metadata values. + Fixes bug #1358197. + (Robert Tansley) - Error displayed on 'choose collection' submit screen instead of blank collection list and 'next >' control (which led to error). Fixes SF bug diff --git a/dspace/src/org/dspace/app/webui/servlet/admin/EditItemServlet.java b/dspace/src/org/dspace/app/webui/servlet/admin/EditItemServlet.java index 4f2be8ceb6..71e303ae28 100644 --- a/dspace/src/org/dspace/app/webui/servlet/admin/EditItemServlet.java +++ b/dspace/src/org/dspace/app/webui/servlet/admin/EditItemServlet.java @@ -432,9 +432,8 @@ public class EditItemServlet extends DSpaceServlet // If remove button pressed for this value, we don't add it // back to the item. We also don't add empty values. - if (value.equals("") - || !button.equals("submit_remove_" + key + "_" - + sequenceNumber)) + if (!(value.equals("") || button.equals("submit_remove_" + key + + "_" + sequenceNumber))) { // Value is empty, or remove button for this wasn't pressed item.addMetadata(schema, element, qualifier, language, value);