[DS-2701-service-api-fix-legacy-id-support] Fix legacy identifier support for the community & removed some obsolete "getLegacyID()" methods

dspace-api/src/main/java/org/dspace/content/Bitstream.java

@@ -79,19 +79,6 @@ public class Bitstream extends DSpaceObject implements DSpaceObjectLegacySupport
     {
     }
 
-    /**
-     * Get the internal identifier of this bitstream
-     *
-     * @return the internal identifier
-     *
-     * @deprecated use getID()
-     */
-    public int getLegacyID()
-    {
-        return legacyId;
-    }
-
-
     /**
      * Get the sequence ID of this bitstream
      * 

dspace-api/src/main/java/org/dspace/content/Community.java

@@ -74,18 +74,6 @@ public class Community extends DSpaceObject implements DSpaceObjectLegacySupport
     protected Community() {
     }
 
-    /**
-     * Get the internal ID of this community
-     *
-     * @return the internal identifier
-     *
-     * @deprecated use getID()
-     */
-    public int getLegacyID()
-    {
-        return legacyId;
-    }
-
     void addSubCommunity(Community subCommunity)
     {
         getSubcommunities().add(subCommunity);

dspace-api/src/main/java/org/dspace/content/CommunityServiceImpl.java

@@ -664,6 +664,6 @@ public class CommunityServiceImpl extends DSpaceObjectServiceImpl<Community> imp
 
     @Override
     public Community findByLegacyId(Context context, int id) throws SQLException {
-        return communityDAO.findByID(context, Community.class, id);
+        return communityDAO.findByLegacyId(context, id, Community.class);
     }
 }

dspace-api/src/main/java/org/dspace/content/dao/CommunityDAO.java

@@ -23,7 +23,7 @@ import java.util.List;
  *
  * @author kevinvandevelde at atmire.com
  */
-public interface CommunityDAO extends DSpaceObjectDAO<Community> {
+public interface CommunityDAO extends DSpaceObjectLegacySupportDAO<Community> {
 
     public List<Community> findAll(Context context, MetadataField sortField) throws SQLException;
 

dspace-api/src/main/java/org/dspace/eperson/Group.java

@@ -77,18 +77,6 @@ public class Group extends DSpaceObject implements DSpaceObjectLegacySupport
     public Group() {
     }
 
-    /**
-     * get the ID of the group object
-     *
-     * @return id
-     *
-     * @deprecated use getID()
-     */
-    public int getLegacyID()
-    {
-        return legacyId;
-    }
-
     void addMember(EPerson e)
     {
         getMembers().add(e);