fixes for DS-3866

This commit is contained in:
Kim Shepherd
2018-05-21 11:08:23 +12:00
parent 2904680ab0
commit 22baf1e698
9 changed files with 13 additions and 9 deletions

View File

@@ -17,6 +17,7 @@ import javax.servlet.jsp.tagext.TagSupport;
import org.apache.commons.lang.ArrayUtils; import org.apache.commons.lang.ArrayUtils;
import org.dspace.eperson.EPerson; import org.dspace.eperson.EPerson;
import org.dspace.core.Utils;
/** /**
* <p> * <p>
@@ -122,7 +123,7 @@ public class SelectEPersonTag extends TagSupport
for (int i = 0; i < epeople.length; i++) for (int i = 0; i < epeople.length; i++)
{ {
out.print("<option value=\"" + epeople[i].getID() + "\">"); out.print("<option value=\"" + epeople[i].getID() + "\">");
out.print(epeople[i].getFullName() + " (" out.print(Utils.addEntities(epeople[i].getFullName()) + " ("
+ epeople[i].getEmail() + ")"); + epeople[i].getEmail() + ")");
out.println("</option>"); out.println("</option>");
} }

View File

@@ -17,6 +17,7 @@ import javax.servlet.jsp.tagext.TagSupport;
import org.apache.commons.lang.ArrayUtils; import org.apache.commons.lang.ArrayUtils;
import org.dspace.eperson.Group; import org.dspace.eperson.Group;
import org.dspace.core.Utils;
/** /**
* <P>Tag for producing an e-person select widget in a form. Somewhat * <P>Tag for producing an e-person select widget in a form. Somewhat
@@ -121,7 +122,7 @@ public class SelectGroupTag extends TagSupport
for (int i = 0; i < groups.length; i++) for (int i = 0; i < groups.length; i++)
{ {
out.print("<option value=\"" + groups[i].getID() + "\">"); out.print("<option value=\"" + groups[i].getID() + "\">");
out.print(groups[i].getName() + " (" + groups[i].getID() + ")"); out.print(Utils.addEntities(groups[i].getName()) + " (" + groups[i].getID() + ")");
out.println("</option>"); out.println("</option>");
} }
} }

View File

@@ -29,6 +29,7 @@
<%@ taglib uri="http://java.sun.com/jsp/jstl/fmt" prefix="fmt" %> <%@ taglib uri="http://java.sun.com/jsp/jstl/fmt" prefix="fmt" %>
<%@ page import="org.dspace.eperson.Group" %> <%@ page import="org.dspace.eperson.Group" %>
<%@ page import="org.dspace.core.Utils" %>
<%@ page import="java.util.List" %> <%@ page import="java.util.List" %>
<% <%
@@ -57,7 +58,7 @@
<select class="form-control" size="15" name="groups_id" multiple="multiple"> <select class="form-control" size="15" name="groups_id" multiple="multiple">
<% for (int i = 0; i < groups.size(); i++) { %> <% for (int i = 0; i < groups.size(); i++) { %>
<option value="<%= groups.get(i).getID()%>"> <option value="<%= groups.get(i).getID()%>">
<%= groups.get(i).getName()%> <%= Utils.addEntities(groups.get(i).getName())%>
</option> </option>
<% } %> <% } %>
</select> </select>

View File

@@ -82,7 +82,7 @@
<div class="row"> <div class="row">
<label class="col-md-2"><fmt:message key="jsp.dspace-admin.supervise-confirm-remove.supervisorgroupheader"/>:</label> <label class="col-md-2"><fmt:message key="jsp.dspace-admin.supervise-confirm-remove.supervisorgroupheader"/>:</label>
<span> <span>
<%= group.getName() %> <%= Utils.addEntities(group.getName()) %>
</span> </span>
</div> </div>
<br/> <br/>

View File

@@ -63,7 +63,7 @@
for (int i = 0; i < groups.size(); i++) for (int i = 0; i < groups.size(); i++)
{ {
%> %>
<option value="<%= groups.get(i).getID() %>"><%= groups.get(i).getName() %></option> <option value="<%= groups.get(i).getID() %>"><%= Utils.addEntities(groups.get(i).getName()) %></option>
<% <%
} }
%> %>

View File

@@ -291,7 +291,7 @@ function clearEPeople()
<td headers="t1"> <td headers="t1">
<input class="btn btn-success" type="button" value="<% <input class="btn btn-success" type="button" value="<%
if (multiple) { %><fmt:message key="jsp.tools.general.add"/><% } if (multiple) { %><fmt:message key="jsp.tools.general.add"/><% }
else { %><fmt:message key="jsp.tools.general.select"/><% } %>" onclick="javascript:<%= clearList %>addEPerson('<%= e.getID() %>', '<%= email %>', '<%= fullname %>');<%= closeWindow %>"/></td> else { %><fmt:message key="jsp.tools.general.select"/><% } %>" onclick="javascript:<%= clearList %>addEPerson('<%= e.getID() %>', '<%= email %>', '<%= Utils.addEntities(fullname) %>');<%= closeWindow %>"/></td>
<td headers="t2"><%= e.getID() %></td> <td headers="t2"><%= e.getID() %></td>
<td headers="t3"><%= (e.getEmail() == null ? "" : Utils.addEntities(e.getEmail())) %></td> <td headers="t3"><%= (e.getEmail() == null ? "" : Utils.addEntities(e.getEmail())) %></td>
<td headers="t4"> <td headers="t4">

View File

@@ -69,7 +69,7 @@
parentlink="<%= link %>" parentlink="<%= link %>"
nocache="true"> nocache="true">
<h1><fmt:message key="jsp.tools.group-edit.title"/> : <%=group.getName()%> (id: <%=group.getID()%>) <h1><fmt:message key="jsp.tools.group-edit.title"/> : <%=Utils.addEntities(group.getName())%> (id: <%=group.getID()%>)
<dspace:popup page="<%= LocaleSupport.getLocalizedMessage(pageContext, \"help.collection-admin\") +\"#groupeditor\"%>"><fmt:message key="jsp.help"/></dspace:popup> <dspace:popup page="<%= LocaleSupport.getLocalizedMessage(pageContext, \"help.collection-admin\") +\"#groupeditor\"%>"><fmt:message key="jsp.help"/></dspace:popup>
</h1> </h1>
<form name="epersongroup" method="post" action=""> <form name="epersongroup" method="post" action="">

View File

@@ -27,6 +27,7 @@
<%@ page import="org.dspace.eperson.EPerson" %> <%@ page import="org.dspace.eperson.EPerson" %>
<%@ page import="org.dspace.eperson.Group" %> <%@ page import="org.dspace.eperson.Group" %>
<%@ page import="org.dspace.core.Utils" %>
<%@ page import="java.util.List" %> <%@ page import="java.util.List" %>
<% <%
@@ -94,7 +95,7 @@
<tr> <tr>
<td class="<%= row %>RowOddCol"><%= groups.get(i).getID() %></td> <td class="<%= row %>RowOddCol"><%= groups.get(i).getID() %></td>
<td class="<%= row %>RowEvenCol"> <td class="<%= row %>RowEvenCol">
<%= groups.get(i).getName() %> <%= Utils.addEntities(groups.get(i).getName()) %>
</td> </td>
<td class="<%= row %>RowOddCol"> <td class="<%= row %>RowOddCol">
<% <%

View File

@@ -175,7 +175,7 @@ function clearGroups()
if (multiple) { %><fmt:message key="jsp.tools.general.add"/><% } if (multiple) { %><fmt:message key="jsp.tools.general.add"/><% }
else { %><fmt:message key="jsp.tools.general.select"/><% } %>" onclick="javascript:<%= clearList %>addGroup('<%= g.getID() %>', '<%= Utils.addEntities(fullname) %>');<%= closeWindow %>"/></td> else { %><fmt:message key="jsp.tools.general.select"/><% } %>" onclick="javascript:<%= clearList %>addGroup('<%= g.getID() %>', '<%= Utils.addEntities(fullname) %>');<%= closeWindow %>"/></td>
<td headers="t2" class=""><%= g.getID() %></td> <td headers="t2" class=""><%= g.getID() %></td>
<td headers="t3" class=""> <%= g.getName()%></td> <td headers="t3" class=""> <%= Utils.addEntities(g.getName())%></td>
</tr> </tr>
<% <%
row = (row.equals("odd") ? "even" : "odd"); row = (row.equals("odd") ? "even" : "odd");