hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-17 23:13:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

[DURACOM-346] SubscribeServiceImpl : the method "isSubscribed" returns incorrect result

Browse Source 
(cherry picked from commit 23468d4ee3)
This commit is contained in:
Piaget Bouaka Donfack
2025-04-16 17:11:09 +02:00
committed by github-actions[bot]
parent d74ae7345e
commit 3a894e5f5d
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
dspace-api/src/main/java/org/dspace/eperson/SubscribeServiceImpl.java
View File

@@ -131,7 +131,8 @@ public class SubscribeServiceImpl implements SubscribeService {
@Override
public boolean isSubscribed(Context context, EPerson eperson, DSpaceObject dSpaceObject) throws SQLException {
return subscriptionDAO.findByEPersonAndDso(context, eperson, dSpaceObject, -1, -1) != null;
List<Subscription> subscriptions = subscriptionDAO.findByEPersonAndDso(context, eperson, dSpaceObject, -1, -1);
return subscriptions != null && !subscriptions.isEmpty();
}
@Override

2
dspace-api/src/test/java/org/dspace/eperson/SubscribeServiceIT.java
View File

@@ -213,6 +213,7 @@ public class SubscribeServiceIT extends AbstractIntegrationTestWithDatabase {
secondCollection, 100, 0);
assertEquals(subscriptions.size(), 1);
assertThat(subscribeService.isSubscribed(context, subscribingUser, secondCollection), is(true));
subscribeService.unsubscribe(context, subscribingUser, secondCollection);
@@ -222,6 +223,7 @@ public class SubscribeServiceIT extends AbstractIntegrationTestWithDatabase {
secondCollection, 100, 0);
assertEquals(subscriptions.size(), 0);
assertThat(subscribeService.isSubscribed(context, subscribingUser, secondCollection), is(false));
}
@Test(expected = AuthorizeException.class)