hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-19 07:53:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes to various errorprone warnings in tests

Browse Source
This commit is contained in:
Tim Donohue
2020-02-07 16:26:18 -06:00
parent 14586eb594
commit 3ae9009dbd
19 changed files with 73 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
dspace-api/src/test/java/org/dspace/content/RelationshipServiceImplTest.java
View File

@@ -13,7 +13,6 @@ import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import java.util.ArrayList;
import java.util.LinkedList;
import java.util.List;
import org.dspace.authorize.service.AuthorizeService;
@@ -137,7 +136,7 @@ public class RelationshipServiceImplTest {
@Test
public void testFindByItemAndRelationshipType() throws Exception {
// Declare objects utilized in unit test
List<Relationship> relList = new LinkedList<>();
List<Relationship> relList = new ArrayList<>();
Item item = mock(Item.class);
RelationshipType testRel = new RelationshipType();
@@ -152,7 +151,7 @@ public class RelationshipServiceImplTest {
@Test
public void testFindByRelationshipType() throws Exception {
// Declare objects utilized in unit test
List<Relationship> relList = new LinkedList<>();
List<Relationship> relList = new ArrayList<>();
RelationshipType testRel = new RelationshipType();
// The Relationship(s) reported should match our our relList
@@ -232,7 +231,6 @@ public class RelationshipServiceImplTest {
// Declare objects utilized in unit test
MetadataValue metVal = mock(MetadataValue.class);
List<MetadataValue> metsList = new ArrayList<>();
List<Relationship> leftTypelist = new ArrayList<>();
List<Relationship> rightTypelist = new ArrayList<>();
Item leftItem = mock(Item.class);
@@ -246,7 +244,6 @@ public class RelationshipServiceImplTest {
testRel.setRightwardType("Entitylabel");
testRel.setLeftMinCardinality(0);
testRel.setRightMinCardinality(0);
metsList.add(metVal);
relationship = getRelationship(leftItem, rightItem, testRel, 0,0);
leftTypelist.add(relationship);
rightTypelist.add(relationship);