DS-3851 code cleanup: community feedback

This commit is contained in:
Andrea Bollini
2019-03-06 14:58:59 +01:00
parent d5b4963e26
commit 4475eca5b2
33 changed files with 589 additions and 210 deletions

View File

@@ -382,13 +382,13 @@ public class CollectionServiceImpl extends DSpaceObjectServiceImpl<Collection> i
switch (step) {
case 1:
roleId = "reviewer";
roleId = CollectionRoleService.LEGACY_WORKFLOW_STEP1_NAME;
break;
case 2:
roleId = "editor";
roleId = CollectionRoleService.LEGACY_WORKFLOW_STEP2_NAME;
break;
case 3:
roleId = "finaleditor";
roleId = CollectionRoleService.LEGACY_WORKFLOW_STEP3_NAME;
break;
default:
throw new IllegalArgumentException("Illegal step count: " + step);
@@ -416,13 +416,13 @@ public class CollectionServiceImpl extends DSpaceObjectServiceImpl<Collection> i
switch (step) {
case 1:
roleId = "reviewer";
roleId = CollectionRoleService.LEGACY_WORKFLOW_STEP1_NAME;
break;
case 2:
roleId = "editor";
roleId = CollectionRoleService.LEGACY_WORKFLOW_STEP2_NAME;
break;
case 3:
roleId = "finaleditor";
roleId = CollectionRoleService.LEGACY_WORKFLOW_STEP3_NAME;
break;
default:
throw new IllegalArgumentException("Illegal step count: " + step);