hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-14 13:33:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

#8629: Make sure temporary worfklow groups of reviewers get deleted

Browse Source
This commit is contained in:
Marie Verdonck
2023-02-03 16:44:58 +01:00
parent 54f6ba9951
commit 450956de86
3 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dspace-api/src/main/java/org/dspace/xmlworkflow/state/actions/userassignment/AutoAssignAction.java
View File

@@ -80,6 +80,10 @@ public class AutoAssignAction extends UserSelectionAction {
} }
//Delete our workflow item role since the users have been assigned //Delete our workflow item role since the users have been assigned
workflowItemRoleService.delete(c, workflowItemRole); workflowItemRoleService.delete(c, workflowItemRole);
if (role.isDeleteTemporaryGroup()) {
// Delete temporary groups created after members have workflow task assigned
groupService.delete(c, workflowItemRole.getGroup());
}
} }
} else { } else {
log.warn(LogHelper.getHeader(c, "Error while executing auto assign action", log.warn(LogHelper.getHeader(c, "Error while executing auto assign action",

1
dspace-api/src/test/data/dspaceFolder/config/spring/api/workflow.xml
View File

@@ -153,6 +153,7 @@
<bean id="scoreassignedreviewer" class="org.dspace.xmlworkflow.Role"> <bean id="scoreassignedreviewer" class="org.dspace.xmlworkflow.Role">
<property name="scope" value="#{ T(org.dspace.xmlworkflow.Role.Scope).ITEM}"/> <property name="scope" value="#{ T(org.dspace.xmlworkflow.Role.Scope).ITEM}"/>
<property name="name" value="Reviewer"/> <property name="name" value="Reviewer"/>
<property name="deleteTemporaryGroup" value="true"/>
</bean> </bean>

1
dspace/config/spring/api/workflow.xml
View File

@@ -151,6 +151,7 @@
<bean id="scoreassignedreviewer" class="org.dspace.xmlworkflow.Role"> <bean id="scoreassignedreviewer" class="org.dspace.xmlworkflow.Role">
<property name="scope" value="#{ T(org.dspace.xmlworkflow.Role.Scope).ITEM}"/> <property name="scope" value="#{ T(org.dspace.xmlworkflow.Role.Scope).ITEM}"/>
<property name="name" value="Reviewer"/> <property name="name" value="Reviewer"/>
<property name="deleteTemporaryGroup" value="true"/>
</bean> </bean>