hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-14 05:23:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1415 from KevinVdV/DS-3185-fix-special-group-rights

Browse Source 
[DS-3185] Special group doesn't grant the right to submit
This commit is contained in:
Pascal-Nicolas Becker
2016-05-26 15:21:16 +02:00
parent c20c368a42 324f9a31da
commit 7917dc920e
1 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
dspace-api/src/main/java/org/dspace/eperson/GroupServiceImpl.java
View File

@@ -171,22 +171,19 @@ public class GroupServiceImpl extends DSpaceObjectServiceImpl<Group> implements
EPerson currentUser = context.getCurrentUser(); EPerson currentUser = context.getCurrentUser();
//First check the special groups //First check the special groups
boolean found = false;
List<Group> specialGroups = context.getSpecialGroups(); List<Group> specialGroups = context.getSpecialGroups();
if(CollectionUtils.isNotEmpty(specialGroups)) { if(CollectionUtils.isNotEmpty(specialGroups)) {
Iterator<Group> it = specialGroups.iterator(); for (Group specialGroup : specialGroups)
while (it.hasNext() && !found) { {
Group next = it.next(); //Check if the current special group is the one we are looking for OR retrieve all groups & make a check here.
found = StringUtils.equals(next.getName(), groupName); if(StringUtils.equals(specialGroup.getName(), groupName) || allMemberGroups(context, currentUser).contains(findByName(context, groupName)))
} {
}
if(found) {
return true; return true;
} else { }
}
}
//lookup eperson in normal groups and subgroups //lookup eperson in normal groups and subgroups
return epersonInGroup(context, groupName, currentUser); return epersonInGroup(context, groupName, currentUser);
}
} else { } else {
return false; return false;
} }