hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-17 23:13:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

[DS-707] Inefficient use of keySet iterators

Browse Source 
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5474 9c30dcfa-912a-0410-8fc2-9e0234be79fd
This commit is contained in:
Graham Triggs
2010-10-19 21:55:07 +00:00
parent 5d22e55b48
commit 7c716b9e9b
10 changed files with 63 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
dspace-api/src/main/java/org/dspace/eperson/Group.java
View File

@@ -1255,23 +1255,10 @@ public class Group extends DSpaceObject
// so now to establish all parent,child relationships we can iterate
// through the parents hash
Iterator<Integer> i = parents.keySet().iterator();
while (i.hasNext())
for (Map.Entry<Integer, Set<Integer>> parent : parents.entrySet())
{
Integer parentID = i.next();
Set<Integer> myChildren = getChildren(parents, parentID);
Iterator<Integer> j = myChildren.iterator();
while (j.hasNext())
{
// child of a parent
Integer childID = j.next();
((Set<Integer>) parents.get(parentID)).add(childID);
}
Set<Integer> myChildren = getChildren(parents, parent.getKey());
parent.getValue().addAll(myChildren);
}
// empty out group2groupcache table