From 82c90ca15ce987db3ec2ee68cc9aa618c82b97c2 Mon Sep 17 00:00:00 2001 From: Tim Donohue Date: Fri, 7 Feb 2020 15:36:16 -0600 Subject: [PATCH] Fix errorprone warning https://errorprone.info/bugpattern/StringSplitter --- .../org/dspace/content/virtual/CollectedTest.java | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/dspace-api/src/test/java/org/dspace/content/virtual/CollectedTest.java b/dspace-api/src/test/java/org/dspace/content/virtual/CollectedTest.java index 0e265c2454..4bf896cd08 100644 --- a/dspace-api/src/test/java/org/dspace/content/virtual/CollectedTest.java +++ b/dspace-api/src/test/java/org/dspace/content/virtual/CollectedTest.java @@ -14,6 +14,7 @@ import static org.mockito.Mockito.when; import java.util.ArrayList; import java.util.List; +import com.google.common.base.Splitter; import org.dspace.content.Item; import org.dspace.content.MetadataValue; import org.dspace.content.service.ItemService; @@ -85,18 +86,15 @@ public class CollectedTest { metadataValueList.add(metadataValue); String s = "dc.title"; list.add(s); - String[] splittedString = s.split("\\."); + List splittedString = Splitter.on('.').splitToList(s); collected.setFields(list); valueList.add("TestValue"); // Mock the state of objects utilized in getValues() to meet the success criteria of an invocation - when(itemService.getMetadata(item, splittedString.length > 0 ? splittedString[0] : - null, - splittedString.length > 1 ? splittedString[1] : - null, - splittedString.length > 2 ? splittedString[2] : - null, - Item.ANY, false)).thenReturn(metadataValueList); + when(itemService.getMetadata(item, splittedString.size() > 0 ? splittedString.get(0) : null, + splittedString.size() > 1 ? splittedString.get(1) : null, + splittedString.size() > 2 ? splittedString.get(2) : null, + Item.ANY, false)).thenReturn(metadataValueList); when(metadataValue.getValue()).thenReturn("TestValue"); // The reported value(s) should match our valueList