diff --git a/dspace/CHANGES b/dspace/CHANGES index e410532535..d0e3aa7426 100644 --- a/dspace/CHANGES +++ b/dspace/CHANGES @@ -1,3 +1,7 @@ +(Ben Bosman) +- Internal error no longer occurs when COLLECTION_ADMIN is editing collection template values + SF patch #1120716, fixes SF bug #1088692. + (Filbert Minj) - Show community and collection strengths SF patch #1151795. diff --git a/dspace/jsp/dspace-admin/wizard-questions.jsp b/dspace/jsp/dspace-admin/wizard-questions.jsp index ae22bc5a62..a53f163d19 100644 --- a/dspace/jsp/dspace-admin/wizard-questions.jsp +++ b/dspace/jsp/dspace-admin/wizard-questions.jsp @@ -54,6 +54,9 @@ <% Collection collection = (Collection) request.getAttribute("collection"); %> +<% Boolean admin_b = (Boolean)request.getAttribute("admin_button"); + boolean admin_button = (admin_b == null ? false : admin_b.booleanValue()); %> +

Describe the Collection

@@ -69,7 +72,13 @@ - +
+ <% if(!admin_button ) { %> + + <% } else { %> + + <% } %> + New items should be publicly readable
@@ -79,7 +88,13 @@ - +
+ <% if(!admin_button ) { %> + + <% } else { %> + + <% } %> + Some users will be able to submit to this collection
@@ -89,7 +104,13 @@ - +
+ <% if(!admin_button ) { %> + + <% } else { %> + + <% } %> + The submission workflow will include an accept/reject step
@@ -99,7 +120,13 @@ - +
+ <% if(!admin_button ) { %> + + <% } else { %> + + <% } %> + The submission workflow will include an accept/reject/edit metadata step
@@ -109,7 +136,13 @@ - +
+ <% if(!admin_button ) { %> + + <% } else { %> + + <% } %> + The submission workflow will include an edit metadata step
@@ -119,7 +152,13 @@ - +
+ <% if(!admin_button ) { %> + + <% } else { %> + + <% } %> + This collection will have delegated collection administrators
diff --git a/dspace/src/org/dspace/app/webui/servlet/admin/CollectionWizardServlet.java b/dspace/src/org/dspace/app/webui/servlet/admin/CollectionWizardServlet.java index 237cc1e7fe..819c05ed86 100644 --- a/dspace/src/org/dspace/app/webui/servlet/admin/CollectionWizardServlet.java +++ b/dspace/src/org/dspace/app/webui/servlet/admin/CollectionWizardServlet.java @@ -173,6 +173,11 @@ public class CollectionWizardServlet extends DSpaceServlet // Create the collection Collection newCollection = c.createCollection(); request.setAttribute("collection", newCollection); + if (AuthorizeManager.isAdmin(context)) + { + // set a variable to show all buttons + request.setAttribute("admin_button", new Boolean(true)); + } JSPManager.showJSP(request, response, "/dspace-admin/wizard-questions.jsp"); context.complete(); diff --git a/dspace/src/org/dspace/content/Item.java b/dspace/src/org/dspace/content/Item.java index fe672dcc54..382b121800 100644 --- a/dspace/src/org/dspace/content/Item.java +++ b/dspace/src/org/dspace/content/Item.java @@ -1735,6 +1735,12 @@ public class Item extends DSpaceObject return true; } + // is this collection not yet created, and an item template is created + if (getOwningCollection() == null) + { + return true; + } + // is this person an COLLECTION_EDITOR for the owning collection? if (getOwningCollection().canEditBoolean()) {