hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-12 04:23:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Each of these "READ" endpoints should "autocommit", which prevents transaction abort issues (atleast with postgres).

Browse Source 
If you got an error, (i.e. negative limit is bad), then PG will barf always.
current transaction is aborted, commands ignored until end of transaction block
This commit is contained in:
Peter Dietz
2013-10-18 12:50:34 -04:00
parent 87c427b903
commit 987e835e5e
5 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dspace-rest/src/main/java/org/dspace/rest/BitstreamResource.java
View File

@@ -40,6 +40,8 @@ public class BitstreamResource {
try {
if(context == null || !context.isValid()) {
context = new Context();
//Failed SQL is ignored as a failed SQL statement, prevent: current transaction is aborted, commands ignored until end of transaction block
context.getDBConnection().setAutoCommit(true);
}
org.dspace.content.Bitstream bitstream = org.dspace.content.Bitstream.find(context, bitstream_id);
@@ -62,6 +64,8 @@ public class BitstreamResource {
try {
if(context == null || !context.isValid() ) {
context = new org.dspace.core.Context();
//Failed SQL is ignored as a failed SQL statement, prevent: current transaction is aborted, commands ignored until end of transaction block
context.getDBConnection().setAutoCommit(true);
}
org.dspace.content.Bitstream bitstream = org.dspace.content.Bitstream.find(context, bitstream_id);

6
dspace-rest/src/main/java/org/dspace/rest/CollectionsResource.java
View File

@@ -67,6 +67,8 @@ public class CollectionsResource {
try {
if(context == null || !context.isValid() ) {
context = new org.dspace.core.Context();
//Failed SQL is ignored as a failed SQL statement, prevent: current transaction is aborted, commands ignored until end of transaction block
context.getDBConnection().setAutoCommit(true);
}
org.dspace.content.Collection[] collections = org.dspace.content.Collection.findAll(context);
@@ -81,7 +83,7 @@ public class CollectionsResource {
return collectionArrayList.toArray(new org.dspace.rest.common.Collection[0]);
} catch (SQLException e) {
e.getMessage();
log.error(e.getMessage());
throw new WebApplicationException(Response.Status.INTERNAL_SERVER_ERROR);
}
}
@@ -93,6 +95,8 @@ public class CollectionsResource {
try {
if(context == null || !context.isValid() ) {
context = new Context();
//Failed SQL is ignored as a failed SQL statement, prevent: current transaction is aborted, commands ignored until end of transaction block
context.getDBConnection().setAutoCommit(true);
}
org.dspace.content.Collection collection = org.dspace.content.Collection.find(context, collection_id);

4
dspace-rest/src/main/java/org/dspace/rest/CommunitiesResource.java
View File

@@ -64,6 +64,8 @@ public class CommunitiesResource {
try {
if(context == null || !context.isValid() ) {
context = new org.dspace.core.Context();
//Failed SQL is ignored as a failed SQL statement, prevent: current transaction is aborted, commands ignored until end of transaction block
context.getDBConnection().setAutoCommit(true);
}
org.dspace.content.Community[] topCommunities = org.dspace.content.Community.findAllTop(context);
@@ -91,6 +93,8 @@ public class CommunitiesResource {
try {
if(context == null || !context.isValid() ) {
context = new org.dspace.core.Context();
//Failed SQL is ignored as a failed SQL statement, prevent: current transaction is aborted, commands ignored until end of transaction block
context.getDBConnection().setAutoCommit(true);
}
org.dspace.content.Community community = org.dspace.content.Community.find(context, community_id);

2
dspace-rest/src/main/java/org/dspace/rest/HandleResource.java
View File

@@ -40,6 +40,8 @@ public class HandleResource {
try {
if(context == null || !context.isValid() ) {
context = new Context();
//Failed SQL is ignored as a failed SQL statement, prevent: current transaction is aborted, commands ignored until end of transaction block
context.getDBConnection().setAutoCommit(true);
}
org.dspace.content.DSpaceObject dso = HandleManager.resolveToObject(context, prefix + "/" + suffix);

2
dspace-rest/src/main/java/org/dspace/rest/ItemsResource.java
View File

@@ -37,6 +37,8 @@ public class ItemsResource {
try {
if(context == null || !context.isValid()) {
context = new Context();
//Failed SQL is ignored as a failed SQL statement, prevent: current transaction is aborted, commands ignored until end of transaction block
context.getDBConnection().setAutoCommit(true);
}
org.dspace.content.Item item = org.dspace.content.Item.find(context, item_id);