hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-18 07:23:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

CrossRefImport: ignore empty responses rather than generating empty phantom ImportRecords

Browse Source 
Fixes https://github.com/DSpace/DSpace/issues/9202 .
This commit is contained in:
Philipp Rumpf
2023-11-14 09:38:35 +00:00
parent 500fbe70a3
commit 9f3f5175a3
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dspace-api/src/main/java/org/dspace/importer/external/crossref/CrossRefImportMetadataSourceServiceImpl.java vendored
View File

@@ -162,8 +162,10 @@ public class CrossRefImportMetadataSourceServiceImpl extends AbstractImportMetad
Iterator<JsonNode> nodes = jsonNode.at("/message/items").iterator(); Iterator<JsonNode> nodes = jsonNode.at("/message/items").iterator();
while (nodes.hasNext()) { while (nodes.hasNext()) {
JsonNode node = nodes.next(); JsonNode node = nodes.next();
if (!node.isMissingNode()) {
results.add(transformSourceRecords(node.toString())); results.add(transformSourceRecords(node.toString()));
} }
}
return results; return results;
} }
@@ -196,7 +198,9 @@ public class CrossRefImportMetadataSourceServiceImpl extends AbstractImportMetad
String responseString = liveImportClient.executeHttpGetRequest(1000, uriBuilder.toString(), params); String responseString = liveImportClient.executeHttpGetRequest(1000, uriBuilder.toString(), params);
JsonNode jsonNode = convertStringJsonToJsonNode(responseString); JsonNode jsonNode = convertStringJsonToJsonNode(responseString);
JsonNode messageNode = jsonNode.at("/message"); JsonNode messageNode = jsonNode.at("/message");
if (!messageNode.isMissingNode()) {
results.add(transformSourceRecords(messageNode.toString())); results.add(transformSourceRecords(messageNode.toString()));
}
return results; return results;
} }
} }
@@ -250,8 +254,10 @@ public class CrossRefImportMetadataSourceServiceImpl extends AbstractImportMetad
Iterator<JsonNode> nodes = jsonNode.at("/message/items").iterator(); Iterator<JsonNode> nodes = jsonNode.at("/message/items").iterator();
while (nodes.hasNext()) { while (nodes.hasNext()) {
JsonNode node = nodes.next(); JsonNode node = nodes.next();
if (!node.isMissingNode()) {
results.add(transformSourceRecords(node.toString())); results.add(transformSourceRecords(node.toString()));
} }
}
return results; return results;
} }