Tidy up some warnings and hints

This commit is contained in:
Mark H. Wood
2014-01-31 11:47:05 -05:00
parent bdb1b826d6
commit bd3d5eccf6

View File

@@ -29,7 +29,7 @@ import com.maxmind.geoip.LookupService;
import com.maxmind.geoip.Location; import com.maxmind.geoip.Location;
/** /**
* Class to load intermediate statistics files (produced from log files by <code>ClassicDSpaceLogConverter</code>) into Solr * Class to load intermediate statistics files (produced from log files by {@link ClassicDSpaceLogConverter}) into Solr.
* *
* @see ClassicDSpaceLogConverter * @see ClassicDSpaceLogConverter
* *
@@ -40,7 +40,7 @@ public class StatisticsImporter
private static final Logger log = Logger.getLogger(StatisticsImporter.class); private static final Logger log = Logger.getLogger(StatisticsImporter.class);
/** Date format (for solr) */ /** Date format (for solr) */
private static SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss"); private static final SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss");
/** Solr server connection */ /** Solr server connection */
private static HttpSolrServer solr; private static HttpSolrServer solr;
@@ -67,7 +67,7 @@ public class StatisticsImporter
private List<Integer> localBitstreams; private List<Integer> localBitstreams;
/** Whether or not to replace item IDs with local values (for testing) */ /** Whether or not to replace item IDs with local values (for testing) */
private boolean useLocal; private final boolean useLocal;
/** /**
* Constructor. Optionally loads local data to replace foreign data * Constructor. Optionally loads local data to replace foreign data
@@ -495,6 +495,7 @@ public class StatisticsImporter
File dir = sample.getParentFile(); File dir = sample.getParentFile();
FilenameFilter filter = new FilenameFilter() FilenameFilter filter = new FilenameFilter()
{ {
@Override
public boolean accept(File dir, String name) public boolean accept(File dir, String name)
{ {
return name.startsWith(sample.getName()); return name.startsWith(sample.getName());
@@ -522,7 +523,7 @@ public class StatisticsImporter
*/ */
static class DNSCache<K,V> extends LinkedHashMap<K,V> static class DNSCache<K,V> extends LinkedHashMap<K,V>
{ {
private int maxCapacity; private final int maxCapacity;
public DNSCache(int initialCapacity, float loadFactor, int maxCapacity) public DNSCache(int initialCapacity, float loadFactor, int maxCapacity)
{ {