();
// Get the user's IP address
- String addr = request.getRemoteAddr();
- if (useProxies == null) {
- useProxies = ConfigurationManager.getBooleanProperty("useProxies", false);
- }
- if (useProxies && request.getHeader("X-Forwarded-For") != null) {
- /* This header is a comma delimited list */
- for (String xfip : request.getHeader("X-Forwarded-For").split(",")) {
- if (!request.getHeader("X-Forwarded-For").contains(addr)) {
- addr = xfip.trim();
- }
- }
- }
+ String addr = clientInfoService.getClientIp(request);
for (IPMatcher ipm : ipMatchers) {
try {
diff --git a/dspace-api/src/main/java/org/dspace/authenticate/IPMatcher.java b/dspace-api/src/main/java/org/dspace/authenticate/IPMatcher.java
index 02825589cb..955b6c86d3 100644
--- a/dspace-api/src/main/java/org/dspace/authenticate/IPMatcher.java
+++ b/dspace-api/src/main/java/org/dspace/authenticate/IPMatcher.java
@@ -10,7 +10,7 @@ package org.dspace.authenticate;
import java.net.Inet6Address;
import java.net.UnknownHostException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
/**
*
@@ -38,7 +38,7 @@ import org.apache.log4j.Logger;
* @version $Revision$
*/
public class IPMatcher {
- private static Logger log = Logger.getLogger(IPMatcher.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(IPMatcher.class);
/**
* Network to match
diff --git a/dspace-api/src/main/java/org/dspace/authenticate/LDAPAuthentication.java b/dspace-api/src/main/java/org/dspace/authenticate/LDAPAuthentication.java
index 13ba180c0f..ae793ec433 100644
--- a/dspace-api/src/main/java/org/dspace/authenticate/LDAPAuthentication.java
+++ b/dspace-api/src/main/java/org/dspace/authenticate/LDAPAuthentication.java
@@ -28,8 +28,8 @@ import javax.naming.ldap.StartTlsResponse;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authenticate.factory.AuthenticateServiceFactory;
import org.dspace.authenticate.service.AuthenticationService;
import org.dspace.authorize.AuthorizeException;
@@ -61,7 +61,7 @@ public class LDAPAuthentication
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(LDAPAuthentication.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(LDAPAuthentication.class);
protected AuthenticationService authenticationService = AuthenticateServiceFactory.getInstance()
.getAuthenticationService();
diff --git a/dspace-api/src/main/java/org/dspace/authenticate/PasswordAuthentication.java b/dspace-api/src/main/java/org/dspace/authenticate/PasswordAuthentication.java
index a111be30ce..86cfb50c5f 100644
--- a/dspace-api/src/main/java/org/dspace/authenticate/PasswordAuthentication.java
+++ b/dspace-api/src/main/java/org/dspace/authenticate/PasswordAuthentication.java
@@ -15,7 +15,7 @@ import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.commons.lang3.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.core.Context;
import org.dspace.core.LogManager;
import org.dspace.eperson.EPerson;
@@ -49,7 +49,7 @@ public class PasswordAuthentication
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(PasswordAuthentication.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(PasswordAuthentication.class);
/**
diff --git a/dspace-api/src/main/java/org/dspace/authenticate/ShibAuthentication.java b/dspace-api/src/main/java/org/dspace/authenticate/ShibAuthentication.java
index cdea32a183..2ff0e457a8 100644
--- a/dspace-api/src/main/java/org/dspace/authenticate/ShibAuthentication.java
+++ b/dspace-api/src/main/java/org/dspace/authenticate/ShibAuthentication.java
@@ -23,8 +23,8 @@ import java.util.UUID;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authenticate.factory.AuthenticateServiceFactory;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.MetadataField;
@@ -70,7 +70,7 @@ public class ShibAuthentication implements AuthenticationMethod {
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(ShibAuthentication.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(ShibAuthentication.class);
/**
* Additional metadata mappings
diff --git a/dspace-api/src/main/java/org/dspace/authenticate/X509Authentication.java b/dspace-api/src/main/java/org/dspace/authenticate/X509Authentication.java
index da2097d0dd..df9e767116 100644
--- a/dspace-api/src/main/java/org/dspace/authenticate/X509Authentication.java
+++ b/dspace-api/src/main/java/org/dspace/authenticate/X509Authentication.java
@@ -29,8 +29,8 @@ import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;
-import org.apache.commons.lang.ArrayUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authenticate.factory.AuthenticateServiceFactory;
import org.dspace.authenticate.service.AuthenticationService;
import org.dspace.authorize.AuthorizeException;
@@ -105,7 +105,7 @@ public class X509Authentication implements AuthenticationMethod {
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(X509Authentication.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(X509Authentication.class);
/**
* public key of CA to check client certs against.
diff --git a/dspace-api/src/main/java/org/dspace/authority/AuthoritySolrServiceImpl.java b/dspace-api/src/main/java/org/dspace/authority/AuthoritySolrServiceImpl.java
index 56521ac950..2aeaa6e364 100644
--- a/dspace-api/src/main/java/org/dspace/authority/AuthoritySolrServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/authority/AuthoritySolrServiceImpl.java
@@ -12,7 +12,7 @@ import java.net.MalformedURLException;
import java.util.ArrayList;
import java.util.List;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.apache.solr.client.solrj.SolrQuery;
import org.apache.solr.client.solrj.SolrServerException;
import org.apache.solr.client.solrj.impl.HttpSolrServer;
@@ -30,7 +30,7 @@ import org.dspace.core.ConfigurationManager;
*/
public class AuthoritySolrServiceImpl implements AuthorityIndexingService, AuthoritySearchService {
- private static final Logger log = Logger.getLogger(AuthoritySolrServiceImpl.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(AuthoritySolrServiceImpl.class);
protected AuthoritySolrServiceImpl() {
diff --git a/dspace-api/src/main/java/org/dspace/authority/AuthorityTypes.java b/dspace-api/src/main/java/org/dspace/authority/AuthorityTypes.java
index 22f2f495cf..3ed16e9ce1 100644
--- a/dspace-api/src/main/java/org/dspace/authority/AuthorityTypes.java
+++ b/dspace-api/src/main/java/org/dspace/authority/AuthorityTypes.java
@@ -12,7 +12,7 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
/**
* This class contains a list of active authority types.
@@ -32,7 +32,7 @@ public class AuthorityTypes {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(AuthorityTypes.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(AuthorityTypes.class);
protected List types = new ArrayList();
diff --git a/dspace-api/src/main/java/org/dspace/authority/AuthorityValue.java b/dspace-api/src/main/java/org/dspace/authority/AuthorityValue.java
index 80d9e16289..acb5bd754d 100644
--- a/dspace-api/src/main/java/org/dspace/authority/AuthorityValue.java
+++ b/dspace-api/src/main/java/org/dspace/authority/AuthorityValue.java
@@ -14,8 +14,8 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.apache.solr.common.SolrDocument;
import org.apache.solr.common.SolrInputDocument;
import org.dspace.authorize.AuthorizeException;
@@ -234,7 +234,7 @@ public class AuthorityValue {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(AuthorityValue.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(AuthorityValue.class);
@Override
public String toString() {
diff --git a/dspace-api/src/main/java/org/dspace/authority/AuthorityValueServiceImpl.java b/dspace-api/src/main/java/org/dspace/authority/AuthorityValueServiceImpl.java
index 7780c79232..194da3eba5 100644
--- a/dspace-api/src/main/java/org/dspace/authority/AuthorityValueServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/authority/AuthorityValueServiceImpl.java
@@ -13,8 +13,8 @@ import java.util.List;
import java.util.Map;
import java.util.UUID;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.apache.solr.client.solrj.SolrQuery;
import org.apache.solr.client.solrj.response.QueryResponse;
import org.apache.solr.common.SolrDocument;
@@ -34,7 +34,7 @@ import org.springframework.beans.factory.annotation.Autowired;
*/
public class AuthorityValueServiceImpl implements AuthorityValueService {
- private final Logger log = Logger.getLogger(AuthorityValueServiceImpl.class);
+ private final Logger log = org.apache.logging.log4j.LogManager.getLogger(AuthorityValueServiceImpl.class);
@Autowired(required = true)
protected AuthorityTypes authorityTypes;
diff --git a/dspace-api/src/main/java/org/dspace/authority/PersonAuthorityValue.java b/dspace-api/src/main/java/org/dspace/authority/PersonAuthorityValue.java
index 179e06fc79..f937b5f7ed 100644
--- a/dspace-api/src/main/java/org/dspace/authority/PersonAuthorityValue.java
+++ b/dspace-api/src/main/java/org/dspace/authority/PersonAuthorityValue.java
@@ -12,8 +12,8 @@ import java.util.Collection;
import java.util.List;
import java.util.Map;
-import org.apache.commons.lang.ObjectUtils;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.ObjectUtils;
+import org.apache.commons.lang3.StringUtils;
import org.apache.solr.common.SolrDocument;
import org.apache.solr.common.SolrInputDocument;
diff --git a/dspace-api/src/main/java/org/dspace/authority/UpdateAuthorities.java b/dspace-api/src/main/java/org/dspace/authority/UpdateAuthorities.java
index 44fd0a9241..db008c9db6 100644
--- a/dspace-api/src/main/java/org/dspace/authority/UpdateAuthorities.java
+++ b/dspace-api/src/main/java/org/dspace/authority/UpdateAuthorities.java
@@ -19,7 +19,7 @@ import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.ParseException;
import org.apache.commons.cli.PosixParser;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authority.factory.AuthorityServiceFactory;
import org.dspace.authority.service.AuthorityValueService;
import org.dspace.content.Item;
@@ -40,7 +40,7 @@ public class UpdateAuthorities {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(UpdateAuthorities.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(UpdateAuthorities.class);
protected PrintWriter print = null;
diff --git a/dspace-api/src/main/java/org/dspace/authority/indexer/AuthorityConsumer.java b/dspace-api/src/main/java/org/dspace/authority/indexer/AuthorityConsumer.java
index c5029db53a..2105aa9488 100644
--- a/dspace-api/src/main/java/org/dspace/authority/indexer/AuthorityConsumer.java
+++ b/dspace-api/src/main/java/org/dspace/authority/indexer/AuthorityConsumer.java
@@ -12,7 +12,7 @@ import java.util.HashSet;
import java.util.Set;
import java.util.UUID;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authority.factory.AuthorityServiceFactory;
import org.dspace.authority.service.AuthorityService;
import org.dspace.content.DSpaceObject;
@@ -33,7 +33,7 @@ import org.dspace.event.Event;
*/
public class AuthorityConsumer implements Consumer {
- private final Logger log = Logger.getLogger(AuthorityConsumer.class);
+ private final Logger log = org.apache.logging.log4j.LogManager.getLogger(AuthorityConsumer.class);
/**
* A set of all item IDs installed which need their authority updated
diff --git a/dspace-api/src/main/java/org/dspace/authority/indexer/AuthorityIndexClient.java b/dspace-api/src/main/java/org/dspace/authority/indexer/AuthorityIndexClient.java
index 2b933a3bff..f2a4dcf6c4 100644
--- a/dspace-api/src/main/java/org/dspace/authority/indexer/AuthorityIndexClient.java
+++ b/dspace-api/src/main/java/org/dspace/authority/indexer/AuthorityIndexClient.java
@@ -12,7 +12,7 @@ import java.util.Iterator;
import java.util.List;
import java.util.Map;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authority.AuthorityValue;
import org.dspace.authority.factory.AuthorityServiceFactory;
import org.dspace.authority.service.AuthorityService;
@@ -29,7 +29,7 @@ import org.dspace.core.Context;
*/
public class AuthorityIndexClient {
- private static Logger log = Logger.getLogger(AuthorityIndexClient.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(AuthorityIndexClient.class);
protected static final AuthorityService authorityService =
AuthorityServiceFactory.getInstance().getAuthorityService();
diff --git a/dspace-api/src/main/java/org/dspace/authority/indexer/DSpaceAuthorityIndexer.java b/dspace-api/src/main/java/org/dspace/authority/indexer/DSpaceAuthorityIndexer.java
index 3b8cc1daf8..20baef8f9c 100644
--- a/dspace-api/src/main/java/org/dspace/authority/indexer/DSpaceAuthorityIndexer.java
+++ b/dspace-api/src/main/java/org/dspace/authority/indexer/DSpaceAuthorityIndexer.java
@@ -13,8 +13,8 @@ import java.util.List;
import java.util.Map;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authority.AuthorityValue;
import org.dspace.authority.service.AuthorityValueService;
import org.dspace.authorize.AuthorizeException;
@@ -45,7 +45,7 @@ import org.springframework.beans.factory.annotation.Autowired;
*/
public class DSpaceAuthorityIndexer implements AuthorityIndexerInterface, InitializingBean {
- private static final Logger log = Logger.getLogger(DSpaceAuthorityIndexer.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(DSpaceAuthorityIndexer.class);
/**
* The list of metadata fields which are to be indexed *
@@ -124,7 +124,7 @@ public class DSpaceAuthorityIndexer implements AuthorityIndexerInterface, Initia
* This method looks at the authority of a metadata value.
* If the authority can be found in solr, that value is reused.
* Otherwise a new authority value will be generated that will be indexed in solr.
- *
+ *
* If the authority starts with AuthorityValueGenerator.GENERATE, a specific type of AuthorityValue will be
* generated.
* Depending on the type this may involve querying an external REST service
diff --git a/dspace-api/src/main/java/org/dspace/authority/orcid/Orcidv2.java b/dspace-api/src/main/java/org/dspace/authority/orcid/Orcidv2.java
index cf97bbe442..a545c6cf9e 100644
--- a/dspace-api/src/main/java/org/dspace/authority/orcid/Orcidv2.java
+++ b/dspace-api/src/main/java/org/dspace/authority/orcid/Orcidv2.java
@@ -15,12 +15,13 @@ import java.net.URLEncoder;
import java.util.ArrayList;
import java.util.List;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
import org.apache.http.HttpResponse;
import org.apache.http.client.HttpClient;
import org.apache.http.client.methods.HttpPost;
import org.apache.http.impl.client.HttpClientBuilder;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.dspace.authority.AuthorityValue;
import org.dspace.authority.SolrAuthorityInterface;
import org.dspace.authority.orcid.xml.XMLtoBio;
@@ -35,7 +36,7 @@ import org.orcid.jaxb.model.record_v2.Person;
*/
public class Orcidv2 implements SolrAuthorityInterface {
- private static Logger log = Logger.getLogger(Orcidv2.class);
+ private static Logger log = LogManager.getLogger(Orcidv2.class);
public RESTConnector restConnector;
private String OAUTHUrl;
@@ -46,7 +47,9 @@ public class Orcidv2 implements SolrAuthorityInterface {
private String accessToken;
/**
- * Initialize the accessToken that is required for all subsequent calls to ORCID
+ * Initialize the accessToken that is required for all subsequent calls to ORCID.
+ *
+ * @throws java.io.IOException passed through from HTTPclient.
*/
public void init() throws IOException {
if (StringUtils.isNotBlank(accessToken) && StringUtils.isNotBlank(clientSecret)) {
diff --git a/dspace-api/src/main/java/org/dspace/authority/orcid/Orcidv2AuthorityValue.java b/dspace-api/src/main/java/org/dspace/authority/orcid/Orcidv2AuthorityValue.java
index 0aa0d292e7..456ccacd4d 100644
--- a/dspace-api/src/main/java/org/dspace/authority/orcid/Orcidv2AuthorityValue.java
+++ b/dspace-api/src/main/java/org/dspace/authority/orcid/Orcidv2AuthorityValue.java
@@ -15,7 +15,7 @@ import java.util.List;
import java.util.Map;
import java.util.UUID;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
import org.apache.solr.common.SolrDocument;
import org.apache.solr.common.SolrInputDocument;
import org.dspace.authority.AuthorityValue;
diff --git a/dspace-api/src/main/java/org/dspace/authority/orcid/xml/Converter.java b/dspace-api/src/main/java/org/dspace/authority/orcid/xml/Converter.java
index 784a3fdf24..d55f9d4eee 100644
--- a/dspace-api/src/main/java/org/dspace/authority/orcid/xml/Converter.java
+++ b/dspace-api/src/main/java/org/dspace/authority/orcid/xml/Converter.java
@@ -14,10 +14,9 @@ import javax.xml.bind.JAXBContext;
import javax.xml.bind.JAXBException;
import javax.xml.bind.Unmarshaller;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.xml.sax.SAXException;
-
/**
* @param type
* @author Antoine Snyers (antoine at atmire.com)
@@ -30,7 +29,7 @@ public abstract class Converter {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(Converter.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(Converter.class);
public abstract T convert(InputStream document);
diff --git a/dspace-api/src/main/java/org/dspace/authority/orcid/xml/XMLtoBio.java b/dspace-api/src/main/java/org/dspace/authority/orcid/xml/XMLtoBio.java
index 9fb4a50d5f..d7fdb4dc81 100644
--- a/dspace-api/src/main/java/org/dspace/authority/orcid/xml/XMLtoBio.java
+++ b/dspace-api/src/main/java/org/dspace/authority/orcid/xml/XMLtoBio.java
@@ -12,7 +12,7 @@ import java.net.URISyntaxException;
import java.util.ArrayList;
import java.util.List;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authority.orcid.Orcidv2;
import org.dspace.utils.DSpace;
import org.orcid.jaxb.model.common_v2.OrcidId;
@@ -21,8 +21,6 @@ import org.orcid.jaxb.model.search_v2.Result;
import org.orcid.jaxb.model.search_v2.Search;
import org.xml.sax.SAXException;
-
-
/**
* @author Antoine Snyers (antoine at atmire.com)
* @author Kevin Van de Velde (kevin at atmire dot com)
@@ -34,7 +32,7 @@ public class XMLtoBio extends Converter {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(XMLtoBio.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(XMLtoBio.class);
@Override
public List convert(InputStream xml) {
diff --git a/dspace-api/src/main/java/org/dspace/authority/rest/RESTConnector.java b/dspace-api/src/main/java/org/dspace/authority/rest/RESTConnector.java
index cfa21a66cb..df88985d3a 100644
--- a/dspace-api/src/main/java/org/dspace/authority/rest/RESTConnector.java
+++ b/dspace-api/src/main/java/org/dspace/authority/rest/RESTConnector.java
@@ -15,7 +15,7 @@ import org.apache.http.HttpResponse;
import org.apache.http.client.HttpClient;
import org.apache.http.client.methods.HttpGet;
import org.apache.http.impl.client.HttpClientBuilder;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
/**
* @author Antoine Snyers (antoine at atmire.com)
@@ -28,7 +28,7 @@ public class RESTConnector {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(RESTConnector.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(RESTConnector.class);
private String url;
diff --git a/dspace-api/src/main/java/org/dspace/authority/util/EnumUtils.java b/dspace-api/src/main/java/org/dspace/authority/util/EnumUtils.java
index 72dc41d6b9..43239ea459 100644
--- a/dspace-api/src/main/java/org/dspace/authority/util/EnumUtils.java
+++ b/dspace-api/src/main/java/org/dspace/authority/util/EnumUtils.java
@@ -7,8 +7,8 @@
*/
package org.dspace.authority.util;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
/**
* @author Antoine Snyers (antoine at atmire.com)
@@ -21,7 +21,7 @@ public class EnumUtils {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(EnumUtils.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(EnumUtils.class);
/**
* Default constructor
diff --git a/dspace-api/src/main/java/org/dspace/authority/util/XMLUtils.java b/dspace-api/src/main/java/org/dspace/authority/util/XMLUtils.java
index 5249f599e3..77568205af 100644
--- a/dspace-api/src/main/java/org/dspace/authority/util/XMLUtils.java
+++ b/dspace-api/src/main/java/org/dspace/authority/util/XMLUtils.java
@@ -17,7 +17,7 @@ import javax.xml.parsers.ParserConfigurationException;
import javax.xml.transform.TransformerException;
import javax.xml.xpath.XPathExpressionException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.apache.xpath.XPathAPI;
import org.w3c.dom.Document;
import org.w3c.dom.Element;
@@ -36,7 +36,7 @@ public class XMLUtils {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(XMLUtils.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(XMLUtils.class);
/**
* Default constructor
diff --git a/dspace-api/src/main/java/org/dspace/authorize/AuthorizeServiceImpl.java b/dspace-api/src/main/java/org/dspace/authorize/AuthorizeServiceImpl.java
index 8eca4ccf52..936a7d6492 100644
--- a/dspace-api/src/main/java/org/dspace/authorize/AuthorizeServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/authorize/AuthorizeServiceImpl.java
@@ -16,7 +16,7 @@ import java.util.List;
import java.util.UUID;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
import org.dspace.authorize.service.AuthorizeService;
import org.dspace.authorize.service.ResourcePolicyService;
import org.dspace.content.Bitstream;
diff --git a/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicy.java b/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicy.java
index 68d7ecd4f5..f4208e5835 100644
--- a/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicy.java
+++ b/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicy.java
@@ -23,7 +23,7 @@ import javax.persistence.Table;
import javax.persistence.Temporal;
import javax.persistence.TemporalType;
-import org.apache.commons.lang.ObjectUtils;
+import org.apache.commons.lang3.ObjectUtils;
import org.dspace.content.DSpaceObject;
import org.dspace.core.Context;
import org.dspace.core.ReloadableEntity;
diff --git a/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicyServiceImpl.java b/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicyServiceImpl.java
index 2609c6d165..4693599c31 100644
--- a/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicyServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicyServiceImpl.java
@@ -15,8 +15,8 @@ import java.util.List;
import java.util.Set;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang.ObjectUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.ObjectUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.dao.ResourcePolicyDAO;
import org.dspace.authorize.service.ResourcePolicyService;
import org.dspace.content.DSpaceObject;
@@ -38,7 +38,7 @@ public class ResourcePolicyServiceImpl implements ResourcePolicyService {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(ResourcePolicyServiceImpl.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(ResourcePolicyServiceImpl.class);
@Autowired(required = true)
protected ContentServiceFactory contentServiceFactory;
diff --git a/dspace-api/src/main/java/org/dspace/authorize/dao/impl/ResourcePolicyDAOImpl.java b/dspace-api/src/main/java/org/dspace/authorize/dao/impl/ResourcePolicyDAOImpl.java
index 22095fa0b1..a0f69dc526 100644
--- a/dspace-api/src/main/java/org/dspace/authorize/dao/impl/ResourcePolicyDAOImpl.java
+++ b/dspace-api/src/main/java/org/dspace/authorize/dao/impl/ResourcePolicyDAOImpl.java
@@ -9,17 +9,19 @@ package org.dspace.authorize.dao.impl;
import java.sql.SQLException;
import java.util.List;
+import javax.persistence.Query;
+import javax.persistence.criteria.CriteriaBuilder;
+import javax.persistence.criteria.CriteriaQuery;
+import javax.persistence.criteria.Root;
import org.dspace.authorize.ResourcePolicy;
+import org.dspace.authorize.ResourcePolicy_;
import org.dspace.authorize.dao.ResourcePolicyDAO;
import org.dspace.content.DSpaceObject;
import org.dspace.core.AbstractHibernateDAO;
import org.dspace.core.Context;
import org.dspace.eperson.EPerson;
import org.dspace.eperson.Group;
-import org.hibernate.Criteria;
-import org.hibernate.Query;
-import org.hibernate.criterion.Restrictions;
/**
* Hibernate implementation of the Database Access Object interface class for the ResourcePolicy object.
@@ -36,79 +38,104 @@ public class ResourcePolicyDAOImpl extends AbstractHibernateDAO
@Override
public List findByDso(Context context, DSpaceObject dso) throws SQLException {
- Criteria criteria = createCriteria(context, ResourcePolicy.class);
- criteria.add(Restrictions.and(
- Restrictions.eq("dSpaceObject", dso)
- ));
- return list(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, ResourcePolicy.class);
+ Root resourcePolicyRoot = criteriaQuery.from(ResourcePolicy.class);
+ criteriaQuery.select(resourcePolicyRoot);
+ criteriaQuery.where(criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.dSpaceObject), dso));
+ return list(context, criteriaQuery, false, ResourcePolicy.class, -1, -1);
}
@Override
public List findByDsoAndType(Context context, DSpaceObject dso, String type) throws SQLException {
- Criteria criteria = createCriteria(context, ResourcePolicy.class);
- criteria.add(Restrictions.and(
- Restrictions.eq("dSpaceObject", dso),
- Restrictions.eq("rptype", type)
- ));
- return list(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, ResourcePolicy.class);
+ Root resourcePolicyRoot = criteriaQuery.from(ResourcePolicy.class);
+ criteriaQuery.select(resourcePolicyRoot);
+ criteriaQuery
+ .where(criteriaBuilder.and(criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.dSpaceObject), dso),
+ criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.rptype), type)
+ )
+ );
+ return list(context, criteriaQuery, false, ResourcePolicy.class, -1, -1);
}
@Override
public List findByGroup(Context context, Group group) throws SQLException {
- Criteria criteria = createCriteria(context, ResourcePolicy.class);
- criteria.add(Restrictions.eq("epersonGroup", group));
- return list(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, ResourcePolicy.class);
+ Root resourcePolicyRoot = criteriaQuery.from(ResourcePolicy.class);
+ criteriaQuery.select(resourcePolicyRoot);
+ criteriaQuery.where(criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.epersonGroup), group));
+ return list(context, criteriaQuery, false, ResourcePolicy.class, -1, -1);
}
@Override
public List findByDSoAndAction(Context context, DSpaceObject dso, int actionId)
throws SQLException {
- Criteria criteria = createCriteria(context, ResourcePolicy.class);
- criteria.add(Restrictions.and(
- Restrictions.eq("dSpaceObject", dso),
- Restrictions.eq("actionId", actionId)
- ));
- return list(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, ResourcePolicy.class);
+ Root resourcePolicyRoot = criteriaQuery.from(ResourcePolicy.class);
+ criteriaQuery.select(resourcePolicyRoot);
+ criteriaQuery
+ .where(criteriaBuilder.and(criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.dSpaceObject), dso),
+ criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.actionId), actionId)
+ )
+ );
+ return list(context, criteriaQuery, false, ResourcePolicy.class, -1, -1);
}
@Override
public List findByTypeGroupAction(Context context, DSpaceObject dso, Group group, int action)
throws SQLException {
- Criteria criteria = createCriteria(context, ResourcePolicy.class);
- criteria.add(Restrictions.and(
- Restrictions.eq("dSpaceObject", dso),
- Restrictions.eq("epersonGroup", group),
- Restrictions.eq("actionId", action)
- ));
- criteria.setMaxResults(1);
- return list(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, ResourcePolicy.class);
+ Root resourcePolicyRoot = criteriaQuery.from(ResourcePolicy.class);
+ criteriaQuery.select(resourcePolicyRoot);
+ criteriaQuery
+ .where(criteriaBuilder.and(criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.dSpaceObject), dso),
+ criteriaBuilder
+ .equal(resourcePolicyRoot.get(ResourcePolicy_.epersonGroup), group),
+ criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.actionId), action)
+ )
+ );
+ return list(context, criteriaQuery, false, ResourcePolicy.class, 1, -1);
}
@Override
public List findByTypeGroupActionExceptId(Context context, DSpaceObject dso, Group group,
int action, int notPolicyID) throws SQLException {
- Criteria criteria = createCriteria(context, ResourcePolicy.class);
- criteria.add(Restrictions.and(
- Restrictions.eq("dSpaceObject", dso),
- Restrictions.eq("epersonGroup", group),
- Restrictions.eq("actionId", action)
- ));
- criteria.add(Restrictions.and(Restrictions.not(Restrictions.eq("id", notPolicyID))));
- return list(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, ResourcePolicy.class);
+ Root resourcePolicyRoot = criteriaQuery.from(ResourcePolicy.class);
+ criteriaQuery.select(resourcePolicyRoot);
+ criteriaQuery
+ .where(criteriaBuilder.and(criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.dSpaceObject), dso),
+ criteriaBuilder
+ .equal(resourcePolicyRoot.get(ResourcePolicy_.epersonGroup), group),
+ criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.actionId), action),
+ criteriaBuilder.notEqual(resourcePolicyRoot.get(ResourcePolicy_.id), notPolicyID)
+ )
+ );
+ return list(context, criteriaQuery, false, ResourcePolicy.class, 1, -1);
}
public List findByEPersonGroupTypeIdAction(Context context, EPerson e, List groups,
int action, int type_id) throws SQLException {
- Criteria criteria = createCriteria(context, ResourcePolicy.class);
- criteria.add(Restrictions.and(
- Restrictions.eq("resourceTypeId", type_id),
- Restrictions.eq("actionId", action),
- (Restrictions.or(
- Restrictions.eq("eperson", e),
- Restrictions.in("epersonGroup", groups)
- ))
- ));
- return list(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, ResourcePolicy.class);
+ Root resourcePolicyRoot = criteriaQuery.from(ResourcePolicy.class);
+ criteriaQuery.select(resourcePolicyRoot);
+ criteriaQuery.where(
+ criteriaBuilder.and(criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.resourceTypeId), type_id),
+ criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.actionId), action),
+ criteriaBuilder
+ .or(criteriaBuilder.equal(resourcePolicyRoot.get(ResourcePolicy_.eperson), e),
+ criteriaBuilder
+ .in(resourcePolicyRoot.get(ResourcePolicy_.epersonGroup).in(groups)))
+ )
+ );
+ return list(context, criteriaQuery, false, ResourcePolicy.class, 1, -1);
}
@Override
@@ -124,7 +151,7 @@ public class ResourcePolicyDAOImpl extends AbstractHibernateDAO
String queryString = "delete from ResourcePolicy where dSpaceObject= :dSpaceObject AND actionId= :actionId";
Query query = createQuery(context, queryString);
query.setParameter("dSpaceObject", dso);
- query.setInteger("actionId", actionId);
+ query.setParameter("actionId", actionId);
query.executeUpdate();
}
@@ -133,7 +160,7 @@ public class ResourcePolicyDAOImpl extends AbstractHibernateDAO
String queryString = "delete from ResourcePolicy where dSpaceObject.id = :dsoId AND rptype = :rptype";
Query query = createQuery(context, queryString);
query.setParameter("dsoId", dso.getID());
- query.setString("rptype", type);
+ query.setParameter("rptype", type);
query.executeUpdate();
}
diff --git a/dspace-api/src/main/java/org/dspace/browse/BrowseEngine.java b/dspace-api/src/main/java/org/dspace/browse/BrowseEngine.java
index f7fb0b21ee..302d46eb0d 100644
--- a/dspace-api/src/main/java/org/dspace/browse/BrowseEngine.java
+++ b/dspace-api/src/main/java/org/dspace/browse/BrowseEngine.java
@@ -12,7 +12,7 @@ import java.util.ArrayList;
import java.util.List;
import org.apache.commons.lang3.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.content.Collection;
import org.dspace.content.Community;
import org.dspace.content.Item;
@@ -34,7 +34,7 @@ public class BrowseEngine {
/**
* the logger for this class
*/
- private static final Logger log = Logger.getLogger(BrowseEngine.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(BrowseEngine.class);
/**
* the browse scope which is the basis for our browse
diff --git a/dspace-api/src/main/java/org/dspace/browse/ItemCountDAOSolr.java b/dspace-api/src/main/java/org/dspace/browse/ItemCountDAOSolr.java
index e39a584684..4b741847a8 100644
--- a/dspace-api/src/main/java/org/dspace/browse/ItemCountDAOSolr.java
+++ b/dspace-api/src/main/java/org/dspace/browse/ItemCountDAOSolr.java
@@ -11,7 +11,7 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.content.Collection;
import org.dspace.content.Community;
import org.dspace.content.DSpaceObject;
@@ -36,7 +36,7 @@ public class ItemCountDAOSolr implements ItemCountDAO {
/**
* Log4j logger
*/
- private static Logger log = Logger.getLogger(ItemCountDAOSolr.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(ItemCountDAOSolr.class);
/**
* DSpace context
diff --git a/dspace-api/src/main/java/org/dspace/browse/ItemCounter.java b/dspace-api/src/main/java/org/dspace/browse/ItemCounter.java
index 9b91f7afb9..c9c140fb0b 100644
--- a/dspace-api/src/main/java/org/dspace/browse/ItemCounter.java
+++ b/dspace-api/src/main/java/org/dspace/browse/ItemCounter.java
@@ -9,7 +9,7 @@ package org.dspace.browse;
import java.sql.SQLException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.content.Collection;
import org.dspace.content.Community;
import org.dspace.content.DSpaceObject;
@@ -37,7 +37,7 @@ public class ItemCounter {
/**
* Log4j logger
*/
- private static Logger log = Logger.getLogger(ItemCounter.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(ItemCounter.class);
/**
* DAO to use to store and retrieve data
diff --git a/dspace-api/src/main/java/org/dspace/browse/ItemListConfig.java b/dspace-api/src/main/java/org/dspace/browse/ItemListConfig.java
index 58e3d83a0c..9cbbe8f194 100644
--- a/dspace-api/src/main/java/org/dspace/browse/ItemListConfig.java
+++ b/dspace-api/src/main/java/org/dspace/browse/ItemListConfig.java
@@ -12,7 +12,7 @@ import java.util.HashMap;
import java.util.Map;
import java.util.StringTokenizer;
-import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang3.ArrayUtils;
import org.dspace.services.ConfigurationService;
import org.dspace.services.factory.DSpaceServicesFactory;
diff --git a/dspace-api/src/main/java/org/dspace/browse/LocaleOrderingFilter.java b/dspace-api/src/main/java/org/dspace/browse/LocaleOrderingFilter.java
index 40f889233a..c2a2bd9804 100644
--- a/dspace-api/src/main/java/org/dspace/browse/LocaleOrderingFilter.java
+++ b/dspace-api/src/main/java/org/dspace/browse/LocaleOrderingFilter.java
@@ -12,7 +12,7 @@ import java.util.Locale;
import com.ibm.icu.text.CollationElementIterator;
import com.ibm.icu.text.Collator;
import com.ibm.icu.text.RuleBasedCollator;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.core.ConfigurationManager;
import org.dspace.text.filter.TextFilter;
@@ -32,7 +32,7 @@ import org.dspace.text.filter.TextFilter;
* @author Graham Triggs
*/
public class LocaleOrderingFilter implements TextFilter {
- private static Logger log = Logger.getLogger(LocaleOrderingFilter.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(LocaleOrderingFilter.class);
/**
* Uses a Locale dependent Collator to generate a sort string
diff --git a/dspace-api/src/main/java/org/dspace/browse/SolrBrowseDAO.java b/dspace-api/src/main/java/org/dspace/browse/SolrBrowseDAO.java
index 3e5415f7d4..98d5b8bbcb 100644
--- a/dspace-api/src/main/java/org/dspace/browse/SolrBrowseDAO.java
+++ b/dspace-api/src/main/java/org/dspace/browse/SolrBrowseDAO.java
@@ -16,7 +16,7 @@ import java.util.List;
import java.util.UUID;
import org.apache.commons.lang3.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.factory.AuthorizeServiceFactory;
import org.dspace.authorize.service.AuthorizeService;
import org.dspace.content.DSpaceObject;
@@ -68,7 +68,7 @@ public class SolrBrowseDAO implements BrowseDAO {
/**
* Log4j log
*/
- private static final Logger log = Logger.getLogger(SolrBrowseDAO.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(SolrBrowseDAO.class);
/**
* The DSpace context
diff --git a/dspace-api/src/main/java/org/dspace/checker/CheckerCommand.java b/dspace-api/src/main/java/org/dspace/checker/CheckerCommand.java
index 2ae27e5ec6..6b16d51bfe 100644
--- a/dspace-api/src/main/java/org/dspace/checker/CheckerCommand.java
+++ b/dspace-api/src/main/java/org/dspace/checker/CheckerCommand.java
@@ -13,7 +13,7 @@ import java.util.Date;
import java.util.Map;
import org.apache.commons.collections4.MapUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.checker.factory.CheckerServiceFactory;
import org.dspace.checker.service.ChecksumHistoryService;
import org.dspace.checker.service.ChecksumResultService;
@@ -42,7 +42,7 @@ public final class CheckerCommand {
/**
* Usual Log4J logger.
*/
- private static final Logger LOG = Logger.getLogger(CheckerCommand.class);
+ private static final Logger LOG = org.apache.logging.log4j.LogManager.getLogger(CheckerCommand.class);
private Context context;
diff --git a/dspace-api/src/main/java/org/dspace/checker/CheckerConsumer.java b/dspace-api/src/main/java/org/dspace/checker/CheckerConsumer.java
index f4266a7a79..4601e3867f 100644
--- a/dspace-api/src/main/java/org/dspace/checker/CheckerConsumer.java
+++ b/dspace-api/src/main/java/org/dspace/checker/CheckerConsumer.java
@@ -7,7 +7,7 @@
*/
package org.dspace.checker;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.checker.factory.CheckerServiceFactory;
import org.dspace.checker.service.ChecksumHistoryService;
import org.dspace.content.Bitstream;
@@ -26,7 +26,7 @@ public class CheckerConsumer implements Consumer {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(CheckerConsumer.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(CheckerConsumer.class);
protected ChecksumHistoryService checksumHistoryService = CheckerServiceFactory.getInstance()
.getChecksumHistoryService();
diff --git a/dspace-api/src/main/java/org/dspace/checker/DailyReportEmailer.java b/dspace-api/src/main/java/org/dspace/checker/DailyReportEmailer.java
index 0b54ede0c5..56dabb0460 100644
--- a/dspace-api/src/main/java/org/dspace/checker/DailyReportEmailer.java
+++ b/dspace-api/src/main/java/org/dspace/checker/DailyReportEmailer.java
@@ -21,7 +21,7 @@ import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.ParseException;
import org.apache.commons.cli.PosixParser;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.checker.factory.CheckerServiceFactory;
import org.dspace.checker.service.SimpleReporterService;
import org.dspace.core.ConfigurationManager;
@@ -43,7 +43,7 @@ public class DailyReportEmailer {
/**
* log4j logger.
*/
- private static Logger log = Logger.getLogger(DailyReportEmailer.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(DailyReportEmailer.class);
/**
* Default constructor.
diff --git a/dspace-api/src/main/java/org/dspace/checker/HandleDispatcher.java b/dspace-api/src/main/java/org/dspace/checker/HandleDispatcher.java
index cec2d8f566..e68b37e180 100644
--- a/dspace-api/src/main/java/org/dspace/checker/HandleDispatcher.java
+++ b/dspace-api/src/main/java/org/dspace/checker/HandleDispatcher.java
@@ -12,7 +12,7 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.Iterator;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.content.Bitstream;
import org.dspace.content.DSpaceObject;
import org.dspace.content.factory.ContentServiceFactory;
@@ -35,7 +35,7 @@ public class HandleDispatcher implements BitstreamDispatcher {
/**
* Log 4j logger.
*/
- private static final Logger LOG = Logger.getLogger(HandleDispatcher.class);
+ private static final Logger LOG = org.apache.logging.log4j.LogManager.getLogger(HandleDispatcher.class);
protected Context context;
diff --git a/dspace-api/src/main/java/org/dspace/checker/MostRecentChecksum.java b/dspace-api/src/main/java/org/dspace/checker/MostRecentChecksum.java
index f6af3d171b..5962d19f68 100644
--- a/dspace-api/src/main/java/org/dspace/checker/MostRecentChecksum.java
+++ b/dspace-api/src/main/java/org/dspace/checker/MostRecentChecksum.java
@@ -19,8 +19,8 @@ import javax.persistence.Temporal;
import javax.persistence.TemporalType;
import javax.persistence.Transient;
-import org.apache.commons.lang.builder.EqualsBuilder;
-import org.apache.commons.lang.builder.HashCodeBuilder;
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
import org.dspace.content.Bitstream;
/**
diff --git a/dspace-api/src/main/java/org/dspace/checker/MostRecentChecksumServiceImpl.java b/dspace-api/src/main/java/org/dspace/checker/MostRecentChecksumServiceImpl.java
index 82a8ace677..d267171aa0 100644
--- a/dspace-api/src/main/java/org/dspace/checker/MostRecentChecksumServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/checker/MostRecentChecksumServiceImpl.java
@@ -11,7 +11,7 @@ import java.sql.SQLException;
import java.util.Date;
import java.util.List;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.checker.dao.MostRecentChecksumDAO;
import org.dspace.checker.service.ChecksumResultService;
import org.dspace.checker.service.MostRecentChecksumService;
@@ -28,7 +28,8 @@ import org.springframework.beans.factory.annotation.Autowired;
* @author kevinvandevelde at atmire.com
*/
public class MostRecentChecksumServiceImpl implements MostRecentChecksumService {
- private static final Logger log = Logger.getLogger(MostRecentChecksumServiceImpl.class);
+ private static final Logger log =
+ org.apache.logging.log4j.LogManager.getLogger(MostRecentChecksumServiceImpl.class);
@Autowired(required = true)
protected MostRecentChecksumDAO mostRecentChecksumDAO;
diff --git a/dspace-api/src/main/java/org/dspace/checker/ResultsLogger.java b/dspace-api/src/main/java/org/dspace/checker/ResultsLogger.java
index e0cf489d8c..358d0c4018 100644
--- a/dspace-api/src/main/java/org/dspace/checker/ResultsLogger.java
+++ b/dspace-api/src/main/java/org/dspace/checker/ResultsLogger.java
@@ -12,7 +12,7 @@ import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.Date;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.content.Bitstream;
import org.dspace.core.Context;
import org.dspace.core.I18nUtil;
@@ -30,7 +30,7 @@ public class ResultsLogger implements ChecksumResultsCollector {
/**
* Usual Log4J logger.
*/
- private static final Logger LOG = Logger.getLogger(ResultsLogger.class);
+ private static final Logger LOG = org.apache.logging.log4j.LogManager.getLogger(ResultsLogger.class);
/**
* Utility date format.
diff --git a/dspace-api/src/main/java/org/dspace/checker/ResultsPruner.java b/dspace-api/src/main/java/org/dspace/checker/ResultsPruner.java
index 2d595a19f8..d3c0b130da 100644
--- a/dspace-api/src/main/java/org/dspace/checker/ResultsPruner.java
+++ b/dspace-api/src/main/java/org/dspace/checker/ResultsPruner.java
@@ -19,7 +19,7 @@ import java.util.Properties;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.checker.factory.CheckerServiceFactory;
import org.dspace.checker.service.ChecksumHistoryService;
import org.dspace.core.ConfigurationManager;
@@ -40,7 +40,7 @@ public final class ResultsPruner {
/**
* Default logger.
*/
- private static final Logger LOG = Logger.getLogger(ResultsPruner.class);
+ private static final Logger LOG = org.apache.logging.log4j.LogManager.getLogger(ResultsPruner.class);
/**
* Factory method for the default results pruner configuration using
diff --git a/dspace-api/src/main/java/org/dspace/checker/dao/impl/ChecksumHistoryDAOImpl.java b/dspace-api/src/main/java/org/dspace/checker/dao/impl/ChecksumHistoryDAOImpl.java
index 753bb6267d..328d4a717e 100644
--- a/dspace-api/src/main/java/org/dspace/checker/dao/impl/ChecksumHistoryDAOImpl.java
+++ b/dspace-api/src/main/java/org/dspace/checker/dao/impl/ChecksumHistoryDAOImpl.java
@@ -9,6 +9,8 @@ package org.dspace.checker.dao.impl;
import java.sql.SQLException;
import java.util.Date;
+import javax.persistence.Query;
+import javax.persistence.TemporalType;
import org.dspace.checker.ChecksumHistory;
import org.dspace.checker.ChecksumResultCode;
@@ -16,7 +18,6 @@ import org.dspace.checker.dao.ChecksumHistoryDAO;
import org.dspace.content.Bitstream;
import org.dspace.core.AbstractHibernateDAO;
import org.dspace.core.Context;
-import org.hibernate.Query;
/**
*
@@ -29,6 +30,8 @@ import org.hibernate.Query;
* @author Grace Carpenter
* @author Nathan Sarr
* @author kevinvandevelde at atmire.com
+ *
+ *
*/
public class ChecksumHistoryDAOImpl extends AbstractHibernateDAO implements ChecksumHistoryDAO {
@@ -42,7 +45,7 @@ public class ChecksumHistoryDAOImpl extends AbstractHibernateDAO
@Override
public ChecksumResult findByCode(Context context, ChecksumResultCode code) throws SQLException {
- Criteria criteria = createCriteria(context, ChecksumResult.class);
- criteria.add(Restrictions.eq("resultCode", code));
- return uniqueResult(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, ChecksumResult.class);
+ Root checksumResultRoot = criteriaQuery.from(ChecksumResult.class);
+ criteriaQuery.select(checksumResultRoot);
+ criteriaQuery.where(criteriaBuilder.equal(checksumResultRoot.get(ChecksumResult_.resultCode), code));
+ return uniqueResult(context, criteriaQuery, false, ChecksumResult.class, -1, -1);
}
}
diff --git a/dspace-api/src/main/java/org/dspace/checker/dao/impl/MostRecentChecksumDAOImpl.java b/dspace-api/src/main/java/org/dspace/checker/dao/impl/MostRecentChecksumDAOImpl.java
index 9ed89c40e9..66ce666b9d 100644
--- a/dspace-api/src/main/java/org/dspace/checker/dao/impl/MostRecentChecksumDAOImpl.java
+++ b/dspace-api/src/main/java/org/dspace/checker/dao/impl/MostRecentChecksumDAOImpl.java
@@ -9,22 +9,27 @@ package org.dspace.checker.dao.impl;
import java.sql.SQLException;
import java.util.Date;
+import java.util.LinkedList;
import java.util.List;
+import javax.persistence.Query;
+import javax.persistence.criteria.CriteriaBuilder;
+import javax.persistence.criteria.CriteriaQuery;
+import javax.persistence.criteria.Join;
+import javax.persistence.criteria.Order;
+import javax.persistence.criteria.Root;
+import javax.persistence.criteria.Subquery;
import org.dspace.checker.ChecksumHistory;
+import org.dspace.checker.ChecksumHistory_;
+import org.dspace.checker.ChecksumResult;
import org.dspace.checker.ChecksumResultCode;
+import org.dspace.checker.ChecksumResult_;
import org.dspace.checker.MostRecentChecksum;
+import org.dspace.checker.MostRecentChecksum_;
import org.dspace.checker.dao.MostRecentChecksumDAO;
import org.dspace.content.Bitstream;
import org.dspace.core.AbstractHibernateDAO;
import org.dspace.core.Context;
-import org.hibernate.Criteria;
-import org.hibernate.Query;
-import org.hibernate.criterion.DetachedCriteria;
-import org.hibernate.criterion.Order;
-import org.hibernate.criterion.Projections;
-import org.hibernate.criterion.Property;
-import org.hibernate.criterion.Restrictions;
/**
* Hibernate implementation of the Database Access Object interface class for the MostRecentChecksum object.
@@ -43,58 +48,58 @@ public class MostRecentChecksumDAOImpl extends AbstractHibernateDAO findByNotProcessedInDateRange(Context context, Date startDate, Date endDate)
throws SQLException {
-// + "most_recent_checksum.last_process_start_date, most_recent_checksum.last_process_end_date, "
-// + "most_recent_checksum.expected_checksum, most_recent_checksum.current_checksum, "
-// + "result_description "
-// + "from checksum_results, most_recent_checksum "
-// + "where most_recent_checksum.to_be_processed = false "
-// + "and most_recent_checksum.result = checksum_results.result_code "
-// + "and most_recent_checksum.last_process_start_date >= ? "
-// + "and most_recent_checksum.last_process_start_date < ? "
-// + "order by most_recent_checksum.bitstream_id
- Criteria criteria = createCriteria(context, MostRecentChecksum.class);
- criteria.add(
- Restrictions.and(
- Restrictions.eq("toBeProcessed", false),
- Restrictions.le("processStartDate", startDate),
- Restrictions.gt("processStartDate", endDate)
- )
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, MostRecentChecksum.class);
+ Root mostRecentChecksumRoot = criteriaQuery.from(MostRecentChecksum.class);
+ criteriaQuery.select(mostRecentChecksumRoot);
+ criteriaQuery.where(criteriaBuilder.and(
+ criteriaBuilder.equal(mostRecentChecksumRoot.get(MostRecentChecksum_.toBeProcessed), false),
+ criteriaBuilder
+ .lessThanOrEqualTo(mostRecentChecksumRoot.get(MostRecentChecksum_.processStartDate), startDate),
+ criteriaBuilder.greaterThan(mostRecentChecksumRoot.get(MostRecentChecksum_.processStartDate), endDate)
+ )
);
- criteria.addOrder(Order.asc("bitstream.id"));
- return list(criteria);
+ List orderList = new LinkedList<>();
+ orderList.add(criteriaBuilder.asc(mostRecentChecksumRoot.get(MostRecentChecksum_.bitstream)));
+ criteriaQuery.orderBy(orderList);
+ return list(context, criteriaQuery, false, MostRecentChecksum.class, -1, -1);
}
@Override
public MostRecentChecksum findByBitstream(Context context, Bitstream bitstream) throws SQLException {
- Criteria criteria = createCriteria(context, MostRecentChecksum.class);
- criteria.add(Restrictions.eq("bitstream", bitstream));
- return singleResult(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, MostRecentChecksum.class);
+ Root mostRecentChecksumRoot = criteriaQuery.from(MostRecentChecksum.class);
+ criteriaQuery.select(mostRecentChecksumRoot);
+ criteriaQuery
+ .where(criteriaBuilder.equal(mostRecentChecksumRoot.get(MostRecentChecksum_.bitstream), bitstream));
+ return singleResult(context, criteriaQuery);
}
@Override
public List findByResultTypeInDateRange(Context context, Date startDate, Date endDate,
ChecksumResultCode resultCode) throws SQLException {
-// "select bitstream_id, last_process_start_date, last_process_end_date, "
-// + "expected_checksum, current_checksum, result_description "
-// + "from most_recent_checksum, checksum_results "
-// + "where most_recent_checksum.result = checksum_results.result_code "
-// + "and most_recent_checksum.result= ? "
-// + "and most_recent_checksum.last_process_start_date >= ? "
-// + "and most_recent_checksum.last_process_start_date < ? "
-// + "order by bitstream_id";
- Criteria criteria = createCriteria(context, MostRecentChecksum.class);
- criteria.add(
- Restrictions.and(
- Restrictions.eq("checksumResult.resultCode", resultCode),
- Restrictions.le("processStartDate", startDate),
- Restrictions.gt("processStartDate", endDate)
- )
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, MostRecentChecksum.class);
+ Root mostRecentChecksumRoot = criteriaQuery.from(MostRecentChecksum.class);
+ Join mostRecentResult =
+ mostRecentChecksumRoot.join(MostRecentChecksum_.checksumResult);
+
+ criteriaQuery.select(mostRecentChecksumRoot);
+ criteriaQuery.where(criteriaBuilder.and(
+ criteriaBuilder.equal(mostRecentResult.get(ChecksumResult_.resultCode), resultCode),
+ criteriaBuilder.lessThanOrEqualTo(
+ mostRecentChecksumRoot.get(MostRecentChecksum_.processStartDate), startDate),
+ criteriaBuilder.greaterThan(mostRecentChecksumRoot.get(MostRecentChecksum_.processStartDate), endDate)
+ )
);
- criteria.addOrder(Order.asc("bitstream.id"));
- return list(criteria);
+ List orderList = new LinkedList<>();
+ orderList.add(criteriaBuilder.asc(mostRecentChecksumRoot.get(MostRecentChecksum_.bitstream)));
+ criteriaQuery.orderBy(orderList);
+ return list(context, criteriaQuery, false, MostRecentChecksum.class, -1, -1);
}
@@ -108,42 +113,52 @@ public class MostRecentChecksumDAOImpl extends AbstractHibernateDAO criteriaQuery = getCriteriaQuery(criteriaBuilder, MostRecentChecksum.class);
+ Root mostRecentChecksumRoot = criteriaQuery.from(MostRecentChecksum.class);
+ criteriaQuery.select(mostRecentChecksumRoot);
+ criteriaQuery.where(criteriaBuilder.equal(mostRecentChecksumRoot.get(MostRecentChecksum_.toBeProcessed), true));
+ List orderList = new LinkedList<>();
+ orderList.add(criteriaBuilder.asc(mostRecentChecksumRoot.get(MostRecentChecksum_.processEndDate)));
+ orderList.add(criteriaBuilder.asc(mostRecentChecksumRoot.get(MostRecentChecksum_.bitstream)));
+ criteriaQuery.orderBy(orderList);
+ return singleResult(context, criteriaQuery);
}
@Override
public MostRecentChecksum getOldestRecord(Context context, Date lessThanDate) throws SQLException {
-// "select bitstream_id "
-// + "from most_recent_checksum "
-// + "where to_be_processed = true "
-// + "and last_process_start_date < ? "
-// + "order by date_trunc('milliseconds', last_process_end_date), "
-// + "bitstream_id " + "ASC LIMIT 1";
- Criteria criteria = createCriteria(context, MostRecentChecksum.class);
- criteria.add(
- Restrictions.and(
- Restrictions.eq("toBeProcessed", true),
- Restrictions.lt("processStartDate", lessThanDate)
- ));
- criteria.addOrder(Order.asc("processEndDate")).addOrder(Order.asc("bitstream.id"));
- criteria.setMaxResults(1);
- return singleResult(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, MostRecentChecksum.class);
+ Root mostRecentChecksumRoot = criteriaQuery.from(MostRecentChecksum.class);
+ criteriaQuery.select(mostRecentChecksumRoot);
+ criteriaQuery.where(criteriaBuilder.and(
+ criteriaBuilder.equal(mostRecentChecksumRoot.get(MostRecentChecksum_.toBeProcessed), true),
+ criteriaBuilder.lessThan(mostRecentChecksumRoot.get(MostRecentChecksum_.processStartDate), lessThanDate)
+ )
+ );
+
+ List orderList = new LinkedList<>();
+ orderList.add(criteriaBuilder.asc(mostRecentChecksumRoot.get(MostRecentChecksum_.processEndDate)));
+ orderList.add(criteriaBuilder.asc(mostRecentChecksumRoot.get(MostRecentChecksum_.bitstream)));
+ criteriaQuery.orderBy(orderList);
+
+ return singleResult(context, criteriaQuery);
}
@Override
public List findNotInHistory(Context context) throws SQLException {
- Criteria criteria = createCriteria(context, MostRecentChecksum.class);
- DetachedCriteria subCriteria = DetachedCriteria.forClass(ChecksumHistory.class);
- subCriteria.setProjection(Projections.property("bitstream.id"));
- criteria.add(Property.forName("bitstreamId").notIn(subCriteria));
- return list(criteria);
+
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, MostRecentChecksum.class);
+ Root checksumRoot = criteriaQuery.from(MostRecentChecksum.class);
+
+ Subquery subQuery = criteriaQuery.subquery(Bitstream.class);
+ Root historyRoot = subQuery.from(ChecksumHistory.class);
+ subQuery.select(historyRoot.get(ChecksumHistory_.bitstream));
+
+ criteriaQuery.where(
+ criteriaBuilder.not(checksumRoot.get(MostRecentChecksum_.bitstream).in(subQuery)));
+
+ return list(context, criteriaQuery, false, MostRecentChecksum.class, -1, -1);
}
}
diff --git a/dspace-api/src/main/java/org/dspace/content/BitstreamFormatServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/BitstreamFormatServiceImpl.java
index 978b3070fc..7239424d91 100644
--- a/dspace-api/src/main/java/org/dspace/content/BitstreamFormatServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/BitstreamFormatServiceImpl.java
@@ -12,7 +12,7 @@ import java.util.Collections;
import java.util.List;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.authorize.service.AuthorizeService;
import org.dspace.content.dao.BitstreamFormatDAO;
@@ -33,7 +33,7 @@ public class BitstreamFormatServiceImpl implements BitstreamFormatService {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(BitstreamFormat.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(BitstreamFormat.class);
@Autowired(required = true)
protected BitstreamFormatDAO bitstreamFormatDAO;
diff --git a/dspace-api/src/main/java/org/dspace/content/BitstreamServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/BitstreamServiceImpl.java
index dee0caf44f..34e4b88dc3 100644
--- a/dspace-api/src/main/java/org/dspace/content/BitstreamServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/BitstreamServiceImpl.java
@@ -15,8 +15,8 @@ import java.util.List;
import java.util.UUID;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.authorize.service.AuthorizeService;
import org.dspace.content.dao.BitstreamDAO;
@@ -43,7 +43,7 @@ public class BitstreamServiceImpl extends DSpaceObjectServiceImpl imp
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(BitstreamServiceImpl.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(BitstreamServiceImpl.class);
@Autowired(required = true)
@@ -103,6 +103,8 @@ public class BitstreamServiceImpl extends DSpaceObjectServiceImpl imp
clonedBitstream.setSizeBytes(bitstream.getSizeBytes());
clonedBitstream.setChecksum(bitstream.getChecksum());
clonedBitstream.setChecksumAlgorithm(bitstream.getChecksumAlgorithm());
+ clonedBitstream.setFormat(bitstream.getBitstreamFormat());
+
try {
//Update our bitstream but turn off the authorization system since permissions
//haven't been set at this point in time.
diff --git a/dspace-api/src/main/java/org/dspace/content/BundleServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/BundleServiceImpl.java
index d8ee51fadf..1e4f4daa07 100644
--- a/dspace-api/src/main/java/org/dspace/content/BundleServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/BundleServiceImpl.java
@@ -16,8 +16,8 @@ import java.util.List;
import java.util.UUID;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeConfiguration;
import org.dspace.authorize.AuthorizeException;
import org.dspace.authorize.ResourcePolicy;
@@ -45,7 +45,7 @@ public class BundleServiceImpl extends DSpaceObjectServiceImpl implement
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(Bundle.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(Bundle.class);
@Autowired(required = true)
protected BundleDAO bundleDAO;
diff --git a/dspace-api/src/main/java/org/dspace/content/CollectionServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/CollectionServiceImpl.java
index bd7034856f..d76c4798f1 100644
--- a/dspace-api/src/main/java/org/dspace/content/CollectionServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/CollectionServiceImpl.java
@@ -20,8 +20,8 @@ import java.util.MissingResourceException;
import java.util.UUID;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.app.util.AuthorizeUtil;
import org.dspace.authorize.AuthorizeConfiguration;
import org.dspace.authorize.AuthorizeException;
@@ -61,7 +61,7 @@ public class CollectionServiceImpl extends DSpaceObjectServiceImpl i
/**
* log4j category
*/
- private static final Logger log = Logger.getLogger(CollectionServiceImpl.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(CollectionServiceImpl.class);
@Autowired(required = true)
protected CollectionDAO collectionDAO;
diff --git a/dspace-api/src/main/java/org/dspace/content/Community.java b/dspace-api/src/main/java/org/dspace/content/Community.java
index 4b22addd39..3c26f229b9 100644
--- a/dspace-api/src/main/java/org/dspace/content/Community.java
+++ b/dspace-api/src/main/java/org/dspace/content/Community.java
@@ -25,8 +25,8 @@ import javax.persistence.OneToOne;
import javax.persistence.Table;
import javax.persistence.Transient;
-import org.apache.commons.lang.builder.HashCodeBuilder;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.logging.log4j.Logger;
import org.dspace.browse.BrowsableDSpaceObject;
import org.dspace.content.comparator.NameAscendingComparator;
import org.dspace.content.factory.ContentServiceFactory;
@@ -55,7 +55,7 @@ public class Community extends DSpaceObject implements DSpaceObjectLegacySupport
/**
* log4j category
*/
- private static final Logger log = Logger.getLogger(Community.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(Community.class);
@Column(name = "community_id", insertable = false, updatable = false)
private Integer legacyId;
@@ -110,7 +110,7 @@ public class Community extends DSpaceObject implements DSpaceObjectLegacySupport
setModified();
}
- void removeSubCommunity(Community subCommunity) {
+ public void removeSubCommunity(Community subCommunity) {
subCommunities.remove(subCommunity);
setModified();
}
diff --git a/dspace-api/src/main/java/org/dspace/content/CommunityServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/CommunityServiceImpl.java
index 667b0268b1..ac939434a5 100644
--- a/dspace-api/src/main/java/org/dspace/content/CommunityServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/CommunityServiceImpl.java
@@ -17,8 +17,8 @@ import java.util.MissingResourceException;
import java.util.UUID;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.app.util.AuthorizeUtil;
import org.dspace.authorize.AuthorizeConfiguration;
import org.dspace.authorize.AuthorizeException;
@@ -51,7 +51,7 @@ public class CommunityServiceImpl extends DSpaceObjectServiceImpl imp
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(CommunityServiceImpl.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(CommunityServiceImpl.class);
@Autowired(required = true)
protected CommunityDAO communityDAO;
diff --git a/dspace-api/src/main/java/org/dspace/content/DCDate.java b/dspace-api/src/main/java/org/dspace/content/DCDate.java
index 729b1d3753..4acccb2d84 100644
--- a/dspace-api/src/main/java/org/dspace/content/DCDate.java
+++ b/dspace-api/src/main/java/org/dspace/content/DCDate.java
@@ -18,7 +18,7 @@ import java.util.Locale;
import java.util.Map;
import java.util.TimeZone;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
// FIXME: Not very robust - assumes dates will always be valid
@@ -45,7 +45,7 @@ public class DCDate {
/**
* Logger
*/
- private static Logger log = Logger.getLogger(DCDate.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(DCDate.class);
// UTC timezone
private static final TimeZone utcZone = TimeZone.getTimeZone("UTC");
diff --git a/dspace-api/src/main/java/org/dspace/content/DSpaceObjectServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/DSpaceObjectServiceImpl.java
index 165a120bb2..2756ca958b 100644
--- a/dspace-api/src/main/java/org/dspace/content/DSpaceObjectServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/DSpaceObjectServiceImpl.java
@@ -17,9 +17,9 @@ import java.util.Map;
import java.util.StringTokenizer;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang.ArrayUtils;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.authority.Choices;
import org.dspace.content.authority.service.ChoiceAuthorityService;
@@ -48,7 +48,7 @@ public abstract class DSpaceObjectServiceImpl implements
/**
* log4j category
*/
- private static final Logger log = Logger.getLogger(DSpaceObjectServiceImpl.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(DSpaceObjectServiceImpl.class);
@Autowired(required = true)
protected ChoiceAuthorityService choiceAuthorityService;
diff --git a/dspace-api/src/main/java/org/dspace/content/ItemComparator.java b/dspace-api/src/main/java/org/dspace/content/ItemComparator.java
index 27e869d40b..2daa61cf57 100644
--- a/dspace-api/src/main/java/org/dspace/content/ItemComparator.java
+++ b/dspace-api/src/main/java/org/dspace/content/ItemComparator.java
@@ -15,7 +15,7 @@ import java.util.List;
import java.util.Map;
import java.util.Set;
-import org.apache.commons.lang.builder.HashCodeBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.ItemService;
import org.dspace.sort.OrderFormat;
diff --git a/dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java
index 44c8079f5b..f4809f5ea1 100644
--- a/dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java
@@ -17,8 +17,8 @@ import java.util.List;
import java.util.UUID;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.app.util.AuthorizeUtil;
import org.dspace.authorize.AuthorizeConfiguration;
import org.dspace.authorize.AuthorizeException;
@@ -65,7 +65,7 @@ public class ItemServiceImpl extends DSpaceObjectServiceImpl- implements It
/**
* log4j category
*/
- private static final Logger log = Logger.getLogger(Item.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(Item.class);
@Autowired(required = true)
protected ItemDAO itemDAO;
@@ -216,12 +216,6 @@ public class ItemServiceImpl extends DSpaceObjectServiceImpl
- implements It
return itemDAO.findBySubmitter(context, eperson);
}
- @Override
- public List
- findBySubmitter(Context context, EPerson eperson, Integer limit, Integer offset)
- throws SQLException {
- return itemDAO.findBySubmitter(context, eperson, limit, offset);
- }
-
@Override
public Iterator
- findBySubmitterDateSorted(Context context, EPerson eperson, Integer limit)
throws SQLException {
@@ -308,11 +302,6 @@ public class ItemServiceImpl extends DSpaceObjectServiceImpl
- implements It
return matchingBundles;
}
- @Override
- public List getBundles(Context context, Item item, String name) throws SQLException {
- return itemDAO.findBundlesByName(context, item, name);
- }
-
@Override
public void addBundle(Context context, Item item, Bundle bundle) throws SQLException, AuthorizeException {
// Check authorisation
diff --git a/dspace-api/src/main/java/org/dspace/content/MetadataFieldServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/MetadataFieldServiceImpl.java
index c48ff015e4..e3ed9c8ae7 100644
--- a/dspace-api/src/main/java/org/dspace/content/MetadataFieldServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/MetadataFieldServiceImpl.java
@@ -12,7 +12,7 @@ import java.sql.SQLException;
import java.util.List;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.authorize.service.AuthorizeService;
import org.dspace.content.dao.MetadataFieldDAO;
@@ -33,7 +33,7 @@ public class MetadataFieldServiceImpl implements MetadataFieldService {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(MetadataFieldServiceImpl.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(MetadataFieldServiceImpl.class);
@Autowired(required = true)
protected MetadataFieldDAO metadataFieldDAO;
diff --git a/dspace-api/src/main/java/org/dspace/content/MetadataSchemaServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/MetadataSchemaServiceImpl.java
index f2b13fb8ea..185addfb01 100644
--- a/dspace-api/src/main/java/org/dspace/content/MetadataSchemaServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/MetadataSchemaServiceImpl.java
@@ -10,7 +10,7 @@ package org.dspace.content;
import java.sql.SQLException;
import java.util.List;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.authorize.service.AuthorizeService;
import org.dspace.content.dao.MetadataSchemaDAO;
@@ -31,7 +31,7 @@ public class MetadataSchemaServiceImpl implements MetadataSchemaService {
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(MetadataSchemaServiceImpl.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(MetadataSchemaServiceImpl.class);
@Autowired(required = true)
protected AuthorizeService authorizeService;
diff --git a/dspace-api/src/main/java/org/dspace/content/MetadataValueServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/MetadataValueServiceImpl.java
index 396265467b..e7b00ab85c 100644
--- a/dspace-api/src/main/java/org/dspace/content/MetadataValueServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/MetadataValueServiceImpl.java
@@ -12,7 +12,7 @@ import java.sql.SQLException;
import java.util.Iterator;
import java.util.List;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.authorize.service.AuthorizeService;
import org.dspace.content.dao.MetadataValueDAO;
@@ -33,7 +33,7 @@ import org.springframework.beans.factory.annotation.Autowired;
*/
public class MetadataValueServiceImpl implements MetadataValueService {
- private static final Logger log = Logger.getLogger(MetadataValueServiceImpl.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(MetadataValueServiceImpl.class);
@Autowired(required = true)
protected AuthorizeService authorizeService;
diff --git a/dspace-api/src/main/java/org/dspace/content/WorkspaceItem.java b/dspace-api/src/main/java/org/dspace/content/WorkspaceItem.java
index ce531be932..2ed10e5887 100644
--- a/dspace-api/src/main/java/org/dspace/content/WorkspaceItem.java
+++ b/dspace-api/src/main/java/org/dspace/content/WorkspaceItem.java
@@ -26,7 +26,7 @@ import javax.persistence.OneToOne;
import javax.persistence.SequenceGenerator;
import javax.persistence.Table;
-import org.apache.commons.lang.builder.HashCodeBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
import org.dspace.authorize.AuthorizeException;
import org.dspace.browse.BrowsableDSpaceObject;
import org.dspace.content.factory.ContentServiceFactory;
diff --git a/dspace-api/src/main/java/org/dspace/content/WorkspaceItemServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/WorkspaceItemServiceImpl.java
index fbe6bb0f2b..57a3c00695 100644
--- a/dspace-api/src/main/java/org/dspace/content/WorkspaceItemServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/WorkspaceItemServiceImpl.java
@@ -13,7 +13,7 @@ import java.util.ArrayList;
import java.util.List;
import java.util.Map;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.app.util.DCInputsReaderException;
import org.dspace.app.util.Util;
import org.dspace.authorize.AuthorizeException;
@@ -40,7 +40,7 @@ import org.springframework.beans.factory.annotation.Autowired;
*/
public class WorkspaceItemServiceImpl implements WorkspaceItemService {
- private static final Logger log = Logger.getLogger(WorkspaceItemServiceImpl.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(WorkspaceItemServiceImpl.class);
@Autowired(required = true)
protected WorkspaceItemDAO workspaceItemDAO;
diff --git a/dspace-api/src/main/java/org/dspace/content/authority/ChoiceAuthorityServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/authority/ChoiceAuthorityServiceImpl.java
index e90e93e864..c6fe528fdb 100644
--- a/dspace-api/src/main/java/org/dspace/content/authority/ChoiceAuthorityServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/authority/ChoiceAuthorityServiceImpl.java
@@ -14,7 +14,7 @@ import java.util.Map;
import java.util.Set;
import org.apache.commons.lang3.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.app.util.DCInput;
import org.dspace.app.util.DCInputSet;
import org.dspace.app.util.DCInputsReader;
@@ -49,7 +49,7 @@ import org.springframework.beans.factory.annotation.Autowired;
* @see ChoiceAuthority
*/
public final class ChoiceAuthorityServiceImpl implements ChoiceAuthorityService {
- private Logger log = Logger.getLogger(ChoiceAuthorityServiceImpl.class);
+ private Logger log = org.apache.logging.log4j.LogManager.getLogger(ChoiceAuthorityServiceImpl.class);
// map of field key to authority plugin
protected Map controller = new HashMap();
@@ -264,39 +264,42 @@ public final class ChoiceAuthorityServiceImpl implements ChoiceAuthorityService
try {
DCInputsReader dcInputsReader = new DCInputsReader();
for (DCInputSet dcinputSet : dcInputsReader.getAllInputs(Integer.MAX_VALUE, 0)) {
- DCInput[] dcinputs = dcinputSet.getFields();
- for (DCInput dcinput : dcinputs) {
- if (StringUtils.isNotBlank(dcinput.getPairsType())
- || StringUtils.isNotBlank(dcinput.getVocabulary())) {
- String authorityName = dcinput.getPairsType();
- if (StringUtils.isBlank(authorityName)) {
- authorityName = dcinput.getVocabulary();
- }
- if (!StringUtils.equals(dcinput.getInputType(), "qualdrop_value")) {
- String fieldKey = makeFieldKey(dcinput.getSchema(), dcinput.getElement(),
- dcinput.getQualifier());
- ChoiceAuthority ca = controller.get(authorityName);
- if (ca == null) {
- InputFormSelfRegisterWrapperAuthority ifa = new InputFormSelfRegisterWrapperAuthority();
- if (controller.containsKey(fieldKey)) {
- ifa = (InputFormSelfRegisterWrapperAuthority) controller.get(fieldKey);
+ DCInput[][] dcinputs = dcinputSet.getFields();
+ for (DCInput[] dcrows : dcinputs) {
+ for (DCInput dcinput : dcrows) {
+ if (StringUtils.isNotBlank(dcinput.getPairsType())
+ || StringUtils.isNotBlank(dcinput.getVocabulary())) {
+ String authorityName = dcinput.getPairsType();
+ if (StringUtils.isBlank(authorityName)) {
+ authorityName = dcinput.getVocabulary();
+ }
+ if (!StringUtils.equals(dcinput.getInputType(), "qualdrop_value")) {
+ String fieldKey = makeFieldKey(dcinput.getSchema(), dcinput.getElement(),
+ dcinput.getQualifier());
+ ChoiceAuthority ca = controller.get(authorityName);
+ if (ca == null) {
+ InputFormSelfRegisterWrapperAuthority ifa = new
+ InputFormSelfRegisterWrapperAuthority();
+ if (controller.containsKey(fieldKey)) {
+ ifa = (InputFormSelfRegisterWrapperAuthority) controller.get(fieldKey);
+ }
+
+ ChoiceAuthority ma = (ChoiceAuthority) pluginService
+ .getNamedPlugin(ChoiceAuthority.class, authorityName);
+ if (ma == null) {
+ log.warn("Skipping invalid configuration for " + fieldKey
+ + " because named plugin not found: " + authorityName);
+ continue;
+ }
+ ifa.getDelegates().put(dcinputSet.getFormName(), ma);
+ controller.put(fieldKey, ifa);
}
- ChoiceAuthority ma = (ChoiceAuthority) pluginService
- .getNamedPlugin(ChoiceAuthority.class, authorityName);
- if (ma == null) {
- log.warn("Skipping invalid configuration for " + fieldKey
- + " because named plugin not found: " + authorityName);
- continue;
+ if (!authorities.containsKey(authorityName)) {
+ authorities.put(authorityName, fieldKey);
}
- ifa.getDelegates().put(dcinputSet.getFormName(), ma);
- controller.put(fieldKey, ifa);
- }
- if (!authorities.containsKey(authorityName)) {
- authorities.put(authorityName, fieldKey);
}
-
}
}
}
diff --git a/dspace-api/src/main/java/org/dspace/content/authority/Choices.java b/dspace-api/src/main/java/org/dspace/content/authority/Choices.java
index ab5fa162cd..534e3083da 100644
--- a/dspace-api/src/main/java/org/dspace/content/authority/Choices.java
+++ b/dspace-api/src/main/java/org/dspace/content/authority/Choices.java
@@ -7,7 +7,7 @@
*/
package org.dspace.content.authority;
-import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang3.ArrayUtils;
/**
* Record class to hold a set of Choices returned by an authority in response
diff --git a/dspace-api/src/main/java/org/dspace/content/authority/DCInputAuthority.java b/dspace-api/src/main/java/org/dspace/content/authority/DCInputAuthority.java
index bf01f37f02..a64ebdd971 100644
--- a/dspace-api/src/main/java/org/dspace/content/authority/DCInputAuthority.java
+++ b/dspace-api/src/main/java/org/dspace/content/authority/DCInputAuthority.java
@@ -12,8 +12,8 @@ import java.util.Arrays;
import java.util.Iterator;
import java.util.List;
-import org.apache.commons.lang.ArrayUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.app.util.DCInputsReader;
import org.dspace.app.util.DCInputsReaderException;
import org.dspace.content.Collection;
@@ -42,7 +42,7 @@ import org.dspace.core.SelfNamedPlugin;
* fields.
*/
public class DCInputAuthority extends SelfNamedPlugin implements ChoiceAuthority {
- private static Logger log = Logger.getLogger(DCInputAuthority.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(DCInputAuthority.class);
private String values[] = null;
private String labels[] = null;
diff --git a/dspace-api/src/main/java/org/dspace/content/authority/DSpaceControlledVocabulary.java b/dspace-api/src/main/java/org/dspace/content/authority/DSpaceControlledVocabulary.java
index 70159c89dd..516b9a06ae 100644
--- a/dspace-api/src/main/java/org/dspace/content/authority/DSpaceControlledVocabulary.java
+++ b/dspace-api/src/main/java/org/dspace/content/authority/DSpaceControlledVocabulary.java
@@ -16,9 +16,9 @@ import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathExpressionException;
import javax.xml.xpath.XPathFactory;
-import org.apache.commons.lang.ArrayUtils;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.content.Collection;
import org.dspace.core.SelfNamedPlugin;
import org.dspace.services.ConfigurationService;
@@ -56,7 +56,7 @@ import org.xml.sax.InputSource;
public class DSpaceControlledVocabulary extends SelfNamedPlugin implements ChoiceAuthority {
- private static Logger log = Logger.getLogger(DSpaceControlledVocabulary.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(DSpaceControlledVocabulary.class);
protected static String xpathTemplate = "//node[contains(translate(@label,'ABCDEFGHIJKLMNOPQRSTUVWXYZ'," +
"'abcdefghijklmnopqrstuvwxyz'),'%s')]";
protected static String idTemplate = "//node[@id = '%s']";
diff --git a/dspace-api/src/main/java/org/dspace/content/authority/InputFormSelfRegisterWrapperAuthority.java b/dspace-api/src/main/java/org/dspace/content/authority/InputFormSelfRegisterWrapperAuthority.java
index acfe4292f6..60c3403728 100644
--- a/dspace-api/src/main/java/org/dspace/content/authority/InputFormSelfRegisterWrapperAuthority.java
+++ b/dspace-api/src/main/java/org/dspace/content/authority/InputFormSelfRegisterWrapperAuthority.java
@@ -13,8 +13,8 @@ import java.util.HashSet;
import java.util.Map;
import java.util.Set;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.app.util.DCInputsReader;
import org.dspace.app.util.DCInputsReaderException;
import org.dspace.content.Collection;
@@ -32,7 +32,8 @@ import org.dspace.content.Collection;
*/
public class InputFormSelfRegisterWrapperAuthority implements ChoiceAuthority {
- private static Logger log = Logger.getLogger(InputFormSelfRegisterWrapperAuthority.class);
+ private static Logger log =
+ org.apache.logging.log4j.LogManager.getLogger(InputFormSelfRegisterWrapperAuthority.class);
private Map delegates = new HashMap();
diff --git a/dspace-api/src/main/java/org/dspace/content/authority/LCNameAuthority.java b/dspace-api/src/main/java/org/dspace/content/authority/LCNameAuthority.java
index 77da8400ea..66bb7f1832 100644
--- a/dspace-api/src/main/java/org/dspace/content/authority/LCNameAuthority.java
+++ b/dspace-api/src/main/java/org/dspace/content/authority/LCNameAuthority.java
@@ -22,7 +22,7 @@ import org.apache.http.client.HttpClient;
import org.apache.http.client.methods.HttpGet;
import org.apache.http.client.utils.URIBuilder;
import org.apache.http.impl.client.DefaultHttpClient;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.content.Collection;
import org.dspace.content.DCPersonName;
import org.dspace.core.ConfigurationManager;
@@ -57,7 +57,7 @@ import org.xml.sax.helpers.DefaultHandler;
* @version $Revision $
*/
public class LCNameAuthority implements ChoiceAuthority {
- private static final Logger log = Logger.getLogger(LCNameAuthority.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(LCNameAuthority.class);
// get these from configuration
protected static String url = null;
diff --git a/dspace-api/src/main/java/org/dspace/content/authority/MetadataAuthorityServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/authority/MetadataAuthorityServiceImpl.java
index 5ad3e91a16..6a5b17a029 100644
--- a/dspace-api/src/main/java/org/dspace/content/authority/MetadataAuthorityServiceImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/authority/MetadataAuthorityServiceImpl.java
@@ -15,7 +15,7 @@ import java.util.List;
import java.util.Map;
import org.apache.commons.lang3.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.app.util.DCInput;
import org.dspace.app.util.DCInputSet;
import org.dspace.app.util.DCInputsReader;
@@ -57,7 +57,7 @@ import org.springframework.beans.factory.annotation.Autowired;
* @see Choices
*/
public class MetadataAuthorityServiceImpl implements MetadataAuthorityService {
- private static Logger log = Logger.getLogger(MetadataAuthorityServiceImpl.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(MetadataAuthorityServiceImpl.class);
@Autowired(required = true)
protected MetadataFieldService metadataFieldService;
@@ -235,21 +235,23 @@ public class MetadataAuthorityServiceImpl implements MetadataAuthorityService {
try {
DCInputsReader dcInputsReader = new DCInputsReader();
for (DCInputSet dcinputSet : dcInputsReader.getAllInputs(Integer.MAX_VALUE, 0)) {
- DCInput[] dcinputs = dcinputSet.getFields();
- for (DCInput dcinput : dcinputs) {
- if (StringUtils.isNotBlank(dcinput.getPairsType())
- || StringUtils.isNotBlank(dcinput.getVocabulary())) {
- String authorityName = dcinput.getPairsType();
- if (StringUtils.isBlank(authorityName)) {
- authorityName = dcinput.getVocabulary();
- }
- if (!StringUtils.equals(dcinput.getInputType(), "qualdrop_value")) {
- String fieldKey = makeFieldKey(dcinput.getSchema(), dcinput.getElement(),
- dcinput.getQualifier());
- boolean req = ConfigurationManager
- .getBooleanProperty("authority.required." + fieldKey, false);
- controlled.put(fieldKey, true);
- isAuthorityRequired.put(fieldKey, req);
+ DCInput[][] dcinputs = dcinputSet.getFields();
+ for (DCInput[] dcrows : dcinputs) {
+ for (DCInput dcinput : dcrows) {
+ if (StringUtils.isNotBlank(dcinput.getPairsType())
+ || StringUtils.isNotBlank(dcinput.getVocabulary())) {
+ String authorityName = dcinput.getPairsType();
+ if (StringUtils.isBlank(authorityName)) {
+ authorityName = dcinput.getVocabulary();
+ }
+ if (!StringUtils.equals(dcinput.getInputType(), "qualdrop_value")) {
+ String fieldKey = makeFieldKey(dcinput.getSchema(), dcinput.getElement(),
+ dcinput.getQualifier());
+ boolean req = ConfigurationManager
+ .getBooleanProperty("authority.required." + fieldKey, false);
+ controlled.put(fieldKey, true);
+ isAuthorityRequired.put(fieldKey, req);
+ }
}
}
}
diff --git a/dspace-api/src/main/java/org/dspace/content/authority/SHERPARoMEOProtocol.java b/dspace-api/src/main/java/org/dspace/content/authority/SHERPARoMEOProtocol.java
index 5bc94bf06a..5f0af29760 100644
--- a/dspace-api/src/main/java/org/dspace/content/authority/SHERPARoMEOProtocol.java
+++ b/dspace-api/src/main/java/org/dspace/content/authority/SHERPARoMEOProtocol.java
@@ -19,7 +19,7 @@ import org.apache.http.client.methods.HttpGet;
import org.apache.http.client.utils.URLEncodedUtils;
import org.apache.http.impl.client.DefaultHttpClient;
import org.apache.http.message.BasicNameValuePair;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.content.Collection;
import org.dspace.core.ConfigurationManager;
import org.xml.sax.Attributes;
@@ -50,7 +50,7 @@ import org.xml.sax.helpers.DefaultHandler;
* @see SHERPARoMEOJournalTitle
*/
public abstract class SHERPARoMEOProtocol implements ChoiceAuthority {
- private static final Logger log = Logger.getLogger(SHERPARoMEOProtocol.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(SHERPARoMEOProtocol.class);
// contact URL from configuration
private static String url = null;
diff --git a/dspace-api/src/main/java/org/dspace/content/authority/SolrAuthority.java b/dspace-api/src/main/java/org/dspace/content/authority/SolrAuthority.java
index e6dbe45cc0..159f2901d0 100644
--- a/dspace-api/src/main/java/org/dspace/content/authority/SolrAuthority.java
+++ b/dspace-api/src/main/java/org/dspace/content/authority/SolrAuthority.java
@@ -12,8 +12,8 @@ import java.util.Iterator;
import java.util.List;
import java.util.Map;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.apache.solr.client.solrj.SolrQuery;
import org.apache.solr.client.solrj.response.QueryResponse;
import org.apache.solr.common.SolrDocument;
@@ -36,10 +36,12 @@ import org.dspace.services.factory.DSpaceServicesFactory;
*/
public class SolrAuthority implements ChoiceAuthority {
- private static final Logger log = Logger.getLogger(SolrAuthority.class);
protected SolrAuthorityInterface source =
DSpaceServicesFactory.getInstance().getServiceManager()
.getServiceByName("AuthoritySource", SolrAuthorityInterface.class);
+
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(SolrAuthority.class);
+
protected boolean externalResults = false;
protected final AuthorityValueService authorityValueService = AuthorityServiceFactory.getInstance()
.getAuthorityValueService();
diff --git a/dspace-api/src/main/java/org/dspace/content/authority/TestAuthority.java b/dspace-api/src/main/java/org/dspace/content/authority/TestAuthority.java
index 8c3c94e5f1..a017e8fe28 100644
--- a/dspace-api/src/main/java/org/dspace/content/authority/TestAuthority.java
+++ b/dspace-api/src/main/java/org/dspace/content/authority/TestAuthority.java
@@ -10,7 +10,7 @@ package org.dspace.content.authority;
import java.util.ArrayList;
import java.util.List;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
import org.dspace.content.Collection;
/**
diff --git a/dspace-api/src/main/java/org/dspace/content/comparator/NameAscendingComparator.java b/dspace-api/src/main/java/org/dspace/content/comparator/NameAscendingComparator.java
index 980554228b..3240824169 100644
--- a/dspace-api/src/main/java/org/dspace/content/comparator/NameAscendingComparator.java
+++ b/dspace-api/src/main/java/org/dspace/content/comparator/NameAscendingComparator.java
@@ -9,8 +9,8 @@ package org.dspace.content.comparator;
import java.util.Comparator;
-import org.apache.commons.lang.ObjectUtils;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.ObjectUtils;
+import org.apache.commons.lang3.StringUtils;
import org.dspace.content.DSpaceObject;
public class NameAscendingComparator implements Comparator {
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/AIPTechMDCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/AIPTechMDCrosswalk.java
index 3f109d9a1e..d7ee2630e9 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/AIPTechMDCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/AIPTechMDCrosswalk.java
@@ -13,7 +13,7 @@ import java.util.ArrayList;
import java.util.List;
import org.apache.commons.collections4.CollectionUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Bitstream;
import org.dspace.content.BitstreamFormat;
@@ -72,7 +72,7 @@ public class AIPTechMDCrosswalk implements IngestionCrosswalk, DisseminationCros
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(AIPTechMDCrosswalk.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(AIPTechMDCrosswalk.class);
protected final BitstreamFormatService bitstreamFormatService = ContentServiceFactory.getInstance()
.getBitstreamFormatService();
protected final SiteService siteService = ContentServiceFactory.getInstance().getSiteService();
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsRDFStreamDisseminationCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsRDFStreamDisseminationCrosswalk.java
index d530f55905..9042a3a7f5 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsRDFStreamDisseminationCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsRDFStreamDisseminationCrosswalk.java
@@ -11,7 +11,7 @@ import java.io.IOException;
import java.io.OutputStream;
import java.sql.SQLException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Bitstream;
import org.dspace.content.DSpaceObject;
@@ -35,7 +35,8 @@ public class CreativeCommonsRDFStreamDisseminationCrosswalk
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(CreativeCommonsRDFStreamDisseminationCrosswalk.class);
+ private static Logger log =
+ org.apache.logging.log4j.LogManager.getLogger(CreativeCommonsRDFStreamDisseminationCrosswalk.class);
protected BitstreamService bitstreamService = ContentServiceFactory.getInstance().getBitstreamService();
protected CreativeCommonsService creativeCommonsService = LicenseServiceFactory.getInstance()
.getCreativeCommonsService();
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsRDFStreamIngestionCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsRDFStreamIngestionCrosswalk.java
index d011202921..a5d503b6c2 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsRDFStreamIngestionCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsRDFStreamIngestionCrosswalk.java
@@ -11,7 +11,7 @@ import java.io.IOException;
import java.io.InputStream;
import java.sql.SQLException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.DSpaceObject;
import org.dspace.content.Item;
@@ -38,7 +38,8 @@ public class CreativeCommonsRDFStreamIngestionCrosswalk
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(CreativeCommonsRDFStreamIngestionCrosswalk.class);
+ private static Logger log =
+ org.apache.logging.log4j.LogManager.getLogger(CreativeCommonsRDFStreamIngestionCrosswalk.class);
protected CreativeCommonsService creativeCommonsService = LicenseServiceFactory.getInstance()
.getCreativeCommonsService();
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsTextStreamDisseminationCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsTextStreamDisseminationCrosswalk.java
index bf6d97fbea..6d7becba42 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsTextStreamDisseminationCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/CreativeCommonsTextStreamDisseminationCrosswalk.java
@@ -11,7 +11,7 @@ import java.io.IOException;
import java.io.OutputStream;
import java.sql.SQLException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Bitstream;
import org.dspace.content.DSpaceObject;
@@ -42,7 +42,8 @@ public class CreativeCommonsTextStreamDisseminationCrosswalk
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(CreativeCommonsTextStreamDisseminationCrosswalk.class);
+ private static Logger log =
+ org.apache.logging.log4j.LogManager.getLogger(CreativeCommonsTextStreamDisseminationCrosswalk.class);
@Override
public boolean canDisseminate(Context context, DSpaceObject dso) {
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/DIMDisseminationCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/DIMDisseminationCrosswalk.java
index 05560f0b32..3f4d6bd44e 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/DIMDisseminationCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/DIMDisseminationCrosswalk.java
@@ -12,7 +12,7 @@ import java.sql.SQLException;
import java.util.ArrayList;
import java.util.List;
-import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang3.ArrayUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.DSpaceObject;
import org.dspace.content.Item;
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/LicenseStreamDisseminationCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/LicenseStreamDisseminationCrosswalk.java
index da10a212ec..75b884613d 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/LicenseStreamDisseminationCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/LicenseStreamDisseminationCrosswalk.java
@@ -11,7 +11,7 @@ import java.io.IOException;
import java.io.OutputStream;
import java.sql.SQLException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Bitstream;
import org.dspace.content.DSpaceObject;
@@ -34,7 +34,8 @@ public class LicenseStreamDisseminationCrosswalk
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(LicenseStreamDisseminationCrosswalk.class);
+ private static Logger log =
+ org.apache.logging.log4j.LogManager.getLogger(LicenseStreamDisseminationCrosswalk.class);
protected BitstreamService bitstreamService = ContentServiceFactory.getInstance().getBitstreamService();
@Override
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/LicenseStreamIngestionCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/LicenseStreamIngestionCrosswalk.java
index fb3653b4db..a7dcae944c 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/LicenseStreamIngestionCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/LicenseStreamIngestionCrosswalk.java
@@ -12,7 +12,7 @@ import java.io.IOException;
import java.io.InputStream;
import java.sql.SQLException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.DSpaceObject;
import org.dspace.content.Item;
@@ -39,7 +39,7 @@ public class LicenseStreamIngestionCrosswalk
/**
* log4j logger
*/
- private static Logger log = Logger.getLogger(LicenseStreamIngestionCrosswalk.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(LicenseStreamIngestionCrosswalk.class);
@Override
public void ingest(Context context, DSpaceObject dso, InputStream in, String MIMEType)
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/METSDisseminationCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/METSDisseminationCrosswalk.java
index efe24b63d5..c3b20bccb1 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/METSDisseminationCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/METSDisseminationCrosswalk.java
@@ -13,7 +13,7 @@ import java.sql.SQLException;
import java.util.ArrayList;
import java.util.List;
-import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang3.ArrayUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.DSpaceObject;
import org.dspace.content.packager.PackageDisseminator;
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/METSRightsCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/METSRightsCrosswalk.java
index 4b76afd90b..559d463be2 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/METSRightsCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/METSRightsCrosswalk.java
@@ -17,9 +17,9 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
-import org.apache.commons.lang.ArrayUtils;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.authorize.ResourcePolicy;
import org.dspace.authorize.factory.AuthorizeServiceFactory;
@@ -61,7 +61,7 @@ public class METSRightsCrosswalk
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(METSRightsCrosswalk.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(METSRightsCrosswalk.class);
private static final Namespace METSRights_NS =
Namespace.getNamespace("rights", "http://cosimo.stanford.edu/sdr/metsrights/");
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/MODSDisseminationCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/MODSDisseminationCrosswalk.java
index 1258408493..ddf773dcec 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/MODSDisseminationCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/MODSDisseminationCrosswalk.java
@@ -20,8 +20,8 @@ import java.util.List;
import java.util.Map;
import java.util.Properties;
-import org.apache.commons.lang.ArrayUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Collection;
import org.dspace.content.Community;
@@ -90,7 +90,7 @@ public class MODSDisseminationCrosswalk extends SelfNamedPlugin
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(MODSDisseminationCrosswalk.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(MODSDisseminationCrosswalk.class);
private static final String CONFIG_PREFIX = "crosswalk.mods.properties.";
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/NullIngestionCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/NullIngestionCrosswalk.java
index f5cffdba15..994e15601d 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/NullIngestionCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/NullIngestionCrosswalk.java
@@ -11,7 +11,7 @@ import java.io.IOException;
import java.sql.SQLException;
import java.util.List;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.DSpaceObject;
import org.dspace.core.Context;
@@ -43,7 +43,7 @@ public class NullIngestionCrosswalk
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(NullIngestionCrosswalk.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(NullIngestionCrosswalk.class);
private static XMLOutputter outputPretty = new XMLOutputter(Format.getPrettyFormat());
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/OREDisseminationCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/OREDisseminationCrosswalk.java
index aad95da99a..af9c64b858 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/OREDisseminationCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/OREDisseminationCrosswalk.java
@@ -16,7 +16,7 @@ import java.util.HashSet;
import java.util.List;
import java.util.Set;
-import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang3.ArrayUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Bitstream;
import org.dspace.content.Bundle;
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/OREIngestionCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/OREIngestionCrosswalk.java
index 98a54ff624..6d7c716189 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/OREIngestionCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/OREIngestionCrosswalk.java
@@ -20,7 +20,7 @@ import java.util.HashSet;
import java.util.List;
import java.util.Set;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Bitstream;
import org.dspace.content.BitstreamFormat;
@@ -54,7 +54,7 @@ public class OREIngestionCrosswalk
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(OREDisseminationCrosswalk.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(OREDisseminationCrosswalk.class);
/* Namespaces */
public static final Namespace ATOM_NS =
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/PREMISCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/PREMISCrosswalk.java
index 0f3aa991cd..9f927244c9 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/PREMISCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/PREMISCrosswalk.java
@@ -13,9 +13,9 @@ import java.sql.SQLException;
import java.util.ArrayList;
import java.util.List;
-import org.apache.commons.lang.ArrayUtils;
-import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Bitstream;
import org.dspace.content.BitstreamFormat;
@@ -48,7 +48,7 @@ public class PREMISCrosswalk
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(PREMISCrosswalk.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(PREMISCrosswalk.class);
private static final Namespace PREMIS_NS =
Namespace.getNamespace("premis", "http://www.loc.gov/standards/premis");
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/QDCCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/QDCCrosswalk.java
index a20699bf1a..630d1d45ef 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/QDCCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/QDCCrosswalk.java
@@ -19,8 +19,8 @@ import java.util.List;
import java.util.Map;
import java.util.Properties;
-import org.apache.commons.lang.ArrayUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.DSpaceObject;
import org.dspace.content.Item;
@@ -97,7 +97,7 @@ public class QDCCrosswalk extends SelfNamedPlugin
/**
* log4j category
*/
- private static Logger log = Logger.getLogger(QDCCrosswalk.class);
+ private static Logger log = org.apache.logging.log4j.LogManager.getLogger(QDCCrosswalk.class);
// map of qdc to JDOM Element
private Map qdc2element = new HashMap();
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/SimpleDCDisseminationCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/SimpleDCDisseminationCrosswalk.java
index 789fa9d6fb..c9a9ddd900 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/SimpleDCDisseminationCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/SimpleDCDisseminationCrosswalk.java
@@ -12,7 +12,7 @@ import java.sql.SQLException;
import java.util.ArrayList;
import java.util.List;
-import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang3.ArrayUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.DSpaceObject;
import org.dspace.content.Item;
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/XHTMLHeadDisseminationCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/XHTMLHeadDisseminationCrosswalk.java
index c16a78f376..bc153e9426 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/XHTMLHeadDisseminationCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/XHTMLHeadDisseminationCrosswalk.java
@@ -19,7 +19,8 @@ import java.util.List;
import java.util.Map;
import java.util.Properties;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.DSpaceObject;
import org.dspace.content.Item;
@@ -65,8 +66,7 @@ public class XHTMLHeadDisseminationCrosswalk extends SelfNamedPlugin implements
/**
* log4j logger
*/
- private static Logger log = Logger
- .getLogger(XHTMLHeadDisseminationCrosswalk.class);
+ private static Logger log = LogManager.getLogger(XHTMLHeadDisseminationCrosswalk.class);
/**
* Location of config file
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/XSLTDisseminationCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/XSLTDisseminationCrosswalk.java
index 9e505ed87a..a64fd47623 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/XSLTDisseminationCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/XSLTDisseminationCrosswalk.java
@@ -22,7 +22,7 @@ import java.util.Map;
import javax.xml.transform.Transformer;
import javax.xml.transform.TransformerException;
-import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang3.ArrayUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Collection;
import org.dspace.content.Community;
diff --git a/dspace-api/src/main/java/org/dspace/content/crosswalk/XSLTIngestionCrosswalk.java b/dspace-api/src/main/java/org/dspace/content/crosswalk/XSLTIngestionCrosswalk.java
index de479a4647..3a5122b2de 100644
--- a/dspace-api/src/main/java/org/dspace/content/crosswalk/XSLTIngestionCrosswalk.java
+++ b/dspace-api/src/main/java/org/dspace/content/crosswalk/XSLTIngestionCrosswalk.java
@@ -15,8 +15,8 @@ import java.util.List;
import javax.xml.transform.Transformer;
import javax.xml.transform.TransformerException;
-import org.apache.commons.lang.ArrayUtils;
-import org.apache.log4j.Logger;
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.logging.log4j.Logger;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Collection;
import org.dspace.content.Community;
@@ -55,7 +55,7 @@ public class XSLTIngestionCrosswalk
/**
* log4j category
*/
- private static final Logger log = Logger.getLogger(XSLTIngestionCrosswalk.class);
+ private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(XSLTIngestionCrosswalk.class);
private static final String DIRECTION = "submission";
diff --git a/dspace-api/src/main/java/org/dspace/content/dao/ItemDAO.java b/dspace-api/src/main/java/org/dspace/content/dao/ItemDAO.java
index e5a0f5a4e1..8b1aa713e2 100644
--- a/dspace-api/src/main/java/org/dspace/content/dao/ItemDAO.java
+++ b/dspace-api/src/main/java/org/dspace/content/dao/ItemDAO.java
@@ -13,7 +13,6 @@ import java.util.Iterator;
import java.util.List;
import java.util.UUID;
-import org.dspace.content.Bundle;
import org.dspace.content.Collection;
import org.dspace.content.Community;
import org.dspace.content.Item;
@@ -133,11 +132,6 @@ public interface ItemDAO extends DSpaceObjectLegacySupportDAO
- {
*/
int countItems(Context context, boolean includeArchived, boolean includeWithdrawn) throws SQLException;
- public List findBundlesByName(Context context, Item item, String name) throws SQLException;
-
- public List
- findBySubmitter(Context context, EPerson eperson, Integer limit, Integer offset)
- throws SQLException;
-
public int countItems(Context context, EPerson submitter, boolean includeArchived, boolean includeWithdrawn)
throws SQLException;
diff --git a/dspace-api/src/main/java/org/dspace/content/dao/impl/BitstreamDAOImpl.java b/dspace-api/src/main/java/org/dspace/content/dao/impl/BitstreamDAOImpl.java
index fff7c42206..02e3509c31 100644
--- a/dspace-api/src/main/java/org/dspace/content/dao/impl/BitstreamDAOImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/dao/impl/BitstreamDAOImpl.java
@@ -8,10 +8,17 @@
package org.dspace.content.dao.impl;
import java.sql.SQLException;
+import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
+import java.util.Map;
+import javax.persistence.Query;
+import javax.persistence.criteria.CriteriaBuilder;
+import javax.persistence.criteria.CriteriaQuery;
+import javax.persistence.criteria.Root;
import org.dspace.content.Bitstream;
+import org.dspace.content.Bitstream_;
import org.dspace.content.Collection;
import org.dspace.content.Community;
import org.dspace.content.Item;
@@ -19,9 +26,6 @@ import org.dspace.content.dao.BitstreamDAO;
import org.dspace.core.AbstractHibernateDSODAO;
import org.dspace.core.Constants;
import org.dspace.core.Context;
-import org.hibernate.Criteria;
-import org.hibernate.Query;
-import org.hibernate.criterion.Restrictions;
/**
* Hibernate implementation of the Database Access Object interface class for the Bitstream object.
@@ -38,40 +42,35 @@ public class BitstreamDAOImpl extends AbstractHibernateDSODAO impleme
@Override
public List findDeletedBitstreams(Context context) throws SQLException {
- Criteria criteria = createCriteria(context, Bitstream.class);
- criteria.add(Restrictions.eq("deleted", true));
-
- return list(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, Bitstream.class);
+ Root bitstreamRoot = criteriaQuery.from(Bitstream.class);
+ criteriaQuery.select(bitstreamRoot);
+ criteriaQuery.where(criteriaBuilder.equal(bitstreamRoot.get(Bitstream_.deleted), true));
+ return list(context, criteriaQuery, false, Bitstream.class, -1, -1);
}
@Override
public List findDuplicateInternalIdentifier(Context context, Bitstream bitstream) throws SQLException {
- Criteria criteria = createCriteria(context, Bitstream.class);
- criteria.add(Restrictions.and(
- Restrictions.eq("internalId", bitstream.getInternalId()),
- Restrictions.not(Restrictions.eq("id", bitstream.getID()))
- ));
-
- return list(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, Bitstream.class);
+ Root bitstreamRoot = criteriaQuery.from(Bitstream.class);
+ criteriaQuery.select(bitstreamRoot);
+ criteriaQuery.where(criteriaBuilder.and(
+ criteriaBuilder.equal(bitstreamRoot.get(Bitstream_.internalId), bitstream.getInternalId()),
+ criteriaBuilder.notEqual(bitstreamRoot.get(Bitstream_.id), bitstream.getID())
+ )
+ );
+ return list(context, criteriaQuery, false, Bitstream.class, -1, -1);
}
@Override
public List findBitstreamsWithNoRecentChecksum(Context context) throws SQLException {
-// "select bitstream.deleted, bitstream.store_number, bitstream.size_bytes, "
-// + "bitstreamformatregistry.short_description, bitstream.bitstream_id, "
-// + "bitstream.user_format_description, bitstream.internal_id, "
-// + "bitstream.source, bitstream.checksum_algorithm, bitstream.checksum, "
-// + "bitstream.name, bitstream.description "
-// + "from bitstream left outer join bitstreamformatregistry on "
-// + "bitstream.bitstream_format_id = bitstreamformatregistry.bitstream_format_id "
-// + "where not exists( select 'x' from most_recent_checksum "
-// + "where most_recent_checksum.bitstream_id = bitstream.bitstream_id )"
-
Query query = createQuery(context,
"select b from Bitstream b where b not in (select c.bitstream from " +
"MostRecentChecksum c)");
- return query.list();
+ return query.getResultList();
}
@Override
@@ -122,9 +121,14 @@ public class BitstreamDAOImpl extends AbstractHibernateDSODAO impleme
@Override
public Long countByStoreNumber(Context context, Integer storeNumber) throws SQLException {
- Criteria criteria = createCriteria(context, Bitstream.class);
- criteria.add(Restrictions.eq("storeNumber", storeNumber));
- return countLong(criteria);
+
+
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = criteriaBuilder.createQuery(Long.class);
+
+ Root bitstreamRoot = criteriaQuery.from(Bitstream.class);
+ criteriaQuery.where(criteriaBuilder.equal(bitstreamRoot.get(Bitstream_.storeNumber), storeNumber));
+ return countLong(context, criteriaQuery, criteriaBuilder, bitstreamRoot);
}
@Override
@@ -158,9 +162,8 @@ public class BitstreamDAOImpl extends AbstractHibernateDSODAO impleme
@Override
public Iterator findAll(Context context, int limit, int offset) throws SQLException {
- Query query = createQuery(context, "select b FROM Bitstream b");
- query.setFirstResult(offset);
- query.setMaxResults(limit);
- return iterate(query);
+ Map map = new HashMap<>();
+ return findByX(context, Bitstream.class, map, true, limit, offset).iterator();
+
}
}
diff --git a/dspace-api/src/main/java/org/dspace/content/dao/impl/BitstreamFormatDAOImpl.java b/dspace-api/src/main/java/org/dspace/content/dao/impl/BitstreamFormatDAOImpl.java
index 51b0af51de..0824c5c343 100644
--- a/dspace-api/src/main/java/org/dspace/content/dao/impl/BitstreamFormatDAOImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/dao/impl/BitstreamFormatDAOImpl.java
@@ -8,16 +8,18 @@
package org.dspace.content.dao.impl;
import java.sql.SQLException;
+import java.util.LinkedList;
import java.util.List;
+import javax.persistence.Query;
+import javax.persistence.criteria.CriteriaBuilder;
+import javax.persistence.criteria.CriteriaQuery;
+import javax.persistence.criteria.Root;
import org.dspace.content.BitstreamFormat;
+import org.dspace.content.BitstreamFormat_;
import org.dspace.content.dao.BitstreamFormatDAO;
import org.dspace.core.AbstractHibernateDAO;
import org.dspace.core.Context;
-import org.hibernate.Criteria;
-import org.hibernate.Query;
-import org.hibernate.criterion.Order;
-import org.hibernate.criterion.Restrictions;
/**
* Hibernate implementation of the Database Access Object interface class for the BitstreamFormat object.
@@ -37,11 +39,14 @@ public class BitstreamFormatDAOImpl extends AbstractHibernateDAOnull if
- * there's no bitstream format with the given MIMEtype.
+ * there's no bitstream format with the given MIMEtype.
* @throws SQLException if database error
*/
@Override
@@ -49,33 +54,39 @@ public class BitstreamFormatDAOImpl extends AbstractHibernateDAO bitstreamFormatRoot = criteriaQuery.from(BitstreamFormat.class);
+ criteriaQuery.select(bitstreamFormatRoot);
+ criteriaQuery.where(criteriaBuilder.and(
+ criteriaBuilder.equal(bitstreamFormatRoot.get(BitstreamFormat_.internal), includeInternal),
+ criteriaBuilder.like(bitstreamFormatRoot.get(BitstreamFormat_.mimetype), mimeType)
+ )
+ );
+ return singleResult(context, criteriaQuery);
}
/**
* Find a bitstream format by its (unique) short description
*
- * @param context DSpace context object
- * @param desc the short description
+ * @param context
+ * DSpace context object
+ * @param desc
+ * the short description
+ *
* @return the corresponding bitstream format, or
null
if
- * there's no bitstream format with the given short description
+ * there's no bitstream format with the given short description
* @throws SQLException if database error
*/
@Override
public BitstreamFormat findByShortDescription(Context context,
String desc) throws SQLException {
- Criteria criteria = createCriteria(context, BitstreamFormat.class);
- criteria.add(Restrictions.and(
- Restrictions.eq("shortDescription", desc)
- ));
-
- return uniqueResult(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, BitstreamFormat.class);
+ Root bitstreamFormatRoot = criteriaQuery.from(BitstreamFormat.class);
+ criteriaQuery.select(bitstreamFormatRoot);
+ criteriaQuery.where(criteriaBuilder.equal(bitstreamFormatRoot.get(BitstreamFormat_.shortDescription), desc));
+ return uniqueResult(context, criteriaQuery, false, BitstreamFormat.class, -1, -1);
}
@Override
@@ -93,14 +104,28 @@ public class BitstreamFormatDAOImpl extends AbstractHibernateDAO findNonInternal(Context context) throws SQLException {
- Criteria criteria = createCriteria(context, BitstreamFormat.class);
- criteria.add(Restrictions.and(
- Restrictions.eq("internal", false),
- Restrictions.not(Restrictions.like("shortDescription", "Unknown"))
- ));
- criteria.addOrder(Order.desc("supportLevel")).addOrder(Order.asc("shortDescription"));
- return list(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, BitstreamFormat.class);
+ Root bitstreamFormatRoot = criteriaQuery.from(BitstreamFormat.class);
+ criteriaQuery.select(bitstreamFormatRoot);
+ criteriaQuery
+ .where(criteriaBuilder.and(criteriaBuilder.equal(bitstreamFormatRoot.get(BitstreamFormat_.internal), false),
+ criteriaBuilder.not(
+ criteriaBuilder
+ .like(bitstreamFormatRoot.get(BitstreamFormat_.shortDescription),
+ "Unknown"))
+ )
+ );
+
+
+ List orderList = new LinkedList<>();
+ orderList.add(criteriaBuilder.desc(bitstreamFormatRoot.get(BitstreamFormat_.supportLevel)));
+ orderList.add(criteriaBuilder.asc(bitstreamFormatRoot.get(BitstreamFormat_.shortDescription)));
+ criteriaQuery.orderBy(orderList);
+
+
+ return list(context, criteriaQuery, false, BitstreamFormat.class, -1, -1);
}
@@ -110,17 +135,22 @@ public class BitstreamFormatDAOImpl extends AbstractHibernateDAO findAll(Context context, Class clazz) throws SQLException {
- Criteria criteria = createCriteria(context, BitstreamFormat.class);
- criteria.addOrder(Order.asc("id"));
- return list(criteria);
+
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, BitstreamFormat.class);
+ Root bitstreamFormatRoot = criteriaQuery.from(BitstreamFormat.class);
+ criteriaQuery.select(bitstreamFormatRoot);
+
+ List orderList = new LinkedList<>();
+ orderList.add(criteriaBuilder.asc(bitstreamFormatRoot.get(BitstreamFormat_.id)));
+ criteriaQuery.orderBy(orderList);
+
+ return list(context, criteriaQuery, false, BitstreamFormat.class, -1, -1);
}
}
diff --git a/dspace-api/src/main/java/org/dspace/content/dao/impl/CollectionDAOImpl.java b/dspace-api/src/main/java/org/dspace/content/dao/impl/CollectionDAOImpl.java
index 14b1587315..9180fb3c09 100644
--- a/dspace-api/src/main/java/org/dspace/content/dao/impl/CollectionDAOImpl.java
+++ b/dspace-api/src/main/java/org/dspace/content/dao/impl/CollectionDAOImpl.java
@@ -8,11 +8,22 @@
package org.dspace.content.dao.impl;
import java.sql.SQLException;
+import java.util.AbstractMap;
import java.util.Arrays;
+import java.util.LinkedList;
import java.util.List;
import java.util.Map;
+import javax.persistence.Query;
+import javax.persistence.criteria.CriteriaBuilder;
+import javax.persistence.criteria.CriteriaQuery;
+import javax.persistence.criteria.Join;
+import javax.persistence.criteria.Predicate;
+import javax.persistence.criteria.Root;
+import org.dspace.authorize.ResourcePolicy;
+import org.dspace.authorize.ResourcePolicy_;
import org.dspace.content.Collection;
+import org.dspace.content.Collection_;
import org.dspace.content.Item;
import org.dspace.content.MetadataField;
import org.dspace.content.dao.CollectionDAO;
@@ -21,11 +32,6 @@ import org.dspace.core.Constants;
import org.dspace.core.Context;
import org.dspace.eperson.EPerson;
import org.dspace.eperson.Group;
-import org.hibernate.Criteria;
-import org.hibernate.Query;
-import org.hibernate.criterion.Disjunction;
-import org.hibernate.criterion.Restrictions;
-import org.hibernate.transform.BasicTransformerAdapter;
/**
* Hibernate implementation of the Database Access Object interface class for the Collection object.
@@ -43,8 +49,9 @@ public class CollectionDAOImpl extends AbstractHibernateDSODAO imple
* Get all collections in the system. These are alphabetically sorted by
* collection name.
*
- * @param context DSpace context object
- * @param order order by MetadataField
+ * @param context
+ * DSpace context object
+ * @param order order by MetadataField
* @return the collections in the system
* @throws SQLException if database error
*/
@@ -75,77 +82,54 @@ public class CollectionDAOImpl extends AbstractHibernateDSODAO imple
@Override
public Collection findByTemplateItem(Context context, Item item) throws SQLException {
- Criteria criteria = createCriteria(context, Collection.class);
- criteria.add(Restrictions.eq("template_item", item));
- return uniqueResult(criteria);
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, Collection.class);
+ Root collectionRoot = criteriaQuery.from(Collection.class);
+ criteriaQuery.select(collectionRoot);
+ criteriaQuery.where(criteriaBuilder.equal(collectionRoot.get(Collection_.template), item));
+ return uniqueResult(context, criteriaQuery, false, Collection.class, -1, -1);
}
@Override
public Collection findByGroup(Context context, Group group) throws SQLException {
- Criteria criteria = createCriteria(context, Collection.class);
- criteria.add(
- Restrictions.or(
- Restrictions.eq("workflowStep1", group),
- Restrictions.eq("workflowStep2", group),
- Restrictions.eq("workflowStep3", group),
- Restrictions.eq("submitters", group),
- Restrictions.eq("admins", group)
- )
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, Collection.class);
+ Root collectionRoot = criteriaQuery.from(Collection.class);
+ criteriaQuery.select(collectionRoot);
+ criteriaQuery
+ .where(criteriaBuilder.or(criteriaBuilder.equal(collectionRoot.get(Collection_.workflowStep1), group),
+ criteriaBuilder.equal(collectionRoot.get(Collection_.workflowStep2), group),
+ criteriaBuilder.equal(collectionRoot.get(Collection_.workflowStep3), group),
+ criteriaBuilder.equal(collectionRoot.get(Collection_.submitters), group),
+ criteriaBuilder.equal(collectionRoot.get(Collection_.admins), group)
+ )
);
- return singleResult(criteria);
+ return singleResult(context, criteriaQuery);
}
@Override
public List findAuthorized(Context context, EPerson ePerson, List actions)
throws SQLException {
- // TableRowIterator tri = DatabaseManager.query(context,
-// "SELECT * FROM collection, resourcepolicy, eperson " +
-// "WHERE resourcepolicy.resource_id = collection.collection_id AND " +
-// "eperson.eperson_id = resourcepolicy.eperson_id AND "+
-// "resourcepolicy.resource_type_id = 3 AND "+
-// "( resourcepolicy.action_id = 3 OR resourcepolicy.action_id = 11 ) AND "+
-// "eperson.eperson_id = ?", context.getCurrentUser().getID());
-
- Criteria criteria = createCriteria(context, Collection.class);
- criteria.createAlias("resourcePolicies", "resourcePolicy");
-
- Disjunction actionQuery = Restrictions.or();
+ CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
+ CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, Collection.class);
+ Root collectionRoot = criteriaQuery.from(Collection.class);
+ Join join = collectionRoot.join("resourcePolicies");
+ List orPredicates = new LinkedList();
for (Integer action : actions) {
- actionQuery.add(Restrictions.eq("resourcePolicy.actionId", action));
+ orPredicates.add(criteriaBuilder.equal(join.get(ResourcePolicy_.actionId), action));
}
- criteria.add(Restrictions.and(
- Restrictions.eq("resourcePolicy.resourceTypeId", Constants.COLLECTION),
- Restrictions.eq("resourcePolicy.eperson", ePerson),
- actionQuery
- ));
- criteria.setCacheable(true);
-
- return list(criteria);
+ Predicate orPredicate = criteriaBuilder.or(orPredicates.toArray(new Predicate[] {}));
+ criteriaQuery.select(collectionRoot);
+ criteriaQuery.where(
+ criteriaBuilder.and(criteriaBuilder.equal(join.get(ResourcePolicy_.resourceTypeId), Constants.COLLECTION),
+ criteriaBuilder.equal(join.get(ResourcePolicy_.eperson), ePerson),
+ orPredicate));
+ return list(context, criteriaQuery, true, Collection.class, -1, -1);
}
@Override
public List findAuthorizedByGroup(Context context, EPerson ePerson, List actions)
throws SQLException {
- // TableRowIterator tri = DatabaseManager.query(context,
- // "SELECT \n" +
- // " * \n" +
- // "FROM \n" +
- // " public.eperson, \n" +
- // " public.epersongroup2eperson, \n" +
- // " public.epersongroup, \n" +
- // " public.group2group, \n" +
- // " public.resourcepolicy rp_parent, \n" +
- // " public.collection\n" +
- // "WHERE \n" +
- // " epersongroup2eperson.eperson_id = eperson.eperson_id AND\n" +
- // " epersongroup.eperson_group_id = epersongroup2eperson.eperson_group_id AND\n" +
- // " group2group.child_id = epersongroup.eperson_group_id AND\n" +
- // " rp_parent.epersongroup_id = group2group.parent_id AND\n" +
- // " collection.collection_id = rp_parent.resource_id AND\n" +
- // " eperson.eperson_id = ? AND \n" +
- // " (rp_parent.action_id = 3 OR \n" +
- // " rp_parent.action_id = 11 \n" +
- // " ) AND rp_parent.resource_type_id = 3;", context.getCurrentUser().getID());
StringBuilder query = new StringBuilder();
query.append("select c from Collection c join c.resourcePolicies rp join rp.epersonGroup rpGroup WHERE ");
for (int i = 0; i < actions.size(); i++) {
@@ -159,11 +143,11 @@ public class CollectionDAOImpl extends AbstractHibernateDSODAO imple
query.append(
" AND rp.epersonGroup.id IN (select g.id from Group g where (from EPerson e where e.id = :eperson_id) in " +
"elements(epeople))");
- Query hibernateQuery = createQuery(context, query.toString());
- hibernateQuery.setParameter("eperson_id", ePerson.getID());
- hibernateQuery.setCacheable(true);
+ Query persistenceQuery = createQuery(context, query.toString());
+ persistenceQuery.setParameter("eperson_id", ePerson.getID());
+ persistenceQuery.setHint("org.hibernate.cacheable", Boolean.TRUE);
- return list(hibernateQuery);
+ return list(persistenceQuery);
}
@@ -185,12 +169,12 @@ public class CollectionDAOImpl extends AbstractHibernateDSODAO imple
String q = "select col as collection, sum(bit.sizeBytes) as totalBytes from Item i join i.collections col " +
"join i.bundles bun join bun.bitstreams bit group by col";
Query query = createQuery(context, q);
- query.setResultTransformer(new BasicTransformerAdapter() {
- @Override
- public Object transformTuple(Object[] tuple, String[] aliases) {
- return new java.util.AbstractMap.SimpleImmutableEntry<>((Collection) tuple[0], (Long) tuple[1]);
- }
- });
- return ((List>) query.list());
+
+ List