hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-14 05:23:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8108 from tdonohue/dont_swallow_exceptions

Browse Source 
Ensure SubmissionService doesn't swallow root exceptions
This commit is contained in:
Tim Donohue
2022-01-12 09:41:26 -06:00
committed by GitHub
parent 611b015e45 947552fc34
commit d0bc89fef4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dspace-server-webapp/src/main/java/org/dspace/app/rest/submit/SubmissionService.java
View File

@@ -250,7 +250,7 @@ public class SubmissionService {
id = Integer.parseInt(split[1]); id = Integer.parseInt(split[1]);
wsi = workspaceItemService.find(context, id); wsi = workspaceItemService.find(context, id);
} catch (NumberFormatException e) { } catch (NumberFormatException e) {
throw new UnprocessableEntityException("The provided workspaceitem URI is not valid"); throw new UnprocessableEntityException("The provided workspaceitem URI is not valid", e);
} }
if (wsi == null) { if (wsi == null) {
throw new UnprocessableEntityException("Workspace item is not found"); throw new UnprocessableEntityException("Workspace item is not found");
@@ -265,7 +265,7 @@ public class SubmissionService {
wi = workflowService.start(context, wsi); wi = workflowService.start(context, wsi);
} catch (IOException e) { } catch (IOException e) {
throw new RuntimeException("The workflow could not be started for workspaceItem with" + throw new RuntimeException("The workflow could not be started for workspaceItem with" +
"id: " + id); " id: " + id, e);
} }
return wi; return wi;