[DS-707] Code analysis efficiencies

git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5511 9c30dcfa-912a-0410-8fc2-9e0234be79fd
This commit is contained in:
Graham Triggs
2010-10-21 10:47:13 +00:00
parent aa9709d630
commit e0c560ea95
18 changed files with 21 additions and 53 deletions

View File

@@ -1582,7 +1582,7 @@ public class Item extends DSpaceObject
// Bad DC field, log and throw exception
log.warn(LogManager
.getHeader(ourContext, "bad_dc",
"Bad DC field. schema="+String.valueOf(dcv.schema)
"Bad DC field. schema="+dcv.schema
+ ", element: \""
+ ((dcv.element == null) ? "null"
: dcv.element)
@@ -2525,8 +2525,7 @@ public class Item extends DSpaceObject
"WHERE template_item_id = ?",getID());
if (qResult != null)
{
Collection collection = Collection.find(ourContext,qResult.getIntColumn("collection_id"));
return collection;
return Collection.find(ourContext,qResult.getIntColumn("collection_id"));
}
return null;
}