hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-07 01:54:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bug fix to EPersonDAOImpl. Correctly determine if excluded group needs to be preceded by AND or WHERE

Browse Source
This commit is contained in:
Tim Donohue
2023-10-17 16:27:51 -05:00
parent 5208a355d6
commit e5e0eaa999
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
dspace-api/src/main/java/org/dspace/eperson/dao/impl/EPersonDAOImpl.java
View File

@@ -238,7 +238,14 @@ public class EPersonDAOImpl extends AbstractHibernateDSODAO<EPerson> implements
// If excludeGroup is specified, exclude members of that group from results // If excludeGroup is specified, exclude members of that group from results
// This uses a subquery to find the excluded group & verify that it is not in the EPerson list of "groups" // This uses a subquery to find the excluded group & verify that it is not in the EPerson list of "groups"
if (excludeGroup != null) { if (excludeGroup != null) {
queryBuilder.append(" AND (FROM Group g where g.id = :group_id) NOT IN elements (") // If query params exist, then we already have a WHERE clause (see above) and just need to append an AND
if (StringUtils.isNotBlank(queryParam)) {
queryBuilder.append(" AND ");
} else {
// no WHERE clause yet, so this is the start of the WHERE
queryBuilder.append(" WHERE ");
}
queryBuilder.append("(FROM Group g where g.id = :group_id) NOT IN elements (")
.append(EPerson.class.getSimpleName().toLowerCase()).append(".groups)"); .append(EPerson.class.getSimpleName().toLowerCase()).append(".groups)");
} }
// Add sort/order by info to query, if specified // Add sort/order by info to query, if specified