diff --git a/dspace-api/pom.xml b/dspace-api/pom.xml index fe795f29d4..3ee9651c6c 100644 --- a/dspace-api/pom.xml +++ b/dspace-api/pom.xml @@ -351,8 +351,8 @@ commons-collections - commons-dbcp - commons-dbcp + org.apache.commons + commons-dbcp2 commons-fileupload @@ -585,7 +585,7 @@ - postgresql + org.postgresql postgresql diff --git a/dspace-api/src/main/java/org/dspace/storage/rdbms/DatabaseUtils.java b/dspace-api/src/main/java/org/dspace/storage/rdbms/DatabaseUtils.java index 4a746699ac..12050d75c7 100644 --- a/dspace-api/src/main/java/org/dspace/storage/rdbms/DatabaseUtils.java +++ b/dspace-api/src/main/java/org/dspace/storage/rdbms/DatabaseUtils.java @@ -21,7 +21,7 @@ import java.util.List; import java.util.Locale; import javax.sql.DataSource; -import org.apache.commons.dbcp.BasicDataSource; +import org.apache.commons.dbcp2.BasicDataSource; import org.apache.commons.lang.StringUtils; import org.apache.log4j.Logger; import org.dspace.core.ConfigurationManager; @@ -322,11 +322,6 @@ public class DatabaseUtils // NOTE: DatabaseLegacyReindexer only indexes in Legacy Lucene & RDBMS indexes. It can be removed once those are obsolete. List flywayCallbacks = new DSpace().getServiceManager().getServicesByType(FlywayCallback.class); flywaydb.setCallbacks(flywayCallbacks.toArray(new FlywayCallback[flywayCallbacks.size()])); - - // Set flyway callbacks (i.e. classes which are called post-DB migration and similar) - // In this situation, we have a Registry Updater that runs PRE-migration - // NOTE: DatabaseLegacyReindexer only indexes in Legacy Lucene & RDBMS indexes. It can be removed once those are obsolete. -// flywaydb.setCallbacks(new DatabaseRegistryUpdater(), new DatabaseLegacyReindexer()); } catch(SQLException e) { @@ -1142,4 +1137,12 @@ public class DatabaseUtils } } + /** + * In case of a unit test the flyway db is cached to long leading to exceptions, we need to clear the object + */ + public static void clearFlywayDBCache() + { + flywaydb = null; + } + } diff --git a/dspace-api/src/test/data/dspaceFolder/config/spring/api/core-test-hibernate.xml b/dspace-api/src/test/data/dspaceFolder/config/spring/api/core-test-hibernate.xml index 0a13fc9cb5..20e79f1761 100644 --- a/dspace-api/src/test/data/dspaceFolder/config/spring/api/core-test-hibernate.xml +++ b/dspace-api/src/test/data/dspaceFolder/config/spring/api/core-test-hibernate.xml @@ -8,7 +8,7 @@ - + diff --git a/dspace-api/src/test/java/org/dspace/AbstractUnitTest.java b/dspace-api/src/test/java/org/dspace/AbstractUnitTest.java index d1330c87f0..697eccffa6 100644 --- a/dspace-api/src/test/java/org/dspace/AbstractUnitTest.java +++ b/dspace-api/src/test/java/org/dspace/AbstractUnitTest.java @@ -109,6 +109,8 @@ public class AbstractUnitTest { kernelImpl.start(ConfigurationManager.getProperty("dspace.dir")); } + //Clear our old flyway object + DatabaseUtils.clearFlywayDBCache(); //Migrate & setup our database DatabaseUtils.main(new String[]{"migrate"}); diff --git a/dspace-rest/pom.xml b/dspace-rest/pom.xml index c4cbfab061..977158ce08 100644 --- a/dspace-rest/pom.xml +++ b/dspace-rest/pom.xml @@ -107,11 +107,11 @@ - commons-dbcp - commons-dbcp + org.apache.commons + commons-dbcp2 - postgresql + org.postgresql postgresql diff --git a/dspace-swordv2/pom.xml b/dspace-swordv2/pom.xml index 6b19f5fe9b..a08b3d5f8c 100644 --- a/dspace-swordv2/pom.xml +++ b/dspace-swordv2/pom.xml @@ -81,7 +81,7 @@ - postgresql + org.postgresql postgresql diff --git a/dspace/config/spring/api/core-hibernate.xml b/dspace/config/spring/api/core-hibernate.xml index f52d8a9129..7d01222b55 100644 --- a/dspace/config/spring/api/core-hibernate.xml +++ b/dspace/config/spring/api/core-hibernate.xml @@ -8,7 +8,7 @@ - + diff --git a/dspace/modules/swordv2/pom.xml b/dspace/modules/swordv2/pom.xml index 6b9739e7a7..4a662d88a1 100644 --- a/dspace/modules/swordv2/pom.xml +++ b/dspace/modules/swordv2/pom.xml @@ -82,7 +82,7 @@ - postgresql + org.postgresql postgresql diff --git a/pom.xml b/pom.xml index 3253fc1a99..a1514e9772 100644 --- a/pom.xml +++ b/pom.xml @@ -972,9 +972,9 @@ - commons-dbcp - commons-dbcp - 1.4 + org.apache.commons + commons-dbcp2 + 2.1.1 commons-discovery @@ -1153,9 +1153,9 @@ 51.1 - postgresql + org.postgresql postgresql - 9.1-901-1.jdbc4 + 9.4-1203-jdbc41 com.oracle