* Ensured compilation against latest master
* Removed the verbose print extracted text as it would really clutter the output
* Compressed the string to inputStream from 3 lines into a single one.
* Removed obsolete constructor call to the "ExtractorFactory"
* Removed a TODO that I verified
When we have two workflows, W1 and W2, and W2 has a first
step with a ID equal to other step ID in W1, WorkflowFactory
retrieves erroneously the step in W1 when we ask about the
first step in W2.
To prevent this, the corresponding XPath expression was modified.
- Removed pattern matches for "search", "simple-search", "advanced-search", "handle/*/*/search", "handle/*/*/simple-search", "handle/*/*/advanced-search" in XMLUI Statistics sitemap.map and inserted comments to indicate this removal
(part of me wants to remap some discover stuff into /search since that's such an obvious/common URL pattern...)
- Removed StatisticsSearchResultTransformer transformer mapping from Statistics sitemap.xmap
- Removed dspace-xmlui\src\main\webapp\static\js\search-results.js
- Removed org.dspace.app.xmlui.aspect.statistics.StatisticsSearchResultTransformer
- Removed org.dspace.app.xmlui.aspect.artifactbrowser.AdvancedSearchUtils
DSQuery dependency (outside org.dspace.search) removal, continued:
====
Removing org.dspace.app.xmlui.opensearch.StandardOpenSearchGenerator:
- Removed map:generator mapping for StandardOpenSearchGenerator in XMLUI sitemap.xmap
- This generator was matched on pattern "open-search/" in XMLUI sitemap.xmap. I've remapped
that pattern to DiscoveryOpenSearchGenerator (also mapped on open-search/discovery) to try and
keep things working as smoothly as possible, and added a comment to that effect.
- Removed org.app.xmlui.opensearch.StandardOpenSearchGenerator class
Removed (unused) import in org.dspace.app.xmlui.aspect.administrative.mapper.SearchItemForm
Removing org.dspace.app.xmlui.aspect.artifactbrowser.AbstractSearch and implementations:
- AdvancedSearch and AdvancedSearchLoggerAction:
- Removed mapping for pattern match "advanced-search" and "handle/*/*/advanced-search", added comments indicating removal, removed transformer mapping from ArtifactBrowser sitemap.xmap
- Removed mapping for pattern match "advanced-search" (includes map:act for AdvancedSearchLoggerAction) and "handle/*/*/advanced-search" (also includes map:act for AdvancedSearchLoggerAction), added comments indicating removal, removed action mapping for AdvancedSearchLoggerAction, removed transformer mapping for AdvancedSearch from SearchArtifacts sitemap.xmap (I have a feeling SearchArtifacts as a whole should be pulled out now, but will revisit that later)
- Note: I'm leaving i18n keys for xmlui.ArtifactBrowser.AdvancedSearch alone until I can be sure that they can be safely removed or moved without stuffing up anyone's UI
- Removed org.dspace.app.xmlui.aspect.artifactbrowser.AdvancedSearch class
- Removed org.dspace.app.xmlui.aspect.artifactbrowser.AdvancedSearchLoggerAction class
DSIndexer dependency (outside org.dspace.search) removal: (complete)
====
Removed (unused) java class import from MediaFilter
Removed ItemImport DSIndexer.setBatchProcessingMode references, removed java class import
Removed FlyWay allback to DatabaseLegacyReindexer, removed DatabaseLegacyReindexer class
DSQuery dependency (outside org.dspace.search) removal: (WIP)
====
Removed org.dspace.app.webui.search.LuceneRequestProcessor and dependencies/imports in:
- its reference in dspace.cfg, JSPUI Discovery section, updated comments to reflect removal
- (unused) class import in org.dspace.app.webui.servlet.AdvancedSearchServlet
- (unused) class import in org.dspace.app.webui.servlet.OpenSearchServlet
- (unused) class import in org.dspace.app.webui.servlet.SimpleSearchServlet
- (unused) class import in org.dspace.app.webui.servlet.admin.ItemMapServlet
Removed org.dspace.xmlui.aspect.adminstrative.mapper.LuceneSearchRequestProcessor and its reference in dspace.cfg, XMLUI Discovery section, updated comments to reflect removal.
Notes: org.dspace.app.webui.search now only contains SearchRequestProcessor and
SearchProcessorException. SearchReqeuestProcessor is now only implemented by
org.dspace.app.webui.discovery.DiscoverySearchRequestProcessor. Would it make sense to move
these classes into org.dspace.app.webui.discovery and refactor references to
SearchProcessorException accordingly? Or is it safer for unknown customisations to leave as
is?
org.dspace.app.xmlui.opensearch.DiscoveryOpenSearchGenerator and
org.dspace.app.xmlui.opensearch.StandardOpenSearchGenerator had their summary comments mixed
up - I swapped these back around. No removal of StandardOpenSearchGenerator yet, needs closer
inspection of usage in sitemap, pattern mapping etc.
