Commit Graph

8847 Commits

Author SHA1 Message Date
Tim Donohue
efa96af2fc Merge pull request #1192 from KevinVdV/DS-2918-fix-self-assigned-variable
[DS-2918] Fix self assigned variable in MetadataWebService
2016-04-21 15:42:45 -05:00
Tim Donohue
d756be2263 Stop loading all configurations for log4j initialization 2016-04-21 15:02:32 -05:00
Tim Donohue
eae20d38d1 Filter all log4j files via Ant. Move log.dir and other logging settings to log4j.properties, and similar. 2016-04-21 15:02:13 -05:00
Tim Donohue
1a46165c75 Merge pull request #1287 from helix84/DS-3052-pdfbox-improvements
DS-3052 improvements to PDFBox-based code
2016-04-21 12:23:53 -05:00
Pascal-Nicolas Becker
1bc28df1fb Merge pull request #1358 from tuub/DS-3136
DS-3136: Prevent the occurrence of internal server error while adding a bitstream to an item if the upload button is pressed without selecting a file
2016-04-21 18:06:10 +02:00
Pascal-Nicolas Becker
ccab58e0aa Merge pull request #1354 from DylanMeeus/DS-3123-privacy-settings-xmlui
DS-3123: Respect privacy settings in XMLUI
2016-04-21 17:58:47 +02:00
Mark H. Wood
cbc53cac75 [DS-3139] Fix double SLF4J backend, align other dependencies more closely with reality. 2016-04-21 11:56:21 -04:00
Mark H. Wood
5ab9a2e778 [DS-3139] Exclude dependency of dependency, that should have been declared test-scoped. 2016-04-21 11:54:11 -04:00
Hardy Pottinger
ab6fc2fc5c Merge pull request #1352 from KevinVdV/DS-3125-submitter-cannot-bitstreams
[DS-3125] Submitters cannot delete bistreams of workspaceitems
2016-04-21 10:49:25 -05:00
dylan
29935532b3 place removed comment back 2016-04-21 17:41:19 +02:00
Marsa Haoua
6d0251487d Solve the internal server error at a deeper level 2016-04-21 17:39:30 +02:00
dylan
5557bf2a49 Using DSpaceServicesFactory 2016-04-21 17:37:32 +02:00
dylan
d3a9236648 Update comments 2016-04-21 17:27:08 +02:00
Marsa Haoua
2436c6bd65 prevent the occurrence of internal server error while adding a bitstream to an item if the upload button is pressed without selecting a file 2016-04-21 15:36:51 +02:00
Pascal-Nicolas Becker
38791e705f Merge pull request #931 from tuub/DS-2552
DS-2552: Makes configurable whether handles or DOIs should be displayed in JSPUI
2016-04-21 14:14:54 +02:00
Pascal-Nicolas Becker
572c77879a Changing comment in dspace.cfg about webui.identifier.strip-prefixes 2016-04-21 13:45:41 +02:00
Pascal-Nicolas Becker
c4d63e74e5 Changing comment in dspace.cfg about webui.preferred.identifier 2016-04-21 13:28:29 +02:00
Tim Donohue
3d6c4b92e4 Merge pull request #1154 from helix84/DS-2871-mirage-chrome-warnings-2
DS-2871 remove Modernizer from Mirage; it's unused
2016-04-20 11:52:18 -05:00
Tim Donohue
d32056afd3 Merge pull request #1224 from KevinVdV/DS-1955-embargo-reason-length
DS-1955 embargo reason length
2016-04-20 11:39:13 -05:00
Tim Donohue
b1526930b1 Merge pull request #1328 from lap82/DS-2621-M
[DS-2621] adjust check to enable not mandatory collection via jsp
2016-04-20 11:30:29 -05:00
Tim Donohue
5623cfa6bd Merge pull request #1357 from jonas-atmire/DS-3133-Spider-matching-case-insensitive
DS-3133 Add case-insensitive flag in SpiderDetector
2016-04-20 11:11:01 -05:00
Jonas Van Goolen
f3843bba4b DS-3133 When matching for spiders, add a case insensitive flag
(so for example, spider, would match "Spider", "SPIDER", "spideR", etc)
2016-04-20 16:09:54 +02:00
Tim Donohue
51d0064d81 Merge pull request #1356 from atmire/DS-3131
DS-3131
2016-04-20 08:52:53 -05:00
philip Vissenaekens
3c94b1dc2c DS-3131 2016-04-19 17:11:35 +02:00
philip Vissenaekens
3405d806bc DS-3131 2016-04-19 16:43:22 +02:00
Tim Donohue
07244a55ff Merge pull request #1355 from tdonohue/DS-3130
DS-3130: Fix inconsistent logging of EventServiceImpl
2016-04-19 09:33:57 -05:00
Tim Donohue
0fa4a2011e DS-3130: Fix inconsistent logging. Remove incorrect comments. Change constructor method to private. 2016-04-18 15:05:14 -05:00
KevinVdV
f40422f0a8 [DS-3125] Submitters cannot delete bistreams of workspaceitems: Oracle sql migration script 2016-04-18 12:34:11 +02:00
KevinVdV
4af7466b8e [DS-3125] Submitters cannot delete bistreams of workspaceitems: Include delete rights for workflow members in the basic workflow 2016-04-15 13:09:47 +02:00
KevinVdV
bc9798c753 [DS-3125] Submitters cannot delete bistreams of workspaceitems 2016-04-15 13:00:37 +02:00
Mark H. Wood
7305af96f1 Merge pull request #1342 from mwoodiupui/DS-2805
[DS-2805] Improper Hibernate Date comparisons
2016-04-14 17:12:45 -04:00
Mark H. Wood
0018496c23 [DS-2805] Testing revealed an unrelated error: mismatch between query and setParameter. 2016-04-14 16:59:25 -04:00
Mark H. Wood
553439853c [DS-2805] Add a unit test to try this out. 2016-04-14 16:54:49 -04:00
dylan
b93991552a Respect privacy settings in xmlui 2016-04-14 16:36:36 +02:00
Tim Donohue
37f55fa8b1 Merge pull request #1346 from tdonohue/DS-3116
DS-3116 : Only log errors if service bean cannot be located.
2016-04-13 16:09:31 -05:00
Kevin Van de Velde
efbaa56154 Merge pull request #881 from tuub/DS-1348
DS-3109: Introduce a VersionedHandleIdentifierProvider that creates new handles for each version
2016-04-13 12:25:21 +02:00
Pascal-Nicolas Becker
fba613f2ae Update DIM2EZID.xsl as well. 2016-04-11 16:09:17 +02:00
Pascal-Nicolas Becker
24e18f082a Change datacite schema namespace in dspace.cfg. 2016-04-09 17:29:21 +02:00
Pascal-Nicolas Becker
025a1ea8f5 DS-2924: Fix DIM2DataCite crosswalk and update to DataCite Schema 3.1 2016-04-09 11:15:29 +02:00
Pascal-Nicolas Becker
a9bf72575b Merge pull request #1218 from mwoodiupui/DS-2949
[DS-2949] XSLT crosswalks should be parameterizable
2016-04-08 18:19:14 +02:00
Pascal-Nicolas Becker
54de1ac71d Add handles in canonical form to the metadata. 2016-04-07 15:39:13 +02:00
Pascal-Nicolas Becker
74664af84d Mention both VersionedHandleIdentifier in DSpace's spring config 2016-04-07 15:29:49 +02:00
Pascal-Nicolas Becker
f84f1dc283 Versioned Items should have one handle only, remove old ones before. 2016-04-07 15:29:49 +02:00
Pascal-Nicolas Becker
46c223d172 DS-2940: fixing metadata problems with canonical versioned handles. 2016-04-07 15:29:49 +02:00
Pascal-Nicolas Becker
bff93d6686 DS-1348: Removing the use of "canonical handles"
The previous VersionedHandleIdentifierProvider introduced "canonical
handles". The idea was to keep the current handle always linked to the
newest version of an item. The downside is that this limits the
versioning to version changes that do not derogate the citation of the
items (e.g. no changes in pagination of any bitstreams). This can be
used as a special feature to manually track metadata changes. In this
case administrators might want to show only the newest version publicly
and hide older versions.

Another way to use a versioning feature is to create new versions of an
item which may even change existing citations. The old versions should
be kept with there former handles so that citing a handle with a page
number still results in the same citation. A newer version should get a
new handle.

This commit introduces a VersionedHandleIdentifierProvider that does not
change the link between a handle and an item. A new version of an item
gets a new handle. This behaviour ensures that every version is always
citable even if a newer version will be release at any time.
2016-04-07 15:29:49 +02:00
Pascal-Nicolas Becker
0e34ed8d9d DS-1348: Rename the current VersionedHandleIdentifierProvider.
The current VersionedHandleIdentifierProvider introduced "canonical
handles". The idea is to keep the current handle always linked to the
newest version of an item. The downside is that this limits the
versioning to version changes that do not derogate the citation of an
item (e.g. no changes in pagination of any bitstreams). This can be
used as a special feature to manually track metadata changes. In this
case administrators might want to show only the newest version publicly
and hide older versions.

Another way to use a versioning feature is to create new versions of an
item which may even change existing citations. The older versions should
be kept with there former handles so that citing a handle with a page
number still results in the same citation. A newer version should get a
new handle.

This commit just moves the old VersionedHandleIdentifierProvider to a
new class so it still can be used if necessary. A new
VersionedHandleIdentifierProvider will be provided within the next
commit.
2016-04-07 15:29:49 +02:00
Kevin Van de Velde
85e096c4a9 Merge pull request #1268 from sedici/DS-2987
DS-2987 Solved metadata loss by qualdrop fields in DescribeStep
2016-04-07 12:34:22 +02:00
Mark H. Wood
4545c76859 Merge pull request #1015 from rradillen/DS-2702
DS-2702 set mail.extraproperties before obtaining session

Considering the +1 in the Jira ticket, this is at +2.
2016-04-06 12:34:00 -04:00
Tim Donohue
a6baf000f2 Merge pull request #1241 from jmarton/DS-2633
[DS-2633] Fix NPE during SAF format import with collection files
2016-04-06 10:54:26 -05:00
Tim Donohue
091c5a7398 Merge pull request #1252 from KevinVdV/DS-2995-jspui-community-breadcrumb-trail
[DS-2995] Wrong order in breadcrumb trail in collection display and item display
2016-04-06 10:50:41 -05:00