- setAllValuesOfRest() SQLException now meaningful message
- metadataConverter never used, so removed
- id comparison check flipped so no NullPointer when no id in json in body,
but meaningful message
POST /api/core/bitstreamformats
PUT /api/core/bitstreamformats/<:id>
DELETE /api/core/bitstreamformats/<:id>
Signed-off-by: Marie Verdonck <maria.verdonck@atmire.com>
Squashed commit of the following:
commit d65609c
Author: Ben Bosman <ben@atmire.com>
Date: Thu May 30 11:18:46 2019 +0200
travis build fixes
commit 62aeb94
Author: Ben Bosman <ben@atmire.com>
Date: Thu May 30 10:53:48 2019 +0200
license broken
commit 1d2e2ed
Author: Ben Bosman <ben@atmire.com>
Date: Thu May 30 10:33:54 2019 +0200
update comments
commit 552005f
Author: Ben Bosman <ben@atmire.com>
Date: Thu May 30 10:22:31 2019 +0200
removed unnecessary method
commit af149e7
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date: Wed May 29 17:47:27 2019 +0200
Reduced complexity in relationship rest controller & tests (PUT)
- No need for id integer check, pathvariable expects only integers
- Tests added for exception cases:
> Invalid relationship id (non-existent) > 404 - Not found
> Invalid item id in body > 422 - Unprocesseable
- Test verification andExpect() more efficient
commit 3c37d20
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date: Wed May 29 10:43:19 2019 +0200
Tests for the endpoints: PUT /api/core/relationships/:id/leftItem
PUT /api/core/relationships/:id/rightItem
commit a58c611
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date: Tue May 28 10:18:19 2019 +0200
Back to original isAllowedToModify method; regex for relationship id in mapping &
- No need to check for leftItem=rightItem, is allowed
- No need to check if relationship already exists, DB will prevent duplicates
commit 2424c5c
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date: Mon May 27 13:53:50 2019 +0200
Changes in the PUT on relationships, new endpoints:
- PUT /api/core/relationships/:id/leftItem
- PUT /api/core/relationships/:id/rightItem
> 403 Forbidden - if not enough write rights (see below)
> 422 Unprocesseable Entity - if relationship id NaN or invalid item in body
> 404 Resource Not Found if - relationship with given id not found
Needed permissions:
Replace left: right.WRITE OR (left.WRITE AND old-left.WRITE)
Replace right: left.WRITE OR (right.WRITE AND old-right.WRITE)
commit d65609c66e4dd54c5a8af2fc18d952c958c0f69b
Author: Ben Bosman <ben@atmire.com>
Date: Thu May 30 11:18:46 2019 +0200
travis build fixes
commit 62aeb9463d9c74070540ad1eb247bb539dae8cf9
Author: Ben Bosman <ben@atmire.com>
Date: Thu May 30 10:53:48 2019 +0200
license broken
commit 1d2e2edb085433f79aa2abe58cdc4d4065dbfc81
Author: Ben Bosman <ben@atmire.com>
Date: Thu May 30 10:33:54 2019 +0200
update comments
commit 552005fc2f1c912220d0f62e94c3045e9f772be2
Author: Ben Bosman <ben@atmire.com>
Date: Thu May 30 10:22:31 2019 +0200
removed unnecessary method
commit af149e7871f30e4bc17f7eeccf8655fe9d80cdf7
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date: Wed May 29 17:47:27 2019 +0200
Reduced complexity in relationship rest controller & tests (PUT)
- No need for id integer check, pathvariable expects only integers
- Tests added for exception cases:
> Invalid relationship id (non-existent) > 404 - Not found
> Invalid item id in body > 422 - Unprocesseable
- Test verification andExpect() more efficient
commit 3c37d208cbe609f5182470ce8302ec25de00939f
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date: Wed May 29 10:43:19 2019 +0200
Tests for the endpoints: PUT /api/core/relationships/:id/leftItem
PUT /api/core/relationships/:id/rightItem
commit a58c611ad7a648b28933fb39840866def42384e6
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date: Tue May 28 10:18:19 2019 +0200
Back to original isAllowedToModify method; regex for relationship id in mapping &
- No need to check for leftItem=rightItem, is allowed
- No need to check if relationship already exists, DB will prevent duplicates
commit 2424c5c71b63122263aec08e110cf7bb4b19cc5d
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date: Mon May 27 13:53:50 2019 +0200
Changes in the PUT on relationships, new endpoints:
- PUT /api/core/relationships/:id/leftItem
- PUT /api/core/relationships/:id/rightItem
> 403 Forbidden - if not enough write rights (see below)
> 422 Unprocesseable Entity - if relationship id NaN or invalid item in body
> 404 Resource Not Found if - relationship with given id not found
Needed permissions:
Replace left: right.WRITE OR (left.WRITE AND old-left.WRITE)
Replace right: left.WRITE OR (right.WRITE AND old-right.WRITE)
Signed-off-by: Marie Verdonck <maria.verdonck@atmire.com>
POST /api/core/bitstreamformats
PUT /api/core/bitstreamformats/<:id>
DELETE /api/core/bitstreamformats/<:id>
Signed-off-by: Marie Verdonck <maria.verdonck@atmire.com>
