Commit Graph

6472 Commits

Author SHA1 Message Date
Tim Donohue
bf8df5b1e8 Merge pull request #8758 from alexandrevryghem/w2p-100553_fix-metadata-registry-bugs_contribute-7.4
Added input validation for new metadata field submissions & fixed some other bugs related to metadata fields
2023-06-06 14:33:38 -05:00
Tim Donohue
a0a1844de7 Fix test class compilation 2023-06-05 16:01:31 -05:00
Tim Donohue
333c7da729 Merge pull request #8623 from atmire/discovery-fixes
Fixes for scope based searching and indexing in Discovery
2023-06-05 15:37:21 -05:00
Tim Donohue
58c71bbeab Merge pull request #8485 from atmire/w2p-94299_Multiple_Bitstream_deletion_endpoint
multiple bitstream deletion endpoint
2023-06-05 15:35:45 -05:00
Tim Donohue
61db65ead5 Merge pull request #8826 from atmire/contract-pr-225-browse-by-support-for-controlled-vocabulary-main
Browse by Controlled Vocabulary (hierarchicalBrowse)
2023-06-05 15:31:37 -05:00
Tim Donohue
6013c41184 Merge pull request #8870 from TexasDigitalLibrary/DS-8759
DS-8759: check that zip file exists and has correct MIME type; clean up imports directory on failed import
2023-06-02 16:59:21 -05:00
Tim Donohue
4d5e907617 Merge pull request #8856 from kshepherd/item_delete_unlink_doi
Unlink DOI from item on deletion even if no provider is configured
2023-06-02 16:26:29 -05:00
Paulo Graça
39283650d0 Merge branch 'main' into DS-8837 2023-06-02 15:44:46 +01:00
Paulo Graça
99f2c7c134 Merge branch 'main' into DS-8837 2023-06-02 09:21:51 +01:00
Francesco Pio Scognamiglio
52b02b5d36 Merge branch 'main' into DURACOM-149 2023-06-02 10:11:21 +02:00
Bui Thai Hai
70a7930f63 Tweaks fo test cases. 2023-06-02 09:45:52 +07:00
Tim Donohue
379db2a166 Merge pull request #8860 from 4Science/DURACOM-127
[DURACOM-127] check if versioning is enabled for versioned identifier providers
2023-06-01 12:01:49 -05:00
Giuseppe Digilio
cdac4c4459 Merge branch 'main' into DURACOM-126 2023-06-01 17:53:59 +02:00
Francesco Pio Scognamiglio
4e7107f63c Merge branch 'main' into DURACOM-149 2023-06-01 15:12:08 +02:00
Francesco Pio Scognamiglio
0ec27875bc [DURACOM-149] use right formatter for mapping of dc.date.issued in pubmed live import; added integration tests 2023-06-01 15:10:59 +02:00
Giuseppe Digilio
dae8f166e1 [DURACOM-126] add java doc 2023-06-01 14:48:46 +02:00
Giuseppe Digilio
56c8820d31 [DURACOM-126] Improve test in order to check item can be submitted 2023-06-01 14:41:58 +02:00
Tim Donohue
894bc39e8b Merge pull request #8698 from mwoodiupui/embargo-date
Calculate the correct maximum for access condition start and end dates
2023-05-31 11:53:46 -05:00
Tim Donohue
cac0859cb1 Merge pull request #8850 from alanorth/rework-im-thumbnail-filter
Minor improvements to ImageMagick thumbnail filters
2023-05-31 11:03:40 -05:00
nwoodward
fdef871e69 fix checkstyle 2023-05-26 15:41:14 -05:00
nwoodward
e889abc623 check that zip file exists and has correct MIME type; also make sure that common temp imports directory is not removed 2023-05-26 15:41:14 -05:00
Francesco Pio Scognamiglio
78f91b096b Merge branch 'main' into DURACOM-127 2023-05-26 09:24:17 +02:00
Giuseppe Digilio
f750f85b17 Merge remote-tracking branch 'origin/main' into DURACOM-126 2023-05-25 14:48:24 +02:00
Bui Thai Hai
eb46a99dff Fix: default sort option (lastModified) for discovery 2023-05-25 10:21:44 +07:00
Mark H. Wood
571df9b38a Add a simple test for new TimeHelpers class. 2023-05-24 15:56:03 -04:00
Tim Donohue
c0446d45dc Merge pull request #8783 from kshepherd/LU-30_bitstream_inheritence
Bitstreams should inherit collection DEFAULT_BITSTREAM_READ, falling back to bundle READ
2023-05-24 11:29:43 -05:00
Francesco Pio Scognamiglio
4417eddb85 Merge branch 'main' into DURACOM-127 2023-05-24 15:43:14 +02:00
Francesco Pio Scognamiglio
8980b07f2b [DURACOM-148] fix typo: remove trailing whitespace 2023-05-23 08:51:07 +02:00
Alan Orth
5357923d28 dspace-api: avoid generation loss in ImageMagickThumbnailFilter
When filtering PDF bitstreams, the ImageMagickThumbnailFilter first
creates an intermediate JPEG and then a "thumbnail" JPEG. These two
operations are both lossy. The ImageMagick usage guide warns against
doing that:

> JPEG losses (sic) information, degrading images when saved.
> Use some other format for intermediate images during processing.
> Only use JPEG format, for the final image, not for further processing.

As our current filter architecture requires writing a temporary file
we must choose one of the following lossless formats to use for the
intermediate: PNG, TIFF, or MIFF. MIFF is ImageMagick's own internal
format and is much faster to write than PNG.

By eliminating the first lossy conversion we gain 1.1% points on the
ssimulacra2 (v2.1) scoring scale of visual quality.

See: https://imagemagick.org/Usage/formats/#jpg
2023-05-22 18:36:11 +03:00
Alan Orth
7ebb5290fc dspace-api: comment ImageMagick filters
Add some comments to document the functionality of the ImageMagick
thumbnail filters. This will help others understand it later when
we need to re-factor them.
2023-05-22 18:36:11 +03:00
Alan Orth
a4105bdcb0 dspace-api: simplify logic in ImageMagickThumbnailFilter
There is no point passing a page parameter here, with a default of
0 no less, because we will *always* use the first page of the PDF
to generate the thumbnail. No other filters use this function and
the page parameter is not configurable so we should just hard code
it.
2023-05-22 18:36:11 +03:00
Alan Orth
7dbfa9a3c5 dspace-api: minor logging fix in ImageMagickThumbnailFilter
Minor standardization to logging (unneccessary capitalization and
excessive spaces).
2023-05-22 18:36:11 +03:00
Alan Orth
c37622cb3f dspace-api: improve logging in ImageMagickThumbnailFilter
Instead of logging the name of the source bitstream, we should be
logging the name of the actual thumbnail bitstream that is being
considered for replacement. For example, instead of this:

  IM Thumbnail manual.pdf matches pattern and is replaceable.

... the message should read:

  IM Thumbnail manual.pdf.jpg matches pattern and is replaceable.

This message is already confusing enough, but this will help.
2023-05-22 18:36:11 +03:00
Alan Orth
7ab5f3b489 dspace-api: fix typo in ImageMagickThumbnailFilter 2023-05-22 18:36:11 +03:00
Francesco Pio Scognamiglio
cbfed3e218 [DURACOM-148] add crossref metadata processor to manage the date issued field 2023-05-22 15:44:52 +02:00
Francesco Pio Scognamiglio
8ddf4702af [DURACOM-127] check if versioning is enabled for versioned identifier providers 2023-05-22 11:53:03 +02:00
Kim Shepherd
208cac08d5 modifying unit tests as per CI feedback, stubbings now unnecessary 2023-05-21 15:43:26 +12:00
Kim Shepherd
2ef268380f Unlink DOI from item on deletion even if no provider is configured 2023-05-21 15:43:26 +12:00
kshepherd
6fd31622ae Merge pull request #8752 from amgciadev/fix-8732-b
Fix for #8732 and #8750
2023-05-20 10:26:45 +12:00
Tim Donohue
95ad0ba927 Merge pull request #8822 from tdonohue/remove_oracle
Remove Oracle Support
2023-05-18 16:43:38 -05:00
Tim Donohue
d5ac263743 Merge pull request #8795 from arvoConsultores/DS-8636
#8636 Request a Copy's "helpdesk" strategy requires authentication t…
2023-05-17 16:46:42 -05:00
Tim Donohue
d3c03efe61 Merge pull request #8799 from uofmsean/fix-8490-preferred-label-lookup
Fix #8490 preferred label lookup
2023-05-16 16:53:37 -05:00
Tim Donohue
c0e62657f6 Merge pull request #8789 from amtuannguyen/main
properly escape ':' in query to address #8490
2023-05-16 16:51:25 -05:00
Agustina Martinez
95af5fff41 VersionedDOIIdentifierProvider: add non-fatal check that dso is of type Item 2023-05-15 08:40:57 +01:00
Agustina Martinez
f844ca347b Improved fix: override missing register method in VersionedDOIIdentifierProvider 2023-05-12 13:24:28 +01:00
Agustina Martinez
1d355b7ed0 Merge branch 'DSpace:main' into fix-8732-b 2023-05-12 13:06:27 +01:00
Jens Vannerum
81f1eab2ed Merge remote-tracking branch 'DSpace_github/main' into w2p-94299_Multiple_Bitstream_deletion_endpoint
# Conflicts:
#	dspace-api/src/main/resources/Messages.properties
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/exception/DSpaceApiExceptionControllerAdvice.java
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/BitstreamRestRepositoryIT.java
2023-05-12 09:41:04 +02:00
Kim Shepherd
6943399938 #8783 checkstyle fixes 2023-05-12 18:03:02 +12:00
Kim Shepherd
b69517da74 #8783 don't inherit DEFAULT_BITSTREAM_READ if item has current embargo 2023-05-12 17:48:27 +12:00
Kim Shepherd
4a88573dc1 #8783 Strip out unused generateAutomaticPolicies method from AuthorizeService 2023-05-12 17:48:27 +12:00