Commit Graph

6761 Commits

Author SHA1 Message Date
Graham Triggs
0586738551 [DS-707] Bad practice fixes
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5651 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-26 15:33:23 +00:00
Graham Triggs
8c8adbe7d5 [DS-707] Performance improvement (and avoids potential infinite loop)
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5650 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-26 15:24:18 +00:00
Graham Triggs
d0a010807a [DS-707] Malicious code vulnerabilities
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5647 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-26 11:31:44 +00:00
Graham Triggs
047c315ce3 [DS-707] Malicious code vulnerabilities
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5645 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-26 10:42:55 +00:00
Graham Triggs
a35bf6ca6c [DS-707] Multithreaded correctness
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5644 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-26 10:20:33 +00:00
Graham Triggs
0cf92c1cf3 [DS-707] Malicious code vulnerabilities
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5643 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-26 09:48:15 +00:00
Graham Triggs
1d9d92c619 [DS-707] Stream clean up
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5641 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-26 09:01:47 +00:00
Graham Triggs
a95a254bd2 [DS-707] Stream clean up
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5640 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-26 00:30:50 +00:00
Graham Triggs
010631fd59 [DS-707] Remove generic restriction on hasNamedPlugin
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5639 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-26 00:01:31 +00:00
Graham Triggs
47a6a93a92 [DS-707] Static field access
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5638 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-25 16:59:13 +00:00
Graham Triggs
f0515e4b34 [DS-707] Constructor calling overridable method
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5636 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-25 15:14:46 +00:00
Graham Triggs
d0e296d630 [DS-707] Multithreaded Correctness
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5635 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-25 13:23:08 +00:00
Graham Triggs
5fb2212272 [DS-707] Correctness
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5634 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-25 13:06:34 +00:00
Graham Triggs
5fa0e9deae [DS-707] Correctness
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5633 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-25 12:57:45 +00:00
Graham Triggs
c64399459f [DS-707] Malicious code vulnerabilities
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5632 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-25 12:19:30 +00:00
Graham Triggs
da1f84750e [DS-707] Mailicious code vulnerabilities
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5630 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-25 11:41:25 +00:00
Graham Triggs
a730720857 [DS-707] Null pointer dereferences
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5629 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-25 10:21:38 +00:00
Graham Triggs
89e4d12e3d [DS-707] Unnecessary cast
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5628 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-25 06:53:55 +00:00
Graham Triggs
341fb452e8 [DS-707] Make constants final
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5627 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 23:52:50 +00:00
Graham Triggs
c3083acce9 [DS-707] JLS modifier order
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5626 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 23:41:08 +00:00
Graham Triggs
e5cc6f3adc [DS-707] Security fixes
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5625 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 23:21:21 +00:00
Graham Triggs
7f5088d4df [DS-707] Convert unnecessary fields to local variables
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5624 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 22:27:20 +00:00
Graham Triggs
f5d84954b7 [DS-707] Unused imports
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5623 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 22:24:42 +00:00
Graham Triggs
60180f9f23 [DS-707] Simplify expressions
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5622 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 22:14:43 +00:00
Graham Triggs
fc8727aa25 [DS-707] Loose coupling
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5620 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 21:53:54 +00:00
Graham Triggs
16e0851ef8 [DS-707] Remove unused imports / fields / private methods
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5618 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 21:22:32 +00:00
Graham Triggs
9fd9b94e26 [DS-707] Generify Map usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5615 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 20:41:34 +00:00
Graham Triggs
04d805020c [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5612 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 19:57:06 +00:00
Graham Triggs
0d126a6287 [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5611 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 19:43:28 +00:00
Graham Triggs
135da8769a [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5610 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 19:25:15 +00:00
Graham Triggs
8fe16d07db [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5609 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 18:46:38 +00:00
Graham Triggs
24c98d7ff3 [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5608 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 18:41:53 +00:00
Graham Triggs
094286fa87 [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5605 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 18:03:22 +00:00
Graham Triggs
2b36940850 [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5604 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 17:58:42 +00:00
Graham Triggs
f358b56ebf [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5603 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 17:45:58 +00:00
Graham Triggs
aa4a35650c [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5602 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 17:37:57 +00:00
Graham Triggs
77e834038b [DS-707] Generify List usage
NB: There is a potential issue in the obtaining of list values - where the authority code was added, it changed a List of Strings to a List of String arrays ( the value, and the authority). Some of the code that used these methods did not take into account that there was a String[] and would have thrown a classcastexception.

This has now been accounted for, but in doing so, it ignores the authority value component of the array. We need to consider if this needs to be updated, or possibly if that method should just be removed (doesn't appear to be used)

git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5601 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 16:47:20 +00:00
Graham Triggs
f552805a50 [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5600 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 16:12:57 +00:00
Graham Triggs
7296ad119d [DS-707] Generify List usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5599 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 16:09:10 +00:00
Graham Triggs
3d6172b14f [DS-707] Generify Map usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5596 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 15:39:21 +00:00
Graham Triggs
03e1e7e9e6 [DS-707] Generify Map usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5595 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 15:35:49 +00:00
Graham Triggs
82e563e0f6 [DS-707] Generify Map usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5594 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 15:23:47 +00:00
Graham Triggs
2bae1a053c [DS-707] Generify Map usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5593 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 15:15:11 +00:00
Graham Triggs
28a338effc [DS-707] Generify Map usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5592 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 15:08:44 +00:00
Graham Triggs
c89dd45f7a [DS-707] Generify Map usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5591 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 15:04:41 +00:00
Graham Triggs
fe60b7cc79 [DS-707] Generify Map usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5590 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 14:59:49 +00:00
Graham Triggs
90025e961b [DS-707] Generify Map usage
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5589 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 14:50:46 +00:00
Graham Triggs
df7e3af37b [DS-707] Closing streams
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5588 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 14:18:31 +00:00
Graham Triggs
d838dc9069 [DS-707] Checking for exceptional conditions
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5587 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 14:09:30 +00:00
Graham Triggs
3dff1180db [DS-707] String comparison correctness
git-svn-id: http://scm.dspace.org/svn/repo/dspace/trunk@5584 9c30dcfa-912a-0410-8fc2-9e0234be79fd
2010-10-24 11:19:51 +00:00