hazza/DSpace
1
0
Fork 0
mirror of https://github.com/DSpace/DSpace.git synced 2025-10-09 19:13:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
17,370 Commits 32 Branches 125 Tags
c6075b51a06e8dcaca49232dada53e2365e40e27
Commit Graph

6761 Commits

Author SHA1 Message Date
Mohamed Saber Eskander
bfbf17f577 - refactoring and adding new test cases 
- update resource polices of derivative bitstreams also
- check authorization when run script
- added some log information
 2023-05-31 12:33:56 +03:00
NikitaKr1vonosov
3ee18f5a6e Merge branch 'main' into CST-5728 2023-05-29 13:05:46 +02:00
Nikita Krivonosov
3ba6db388b Merge remote-tracking branch 'origin/CST-5728' into CST-5728 2023-05-29 12:42:39 +02:00
Nikita Krivonosov
d0d6776810 [CST-5728] LYRASIS [Donated]: DSpace7: Implement signposting pattern in DSpace (REST) 2023-05-29 09:56:07 +02:00
nwoodward
fdef871e69 fix checkstyle 2023-05-26 15:41:14 -05:00
nwoodward
e889abc623 check that zip file exists and has correct MIME type; also make sure that common temp imports directory is not removed 2023-05-26 15:41:14 -05:00
Francesco Pio Scognamiglio
78f91b096b Merge branch 'main' into DURACOM-127 2023-05-26 09:24:17 +02:00
Giuseppe Digilio
ec3cc2dcf1 Merge branch 'main' into duracom-136_CST-9634 2023-05-25 15:49:41 +02:00
Giuseppe Digilio
f750f85b17 Merge remote-tracking branch 'origin/main' into DURACOM-126 2023-05-25 14:48:24 +02:00
Paulo Graça
111b2e4a6a Merge branch 'main' into enhancement/addressing-#8633 2023-05-25 09:42:31 +01:00
Bui Thai Hai
eb46a99dff Fix: default sort option (lastModified) for discovery 2023-05-25 10:21:44 +07:00
Mark H. Wood
571df9b38a Add a simple test for new TimeHelpers class. 2023-05-24 15:56:03 -04:00
Tim Donohue
c0446d45dc Merge pull request #8783 from kshepherd/LU-30_bitstream_inheritence 
Bitstreams should inherit collection DEFAULT_BITSTREAM_READ, falling back to bundle READ
 2023-05-24 11:29:43 -05:00
Francesco Pio Scognamiglio
4417eddb85 Merge branch 'main' into DURACOM-127 2023-05-24 15:43:14 +02:00
Paulo Graça
2ca723d687 Merge branch 'main' into enhancement/addressing-#8633 2023-05-24 09:36:16 +01:00
Francesco Pio Scognamiglio
8980b07f2b [DURACOM-148] fix typo: remove trailing whitespace 2023-05-23 08:51:07 +02:00
Alan Orth
5357923d28 dspace-api: avoid generation loss in ImageMagickThumbnailFilter 
When filtering PDF bitstreams, the ImageMagickThumbnailFilter first
creates an intermediate JPEG and then a "thumbnail" JPEG. These two
operations are both lossy. The ImageMagick usage guide warns against
doing that:

> JPEG losses (sic) information, degrading images when saved.
> Use some other format for intermediate images during processing.
> Only use JPEG format, for the final image, not for further processing.

As our current filter architecture requires writing a temporary file
we must choose one of the following lossless formats to use for the
intermediate: PNG, TIFF, or MIFF. MIFF is ImageMagick's own internal
format and is much faster to write than PNG.

By eliminating the first lossy conversion we gain 1.1% points on the
ssimulacra2 (v2.1) scoring scale of visual quality.

See: https://imagemagick.org/Usage/formats/#jpg
 2023-05-22 18:36:11 +03:00
Alan Orth
7ebb5290fc dspace-api: comment ImageMagick filters 
Add some comments to document the functionality of the ImageMagick
thumbnail filters. This will help others understand it later when
we need to re-factor them.
 2023-05-22 18:36:11 +03:00
Alan Orth
a4105bdcb0 dspace-api: simplify logic in ImageMagickThumbnailFilter 
There is no point passing a page parameter here, with a default of
0 no less, because we will *always* use the first page of the PDF
to generate the thumbnail. No other filters use this function and
the page parameter is not configurable so we should just hard code
it.
 2023-05-22 18:36:11 +03:00
Alan Orth
7dbfa9a3c5 dspace-api: minor logging fix in ImageMagickThumbnailFilter 
Minor standardization to logging (unneccessary capitalization and
excessive spaces).
 2023-05-22 18:36:11 +03:00
Alan Orth
c37622cb3f dspace-api: improve logging in ImageMagickThumbnailFilter 
Instead of logging the name of the source bitstream, we should be
logging the name of the actual thumbnail bitstream that is being
considered for replacement. For example, instead of this:

  IM Thumbnail manual.pdf matches pattern and is replaceable.

... the message should read:

  IM Thumbnail manual.pdf.jpg matches pattern and is replaceable.

This message is already confusing enough, but this will help.
 2023-05-22 18:36:11 +03:00
Alan Orth
7ab5f3b489 dspace-api: fix typo in ImageMagickThumbnailFilter 2023-05-22 18:36:11 +03:00
Francesco Pio Scognamiglio
cbfed3e218 [DURACOM-148] add crossref metadata processor to manage the date issued field 2023-05-22 15:44:52 +02:00
Paulo Graça
fc2589464f checkstyle violations fixing and remove unnecessary max rows limit 2023-05-22 12:57:56 +01:00
Francesco Pio Scognamiglio
8ddf4702af [DURACOM-127] check if versioning is enabled for versioned identifier providers 2023-05-22 11:53:03 +02:00
Paulo Graça
2b3af3a126 checkstyle violations fixing 2023-05-22 08:42:33 +01:00
Kim Shepherd
208cac08d5 modifying unit tests as per CI feedback, stubbings now unnecessary 2023-05-21 15:43:26 +12:00
Kim Shepherd
2ef268380f Unlink DOI from item on deletion even if no provider is configured 2023-05-21 15:43:26 +12:00
Paulo Graça
6fa9e74d90 checkstyle violations fixing 2023-05-20 11:35:27 +01:00
Paulo Graça
687b6216df checkstyle violations fixing 2023-05-20 10:41:51 +01:00
Paulo Graça
32b2b7dacb Merge branch 'main' of github.com:dspace/dspace into enhancement/addressing-#8633 2023-05-20 08:07:29 +01:00
Paulo Graça
0409373b61 handling exceptions 2023-05-20 08:07:05 +01:00
kshepherd
6fd31622ae Merge pull request #8752 from amgciadev/fix-8732-b 
Fix for #8732 and #8750
 2023-05-20 10:26:45 +12:00
Paulo Graça
d7d7f7c370 support for entity type for collection at input submissions 2023-05-19 22:44:07 +01:00
NikitaKr1vonosov
9e2b4a1acf Merge branch 'main' into CST-5728 2023-05-19 13:01:38 +02:00
Tim Donohue
95ad0ba927 Merge pull request #8822 from tdonohue/remove_oracle 
Remove Oracle Support
 2023-05-18 16:43:38 -05:00
Mark H. Wood
4c00e13b52 Merge branch 'main' into reqitem-response 2023-05-18 08:29:39 -04:00
Tim Donohue
d5ac263743 Merge pull request #8795 from arvoConsultores/DS-8636 
#8636 Request a Copy's "helpdesk" strategy requires authentication t…
 2023-05-17 16:46:42 -05:00
Tim Donohue
d3c03efe61 Merge pull request #8799 from uofmsean/fix-8490-preferred-label-lookup 
Fix #8490 preferred label lookup
 2023-05-16 16:53:37 -05:00
Tim Donohue
c0e62657f6 Merge pull request #8789 from amtuannguyen/main 
properly escape ':' in query to address #8490
 2023-05-16 16:51:25 -05:00
Alexandre Vryghem
3ab0c812a6 Merge remote-tracking branch 'upstream/main' into issue-1671_fix-relationships-not-updating-view-on-submission-form_contribute-main 2023-05-16 12:09:40 +02:00
Agustina Martinez
95af5fff41 VersionedDOIIdentifierProvider: add non-fatal check that dso is of type Item 2023-05-15 08:40:57 +01:00
samuel
f49b6f24ba 99221: Fix minor issues with Relationships in submission - repair relationship error 2023-05-12 15:25:02 +02:00
samuel
2e69ba7f63 96598: Test feedback pt. 3: submission - repair auto-refresh 2023-05-12 15:24:58 +02:00
Mohamed Saber Eskander
07fbe15126 refactoring and added new IT class 2023-05-12 15:35:22 +03:00
Agustina Martinez
f844ca347b Improved fix: override missing register method in VersionedDOIIdentifierProvider 2023-05-12 13:24:28 +01:00
Agustina Martinez
1d355b7ed0 Merge branch 'DSpace:main' into fix-8732-b 2023-05-12 13:06:27 +01:00
damian
1cc6fb2f58 Item counters refactor. Removing unnecessary code. 2023-05-12 12:29:22 +02:00
eskander
27f874a08b refactoring and adding new test cases 2023-05-12 10:58:17 +03:00
Jens Vannerum
81f1eab2ed Merge remote-tracking branch 'DSpace_github/main' into w2p-94299_Multiple_Bitstream_deletion_endpoint 
# Conflicts:
#	dspace-api/src/main/resources/Messages.properties
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/exception/DSpaceApiExceptionControllerAdvice.java
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/BitstreamRestRepositoryIT.java
 2023-05-12 09:41:04 +02:00