Commit Graph

3385 Commits

Author SHA1 Message Date
Tim Donohue
4240ade8ca Merge pull request #2594 from atmire/w2p-66396_bug-in-get-collections
Bug in GET collections
2019-11-21 15:16:53 -06:00
Tim Donohue
abf6a36fe3 Merge pull request #2529 from atmire/w2p-64334_scripts-prototype
Scripts and processes endpoint
2019-11-21 15:06:35 -06:00
Tim Donohue
ecfdc2b627 Merge pull request #2548 from atmire/DS-4317_bundles-in-REST
Ds 4317 bundles in rest
2019-11-21 14:51:56 -06:00
Raf Ponsaerts
9733bd3441 Merged master into this branch and fixed tests/issues with metadata-import 2019-11-21 15:19:05 +01:00
Raf Ponsaerts
08c7da4446 Implementing file import and export scripts 2019-11-21 13:22:09 +01:00
Marie Verdonck
6f822dbb98 DS-4317 - bundles in REST: Redefined RequestMapping to use constants defined in Rest classes 2019-11-21 12:10:15 +01:00
Marie Verdonck
7148f7cd0b DS-4317 - bundles in REST: Redefining RequestMapping of Controllers to be unique and to use constants defined in Rest classes 2019-11-21 11:43:11 +01:00
Raf Ponsaerts
9e6fe1c9a2 [Task 66396] added a test that proves that the collection endpoint returns the same collection multiple times if it has different language fields for dc.title 2019-11-21 10:12:33 +01:00
Peter Nijs
ebd6ee73fb 65257: fix typo in error message 2019-11-21 09:56:28 +01:00
Raf Ponsaerts
0ea677914f Refactored the naming and the request mapping of the Scripts Controller to be less ambiguous and less confusing 2019-11-21 09:26:24 +01:00
Tim Donohue
d99ccc6bfc Merge pull request #2551 from atmire/w2p-65568_bugs-place-management-creating-relationships
Entities bug-fixes in place management
2019-11-20 09:07:31 -06:00
Kevin Van de Velde
78da4b53fc Merge remote-tracking branch 'upstream/master' into DS-4389-improving-patch-system-framework 2019-11-20 16:02:12 +01:00
Raf Ponsaerts
623451dd3e [Task 66408] applied community feedback to the Relationship Delete methods 2019-11-20 14:19:54 +01:00
Kevin Van de Velde
6daad55762 Patch refactor: The supports method now accepts an object instead of a DSpaceObject, else other objects aren't supported for these patches. Also adding missing @Override annotations 2019-11-20 14:16:03 +01:00
Tim Donohue
41fa29e5b0 Merge pull request #2585 from atmire/DS-4386_nullpointer-exception-item-put-endpoint-authenticated-user
[DS-4386] fixed the nullpointer issue when an authenticated non-admin…
2019-11-19 15:59:28 -06:00
Tim Donohue
09646aabde Merge pull request #2589 from atmire/search-relationships-total-fix
Entities: Search relationships total fix
2019-11-19 15:54:32 -06:00
Chris Wilper
0a36fc13f1 DS-3533 Make MetadataConverter a DSpaceCoverter, supporting projections 2019-11-19 12:45:09 -05:00
Tim Donohue
64702f5745 Merge pull request #2561 from atmire/w2p-65570_Configuring-whether-name-variants-should-be-used
Entities: configuring whether name variants should be used
2019-11-19 09:23:14 -06:00
Ben Bosman
864ea1d591 fixing total calculation 2019-11-19 11:31:57 +01:00
Ben Bosman
4415ea2237 whitespace 2019-11-19 10:56:16 +01:00
Ben Bosman
7109a357ed IT for fixing total calculation 2019-11-19 09:55:39 +01:00
Ben Bosman
02df6154e4 fixing total calculation 2019-11-19 09:47:56 +01:00
Raf Ponsaerts
3dfa695dbf [DS-4386] added a context.restoreAuthSystemState to the update test 2019-11-19 09:41:23 +01:00
Marie Verdonck
1deb82f0e3 66183: feedback processed:
- Split DSOMetadataOperation in separate operation classed
- supports() also checks operation.getOp()
- ResourcePatchOperation removed
- removed some unneeded null checks
- DspaceObjectMetadataOperation.performPatchOperation() exceptions thrown without changes
- All services autowired, not via factories
2019-11-18 14:05:27 +01:00
Raf Ponsaerts
2b97950b4c [DS-4386] fixed the nullpointer issue when an authenticated non-admin user tries to update an item using the Item PUT endpoint 2019-11-15 11:35:17 +01:00
Marie Verdonck
454745b91a Merge branch 'master' into DS-4317_bundles-in-REST
# Conflicts:
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/BitstreamRestRepository.java
2019-11-14 18:37:30 +01:00
Chris Wilper
18ea0a2434 DS-3533 Add projection-related tests, resolve minor functional issues, and improve javadocs 2019-11-14 09:32:40 -05:00
Peter Nijs
6e56c8bad1 65956: Cleanup and preauthorize fix for CRUD on Collection Item template 2019-11-14 15:25:34 +01:00
Marie Verdonck
69327477a7 Bundles in REST: Feedback implemented:
- Renaming: BundleController > BundleUploadBitstreamController, ItemController > ItemAddBundleController
 - Moved: BitstreamRestController#getBundle() & #move() to new BitstreamBundleController class
 - Javadocs added to all three
 - Correction @RequestMapping of BundleUploadBitstreamController
2019-11-14 15:24:52 +01:00
Raf Ponsaerts
fcd6429ec0 [Task 66086] implemented a configuration on the RelationshipType object to determine whether metadata should be copied left or right or not at all when deleting a relationship 2019-11-14 11:18:47 +01:00
Michael W Spalti
b6849e51a6 Fixing tests for travis (currently unable to test on local machine) 2019-11-13 17:33:25 -08:00
Michael W Spalti
2113317946 [DS-3906] REST endpoint for discovering withdrawn and private items. 2019-11-13 16:35:49 -08:00
Marie Verdonck
ac57139d10 66075: Improvements from feedback:
- DspaceObjectMetadataOperation.performPatchOperation()
  > Logic split into seperate methods
- DspaceObjectMetadataOperation.replace()
  > Split into method per case
2019-11-13 19:01:18 +01:00
Raf Ponsaerts
4c1f4e422c [Task 66031] wrote javadocs or ProcessRestPermissionEvaluatorPlugin, cleaned up ProcessRestRepository 2019-11-13 14:13:42 +01:00
Marie Verdonck
57c23f3e82 66075: added back existingValue checks to non-boolean replace operations,
the set functionality should be in an ADDoperation (not yet implemented)
- EPersonCertificateReplaceOperation, EPersonLoginReplaceOperation, ItemDiscoverableReplaceOperation, ItemWithdrawReplaceOperation
    > Check for existing not required since boolean type value
- EPersonEmailReplaceOperation
    > added back null-check in checkModelForExistingValue
- EPersonPasswordReplaceOperation
    > added checkModelForExistingValue which checks if ePersonService has non-null pw hash, because getPassword is protected

- Test added for password replace with no existing pw
2019-11-13 12:40:51 +01:00
Marie Verdonck
505daf5bbb 66075: Feedback improvements 2:
DspaceObjectMetadataOperation
 - JsonPatchConverter removed
 - SQL exceptions thrown as is, others to DSpaceBadRequestException
 - DspaceObjectMetadataOperation.remove()
    > UnprocessableEntityException with exceptionalities
    > Already parsed value used in second parse

PatchOperation
 - M no longer extends DSO
 - supports in child classes with R objectToMatch

ItemWithdrawReplaceOperation
 - one try-catch block with relevant exception handling
2019-11-13 11:15:00 +01:00
Peter Nijs
37e7bda2d5 65956: add link to itemtemplate on collections 2019-11-12 16:13:36 +01:00
Peter Nijs
5e409ae0be Merge remote-tracking branch 'dspace/master' into w2p-65267_delete-in-relationshipservice manual fixes 2019-11-12 14:12:49 +01:00
Peter Nijs
61da3d13ab Merge remote-tracking branch 'dspace/master' into w2p-65267_delete-in-relationshipservice 2019-11-12 14:12:03 +01:00
Raf Ponsaerts
1f2549c1e1 Added ProcessRestPermissionEvaluatorPlugin and changed authorization to be checked with the annotation on the ProcessRestRepository#findOne method 2019-11-12 11:41:59 +01:00
Peter Nijs
0683cdae3c 65956: CRUD on Collection Item template feedback
- manual changes after rebase
- javadoc clarification
2019-11-12 09:51:18 +01:00
Chris Wilper
1ca24c1eba DS-3533 Begin projection/converter tests 2019-11-10 23:49:57 -05:00
Chris Wilper
5e4ddcdeb9 DS-3533 Fix typo 2019-11-10 08:45:33 -05:00
Chris Wilper
d0661d144e DS-3533 Cache method link annotation info to improve performance 2019-11-09 23:17:27 -05:00
Chris Wilper
f7d9175728 Merge branch 'master' into DS-3533_Projections 2019-11-09 21:36:06 -05:00
Chris Wilper
66108a7532 DS-3533 Fix failure to link when embedding from link repo 2019-11-09 10:39:50 -05:00
Chris Wilper
c556c379f5 DS-3533 Fix incorrect embedded page details when provided by link repo 2019-11-09 09:57:18 -05:00
Ben Bosman
7d2eb90af6 fixes for incorrect virtual metadata 2019-11-08 18:06:16 +01:00
Ben Bosman
7f0ffa8586 JavaDocs 2019-11-08 17:49:42 +01:00
Peter Nijs
0919bad5be 65956: CRUD on Collection Item template feedback
- rename classes
2019-11-08 16:50:28 +01:00