From 16c100ecbcad7f22d036e307d0ace40b7d85dbac Mon Sep 17 00:00:00 2001
From: Nicolas Le Goff <legoff.n@gmail.com>
Date: Wed, 31 Jul 2013 16:06:21 +0200
Subject: [PATCH] Fix #1383 Task list is empty

---
 lib/classes/task/manager.php | 39 +++++++++++++++++-------------------
 1 file changed, 18 insertions(+), 21 deletions(-)

diff --git a/lib/classes/task/manager.php b/lib/classes/task/manager.php
index 6805f1a22b..1c02eb1541 100644
--- a/lib/classes/task/manager.php
+++ b/lib/classes/task/manager.php
@@ -14,6 +14,7 @@ use Alchemy\Phrasea\Application;
 use Symfony\Component\Process\ProcessBuilder;
 use Symfony\Component\Process\PhpExecutableFinder;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
+use Symfony\Component\Finder\Finder;
 
 /**
  *
@@ -220,32 +221,28 @@ class task_manager
 
     public static function getAvailableTasks()
     {
-        $taskdir = array(
-            __DIR__ . "/period/",
-            __DIR__ . "/../../../config/classes/task/period/",
-        );
+        $dirs = array(__DIR__ . "/period");
+
+        if (is_dir($configDir = __DIR__ . "/../../../config/classes/task/period")) {
+            $dirs[] = $configDir;
+        }
 
         $tasks = array();
-        foreach ($taskdir as $path) {
-            if (($hdir = @opendir($path)) != FALSE) {
-                $max = 9999;
-                while (($max-- > 0) && (($file = readdir($hdir)) !== false)) {
-                    if (!is_file($path . '/' . $file) || substr($file, 0, 1) == "." || substr($file, -10) != ".php") {
-                        continue;
-                    }
+        $finder = new Finder();
 
-                    $classname = 'task_period_' . substr($file, 0, strlen($file) - 10);
+        foreach ($finder->files()->in($dirs)->name("*.php") as $file) {
+            $classname = 'task_period_' . $file->getBasename('.php');
 
-                    try {
-                        //      $testclass = new $classname(null);
-                        if ($classname::interfaceAvailable()) {
-                            $tasks[] = array("class" => $classname, "name"  => $classname::getName(), "err"   => null);
-                        }
-                    } catch (Exception $e) {
-
-                    }
+            try {
+                if (class_exists($classname) && $classname::interfaceAvailable()) {
+                    $tasks[] = array(
+                        "class" => $classname,
+                        "name" => $classname::getName(),
+                        "err" => null
+                    );
                 }
-                closedir($hdir);
+            } catch (Exception $e) {
+
             }
         }