refactor commands

lib/Alchemy/Phrasea/Command/Command.php

@@ -33,21 +33,17 @@ abstract class Command extends SymfoCommand
      * Check if Phraseanet is set-up and if the current command requires
      * Phraseanet to be set-up
      *
-     * @param \Symfony\Component\Console\Output\OutputInterface $output
+     * @throws \RuntimeException
      * @return Boolean
      */
-    public function checkSetup(OutputInterface $output)
+    public function checkSetup()
     {
         if ($this->requireSetup()) {
             $core = \bootstrap::getCore();
 
             if ( ! $core->getConfiguration()->isInstalled()) {
-                $output->writeln("<error>Phraseanet is not set up</error>");
+                throw new \RuntimeException('Phraseanet must be set-up');
-
-                return false;
             }
         }
-
-        return true;
     }
 }

lib/classes/module/console/aboutAuthors.class.php

@@ -33,9 +33,7 @@ class module_console_aboutAuthors extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-            return 1;
-        }
 
         $output->writeln(file_get_contents(__DIR__ . '/../../../../AUTHORS'));
 

lib/classes/module/console/aboutLicense.class.php

@@ -33,9 +33,7 @@ class module_console_aboutLicense extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-            return 1;
-        }
 
         $output->writeln(file_get_contents(__DIR__ . '/../../../../LICENSE'));
 

lib/classes/module/console/checkExtension.class.php

@@ -43,9 +43,7 @@ class module_console_checkExtension extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-            return 1;
-        }
 
         if ( ! extension_loaded('phrasea2')) {
             $output->writeln("<error>Missing Extension php-phrasea.</error>");

lib/classes/module/console/fieldsDelete.class.php

@@ -42,9 +42,7 @@ class module_console_fieldsDelete extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-            return 1;
-        }
 
         try {
             $databox = \databox::get_instance((int) $input->getArgument('sbas_id'));

lib/classes/module/console/fieldsList.class.php

@@ -38,9 +38,7 @@ class module_console_fieldsList extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-            return 1;
-        }
 
         $appbox = \appbox::get_instance(\bootstrap::getCore());
 

lib/classes/module/console/fieldsMerge.class.php

@@ -52,9 +52,7 @@ class module_console_fieldsMerge extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-            return 1;
-        }
 
         $output->writeln("");
 

lib/classes/module/console/fieldsRename.class.php

@@ -43,9 +43,7 @@ class module_console_fieldsRename extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-            return 1;
-        }
 
         $new_name = $input->getArgument('name');
 

lib/classes/module/console/fileEnsureDevSetting.class.php

@@ -62,9 +62,7 @@ class module_console_fileEnsureDevSetting extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-            return 1;
-        }
 
         $specifications = new \Alchemy\Phrasea\Core\Configuration\ApplicationSpecification();
 

lib/classes/module/console/fileEnsureProductionSetting.class.php

@@ -62,9 +62,7 @@ class module_console_fileEnsureProductionSetting extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-            return 1;
-        }
 
         $specifications = new \Alchemy\Phrasea\Core\Configuration\ApplicationSpecification();
 

lib/classes/module/console/schedulerStart.class.php

@@ -41,9 +41,7 @@ class module_console_schedulerStart extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-            return 1;
-        }
 
         $logger = new Logger('Task logger');
 

lib/classes/module/console/schedulerState.class.php

@@ -56,8 +56,9 @@ class module_console_schedulerState extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        try{
-
+            $this->checkSetup();
+        } catch (\RuntimeException $e){
             return self::EXITCODE_SETUP_ERROR;
         }
 

lib/classes/module/console/schedulerStop.class.php

@@ -38,10 +38,7 @@ class module_console_schedulerStop extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-
-            return 1;
-        }
 
         require_once __DIR__ . '/../../../../lib/bootstrap.php';
 

lib/classes/module/console/sphinxGenerateSuggestion.class.php

@@ -39,10 +39,7 @@ class module_console_sphinxGenerateSuggestion extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-
-            return 1;
-        }
 
         define('FREQ_THRESHOLD', 10);
         define('SUGGEST_DEBUG', 0);

lib/classes/module/console/systemBackupDB.class.php

@@ -45,10 +45,7 @@ class module_console_systemBackupDB extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-
-            return 1;
-        }
 
         $output->write('Phraseanet is going to be backup...', true);
 

lib/classes/module/console/systemClearCache.class.php

@@ -39,10 +39,7 @@ class module_console_systemClearCache extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-
-            return 1;
-        }
 
         $finder = new Finder();
 

lib/classes/module/console/systemConfigCheck.class.php

@@ -39,10 +39,7 @@ class module_console_systemConfigCheck extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-
-            return 1;
-        }
 
         if ( ! function_exists('_')) {
             $output->writeln('<error>YOU MUST ENABLE GETTEXT SUPPORT TO USE PHRASEANET</error>');

lib/classes/module/console/systemExport.class.php

@@ -78,10 +78,7 @@ class module_console_systemExport extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-
-            return 1;
-        }
 
         $core = \bootstrap::getCore();
 

lib/classes/module/console/systemMailCheck.class.php

@@ -44,10 +44,7 @@ class module_console_systemMailCheck extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-
-            return 1;
-        }
 
         $appbox = appbox::get_instance(\bootstrap::getCore());
 

lib/classes/module/console/systemTemplateGenerator.class.php

@@ -38,10 +38,7 @@ class module_console_systemTemplateGenerator extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-
-            return 1;
-        }
 
         $tplDirs = array(
             realpath(__DIR__ . '/../../../../templates/web/'),

lib/classes/module/console/systemUpgrade.class.php

@@ -39,10 +39,7 @@ class module_console_systemUpgrade extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        $this->checkSetup();
-
-            return 1;
-        }
 
         $Core = \bootstrap::getCore();
 

lib/classes/module/console/taskState.class.php

@@ -64,8 +64,9 @@ class module_console_taskState extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        try{
-
+            $this->checkSetup();
+        } catch (\RuntimeException $e){
             return self::EXITCODE_SETUP_ERROR;
         }
 

lib/classes/module/console/tasklist.class.php

@@ -39,8 +39,9 @@ class module_console_tasklist extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        try{
-
+            $this->checkSetup();
+        } catch (\RuntimeException $e){
             return self::EXITCODE_SETUP_ERROR;
         }
 

lib/classes/module/console/taskrun.class.php

@@ -72,8 +72,9 @@ class module_console_taskrun extends Command
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
-        if ( ! $this->checkSetup($output)) {
+        try{
-
+            $this->checkSetup();
+        } catch (\RuntimeException $e){
             return self::EXITCODE_SETUP_ERROR;
         }