From bb836ad3602e3c1192d71876fde083ff9f4b1084 Mon Sep 17 00:00:00 2001 From: Nicolas Le Goff Date: Thu, 10 Oct 2013 16:43:41 +0200 Subject: [PATCH] Fix #1518 Can not edit tags in metadatas settings --- www/scripts/apps/admin/fields/views/edit.js | 2 +- www/scripts/tests/specs/admin/fields.js | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/www/scripts/apps/admin/fields/views/edit.js b/www/scripts/apps/admin/fields/views/edit.js index 2353fd9a4c..8fc9ed9d4e 100644 --- a/www/scripts/apps/admin/fields/views/edit.js +++ b/www/scripts/apps/admin/fields/views/edit.js @@ -125,8 +125,8 @@ define([ var fieldTag = $(e.target); var fieldTagId = fieldTag.attr("id"); var fieldTagValue = fieldTag.val(); + var notValid = "" === fieldTagValue; - var notValid = "" !== fieldTagValue; // check for format tag if (notValid) { fieldTag diff --git a/www/scripts/tests/specs/admin/fields.js b/www/scripts/tests/specs/admin/fields.js index 6d76b9c568..24224975d4 100644 --- a/www/scripts/tests/specs/admin/fields.js +++ b/www/scripts/tests/specs/admin/fields.js @@ -217,6 +217,14 @@ define([ it("should render as a DIV element", function() { this.view.render().el.nodeName.should.equal("DIV"); }); + + it("should render an error message if provided tag is empty", function() { + var view = this.view.render(); + + view.$('input#tag').val("").blur(); + + assert.isTrue(view.$('input#tag').closest(".control-group").hasClass("error")); + }); }); describe("FieldError Views", function() {