Fix public API BC break

This commit is contained in:
Mathieu Darse
2015-10-06 11:22:44 +02:00
parent 6c4a1460b5
commit 8a5afb1140
2 changed files with 5 additions and 3 deletions

View File

@@ -39,7 +39,7 @@ final class GlobalStructure implements Structure
return new self($fields, $flags); return new self($fields, $flags);
} }
public function __construct(array $fields, array $flags) public function __construct(array $fields = [], array $flags = [])
{ {
Assertion::allIsInstanceOf($fields, Field::class); Assertion::allIsInstanceOf($fields, Field::class);
Assertion::allIsInstanceOf($flags, Flag::class); Assertion::allIsInstanceOf($flags, Flag::class);
@@ -51,7 +51,7 @@ final class GlobalStructure implements Structure
} }
} }
private function add(Field $field) public function add(Field $field)
{ {
$name = $field->getName(); $name = $field->getName();
if (isset($this->fields[$name])) { if (isset($this->fields[$name])) {

View File

@@ -4,6 +4,7 @@ namespace Alchemy\Tests\Phrasea\SearchEngine\AST;
use Alchemy\Phrasea\SearchEngine\Elastic\AST\FlagStatement; use Alchemy\Phrasea\SearchEngine\Elastic\AST\FlagStatement;
use Alchemy\Phrasea\SearchEngine\Elastic\Search\QueryContext; use Alchemy\Phrasea\SearchEngine\Elastic\Search\QueryContext;
use Alchemy\Phrasea\SearchEngine\Elastic\Structure\Flag;
/** /**
* @group unit * @group unit
@@ -24,13 +25,14 @@ class FlagStatementTest extends \PHPUnit_Framework_TestCase
public function testQueryBuild() public function testQueryBuild()
{ {
$query_context = $this->prophesize(QueryContext::class); $query_context = $this->prophesize(QueryContext::class);
$query_context->getFlag('foo')->willReturn(new Flag('bar'));
$node = new FlagStatement('foo', true); $node = new FlagStatement('foo', true);
$query = $node->buildQuery($query_context->reveal()); $query = $node->buildQuery($query_context->reveal());
$expected = '{ $expected = '{
"term": { "term": {
"flags.foo": true "flags.bar": true
} }
}'; }';