Reduce code in SubdefGenerator.

This commit is contained in:
Benoît Burnichon
2016-01-25 18:30:00 +01:00
parent 005524d572
commit 90ce63af29

View File

@@ -1,5 +1,4 @@
<?php <?php
/* /*
* This file is part of Phraseanet * This file is part of Phraseanet
* *
@@ -31,6 +30,9 @@ class SubdefGenerator
private $app; private $app;
private $alchemyst; private $alchemyst;
private $filesystem; private $filesystem;
/**
* @var LoggerInterface
*/
private $logger; private $logger;
private $mediavorus; private $mediavorus;
@@ -167,27 +169,20 @@ class SubdefGenerator
*/ */
private function getExtensionFromSpec(SpecificationInterface $spec) private function getExtensionFromSpec(SpecificationInterface $spec)
{ {
$extension = null; switch ($spec->getType()) {
case SpecificationInterface::TYPE_IMAGE:
switch (true) { return 'jpg';
case $spec->getType() === SpecificationInterface::TYPE_IMAGE: case SpecificationInterface::TYPE_ANIMATION:
$extension = 'jpg'; return 'gif';
break; case SpecificationInterface::TYPE_AUDIO:
case $spec->getType() === SpecificationInterface::TYPE_ANIMATION: return $this->getExtensionFromAudioCodec($spec->getAudioCodec());
$extension = 'gif'; case SpecificationInterface::TYPE_VIDEO:
break; return $this->getExtensionFromVideoCodec($spec->getVideoCodec());
case $spec->getType() === SpecificationInterface::TYPE_AUDIO: case SpecificationInterface::TYPE_SWF:
$extension = $this->getExtensionFromAudioCodec($spec->getAudioCodec()); return 'swf';
break;
case $spec->getType() === SpecificationInterface::TYPE_VIDEO:
$extension = $this->getExtensionFromVideoCodec($spec->getVideoCodec());
break;
case $spec->getType() === SpecificationInterface::TYPE_SWF:
$extension = 'swf';
break;
} }
return $extension; return null;
} }
/** /**
@@ -199,21 +194,16 @@ class SubdefGenerator
*/ */
private function getExtensionFromAudioCodec($audioCodec) private function getExtensionFromAudioCodec($audioCodec)
{ {
$extension = null;
switch ($audioCodec) { switch ($audioCodec) {
case 'flac': case 'flac':
$extension = 'flac'; return 'flac';
break;
case 'libvorbis': case 'libvorbis':
$extension = 'ogg'; return 'ogg';
break;
case 'libmp3lame': case 'libmp3lame':
$extension = 'mp3'; return 'mp3';
break;
} }
return $extension; return null;
} }
/** /**
@@ -225,20 +215,15 @@ class SubdefGenerator
*/ */
private function getExtensionFromVideoCodec($videoCodec) private function getExtensionFromVideoCodec($videoCodec)
{ {
$extension = null;
switch ($videoCodec) { switch ($videoCodec) {
case 'libtheora': case 'libtheora':
$extension = 'ogv'; return 'ogv';
break;
case 'libvpx': case 'libvpx':
$extension = 'webm'; return 'webm';
break;
case 'libx264': case 'libx264':
$extension = 'mp4'; return 'mp4';
break;
} }
return $extension; return null;
} }
} }