clean some config (#4429)

PHRAS-3668 : happyscribe setup in configuration.yml

config/configuration.sample.yml

@@ -246,10 +246,7 @@ registration-fields:
         required: true
 download_async:
   enabled: true
-pusher:
-  auth_key: 'pusher-auth_key'
-  secret: 'pusher-secret'
-  app_id: 'pusher-app_id'
+
 xsendfile:
     enabled: false
     type: nginx
@@ -395,6 +392,12 @@ externalservice:
         auth_key: 'pusher-auth_key'
         secret: 'pusher-secret'
         app_id: 'pusher-app_id'
+    happyscribe:
+        token: token
+        organization_id: 123456
+        transcript_format: vtt
+        subdef_source: preview
+
 
 user_account:
     deleting_policies:

lib/Alchemy/Phrasea/WorkerManager/Worker/SubtitleWorker.php

@@ -54,7 +54,7 @@ class SubtitleWorker implements WorkerInterface
         $happyscribeTranscriptFormat  = $this->conf->get(['externalservice', 'happyscribe', 'transcript_format'], 'vtt');
 
         if (!$organizationId || !$this->happyscribeToken ) {
-            $this->logger->error("External service Ginga not set correctly in configuration.yml");
+            $this->logger->error("External service happyscribe not set correctly in configuration.yml");
 
             return 0;
         }

lib/classes/patch/418RC8PHRAS3777.php

@@ -76,6 +76,36 @@ class patch_418RC8PHRAS3777 implements patchInterface
             $conf->remove(['main', 'bridge']);
         }
 
+        // remove old pusher configuration
+        // copy it under externalservice
+        if ($conf->has(['pusher'])) {
+            $p = $conf->get(['pusher']);
+            $conf->set(['externalservice', 'pusher'], $p);
+
+            $conf->remove(['pusher']);
+        }
+
+        // if no pusher configuration
+        if (!$conf->has(['externalservice', 'pusher'])) {
+            $pusher = [
+                'auth_key' => 'pusher-auth_key',
+                'secret' => 'pusher-secret',
+                'app_id' => 'pusher-app_id'
+            ];
+            $conf->set(['externalservice', 'pusher'], $pusher);
+        }
+
+        // if no happyscribe configuration
+        if (!$conf->has(['externalservice', 'happyscribe'])) {
+            $h = [
+                'token'             => 'token',
+                'organization_id'   => '123456',
+                'transcript_format' => 'vtt',
+                'subdef_source'     => 'preview'
+            ];
+            $conf->set(['externalservice', 'happyscribe'], $h);
+        }
+
         // remove cooliris
         if ($conf->has(['crossdomain', 'allow-access-from'])) {
             $tValues = $conf->get(['crossdomain', 'allow-access-from']);

lib/conf.d/configuration.yml

@@ -434,6 +434,11 @@ externalservice:
         auth_key: 'pusher-auth_key'
         secret: 'pusher-secret'
         app_id: 'pusher-app_id'
+    happyscribe:
+        token: token
+        organization_id: 123456
+        transcript_format: vtt
+        subdef_source: preview
 
 
 Console_logger_enabled_environments: [test]