From acb7a53e16a99d8597cfd1ddf784d0db68a0bf9d Mon Sep 17 00:00:00 2001
From: mike-esokia <mike.esokia@gmail.com>
Date: Thu, 24 May 2018 16:43:17 +0400
Subject: [PATCH] refactor code

---
 templates/web/admin/statusbit/edit.html.twig | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/templates/web/admin/statusbit/edit.html.twig b/templates/web/admin/statusbit/edit.html.twig
index 91a08686f5..0560653a0a 100644
--- a/templates/web/admin/statusbit/edit.html.twig
+++ b/templates/web/admin/statusbit/edit.html.twig
@@ -19,7 +19,7 @@
                 </label>
                 <div class="controls">
                     <input id="label_off" onkeyup="inputChanged(this);return(false);" name="label_off"
-                           class="input-xlarge invalid" type="text" value="{{ status['labeloff'] }}">
+                           class="input-xlarge" type="text" value="{{ status['labeloff'] }}">
                 </div>
             </div>
             <div class="row-fluid">
@@ -84,7 +84,7 @@
                 </label>
                 <div class="controls">
                     <input id="label_on" onkeyup="inputChanged(this);return(false);" name="label_on"
-                           class="input-xlarge invalid" type="text" value="{{ status['labelon'] }}">
+                           class="input-xlarge" type="text" value="{{ status['labelon'] }}">
                 </div>
             </div>
             <div class="row-fluid">
@@ -168,22 +168,23 @@
 
 <script type="text/javascript">
     function inputChanged(elem) {
-        var validText = new RegExp(/[!@#$%^&*()]+/);
         if ($(elem).val().length > 0) {
             //check if contains special characters
-            if (validText.test($(elem).val())) {
+            if (isInvalid($(elem).val())) {
                 $(elem).css('border-color', '#F00');
-                $(elem).addClass('invalid');
             } else {
                 $(elem).css('border-color', '');
-                $(elem).removeClass('invalid')
             }
         } else {
             $(elem).css('border-color', '#F00');
-            $(elem).addClass('invalid');
         }
     }
 
+    function isInvalid(string) {
+        var validText = new RegExp(/[!@#$%^&*()]+/);
+        return validText.test(string);
+    }
+
 $(document).ready(function(){
     var selected_files = [];
 
@@ -238,7 +239,7 @@ $(document).ready(function(){
             $("[name=label_on]").css('border-color', '#F00');
             return;
         }
-        if ($("[name=label_off]").hasClass('invalid') || $("[name=label_on]").hasClass('invalid')) {
+        if (isInvalid($("[name=label_off]").val()) || isInvalid($("[name=label_on]").val())) {
             return;
         }
         if( selected_files.length > 0 ) {