From c4daafc5e669a86dfb89d9466fd22c68f84adac1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Burnichon?= Date: Tue, 1 Mar 2016 13:59:41 +0100 Subject: [PATCH] Remove undefined variable in GooglePlus Authentication Provider --- .../Authentication/Provider/GooglePlus.php | 2 +- .../Authentication/Provider/ProviderTestCase.php | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/lib/Alchemy/Phrasea/Authentication/Provider/GooglePlus.php b/lib/Alchemy/Phrasea/Authentication/Provider/GooglePlus.php index 55482acc68..2d519571b6 100644 --- a/lib/Alchemy/Phrasea/Authentication/Provider/GooglePlus.php +++ b/lib/Alchemy/Phrasea/Authentication/Provider/GooglePlus.php @@ -178,7 +178,7 @@ class GooglePlus extends AbstractProvider $token = @json_decode($this->client->getAccessToken(), true); if (JSON_ERROR_NONE !== json_last_error()) { - throw new NotAuthenticatedException('Unable to parse Google+ JSON', $e->getCode(), $e); + throw new NotAuthenticatedException('Unable to parse Google+ JSON'); } $ticket = $this->client->verifyIdToken($token['id_token']); diff --git a/tests/Alchemy/Tests/Phrasea/Authentication/Provider/ProviderTestCase.php b/tests/Alchemy/Tests/Phrasea/Authentication/Provider/ProviderTestCase.php index 4cdab322b0..59ba9becd6 100644 --- a/tests/Alchemy/Tests/Phrasea/Authentication/Provider/ProviderTestCase.php +++ b/tests/Alchemy/Tests/Phrasea/Authentication/Provider/ProviderTestCase.php @@ -195,14 +195,29 @@ abstract class ProviderTestCase extends \PhraseanetTestCase abstract protected function authenticateProvider(ProviderInterface $provider); + /** + * @return ProviderInterface + */ abstract protected function getProviderForAuthentication(); + /** + * @return ProviderInterface + */ abstract protected function getProviderForLogout(); + /** + * @return ProviderInterface + */ abstract protected function getProviderForSuccessIdentity(); + /** + * @return ProviderInterface + */ abstract protected function getProviderForFailingIdentity(); + /** + * @return ProviderInterface + */ abstract protected function getAvailableFieldsForIdentity(); /**