diff --git a/lib/Alchemy/Phrasea/Controller/Admin/Collection.php b/lib/Alchemy/Phrasea/Controller/Admin/Collection.php index 15fe3635db..546b07f9ba 100644 --- a/lib/Alchemy/Phrasea/Controller/Admin/Collection.php +++ b/lib/Alchemy/Phrasea/Controller/Admin/Collection.php @@ -30,7 +30,7 @@ class Collection implements ControllerProviderInterface { $controllers = $app['controllers_factory']; - $controllers->before(function() use ($app) { + $controllers->before(function(Request $request) use ($app) { if (null !== $response = $app['phraseanet.core']['Firewall']->requireAdmin($app)) { return $response; } diff --git a/lib/Alchemy/Phrasea/Controller/Admin/Dashboard.php b/lib/Alchemy/Phrasea/Controller/Admin/Dashboard.php index bc67d95973..1b0288effa 100644 --- a/lib/Alchemy/Phrasea/Controller/Admin/Dashboard.php +++ b/lib/Alchemy/Phrasea/Controller/Admin/Dashboard.php @@ -28,7 +28,7 @@ class Dashboard implements ControllerProviderInterface { $controllers = $app['controllers_factory']; - $controllers->before(function() use ($app) { + $controllers->before(function(Request $request) use ($app) { return $app['phraseanet.core']['Firewall']->requireAdmin($app); }); diff --git a/lib/Alchemy/Phrasea/Controller/Admin/Databox.php b/lib/Alchemy/Phrasea/Controller/Admin/Databox.php index a4c709a746..f7749897ec 100644 --- a/lib/Alchemy/Phrasea/Controller/Admin/Databox.php +++ b/lib/Alchemy/Phrasea/Controller/Admin/Databox.php @@ -30,7 +30,7 @@ class Databox implements ControllerProviderInterface { $controllers = $app['controllers_factory']; - $controllers->before(function() use ($app) { + $controllers->before(function(Request $request) use ($app) { return $app['phraseanet.core']['Firewall']->requireAdmin($app); }); diff --git a/lib/Alchemy/Phrasea/Controller/Admin/Databoxes.php b/lib/Alchemy/Phrasea/Controller/Admin/Databoxes.php index 43daf316a9..08360af7c3 100644 --- a/lib/Alchemy/Phrasea/Controller/Admin/Databoxes.php +++ b/lib/Alchemy/Phrasea/Controller/Admin/Databoxes.php @@ -29,7 +29,7 @@ class Databoxes implements ControllerProviderInterface { $controllers = $app['controllers_factory']; - $controllers->before(function() use ($app) { + $controllers->before(function(Request $request) use ($app) { return $app['phraseanet.core']['Firewall']->requireAdmin($app); }); diff --git a/lib/Alchemy/Phrasea/Controller/Admin/Root.php b/lib/Alchemy/Phrasea/Controller/Admin/Root.php index 1139317317..8356dd8f73 100644 --- a/lib/Alchemy/Phrasea/Controller/Admin/Root.php +++ b/lib/Alchemy/Phrasea/Controller/Admin/Root.php @@ -206,7 +206,7 @@ class Root implements ControllerProviderInterface $structure = $databox->get_structure(); $errors = \databox::get_structure_errors($structure); - if ('ok' === $updateOk = $request->get('update', false)) { + if ($updateOk = ! ! $request->get('success', false)) { $updateOk = true; } @@ -244,10 +244,10 @@ class Root implements ControllerProviderInterface $databox = $app['phraseanet.appbox']->get_databox($databox_id); $databox->saveStructure($domst); - return $app->redirect('/admin/structure/' . $databox_id . '/?update=ok'); + return $app->redirect('/admin/structure/' . $databox_id . '/?success=1'); } else { - return $app->redirect('/admin/structure/' . $databox_id . '/?error=struct'); + return $app->redirect('/admin/structure/' . $databox_id . '/?success=0&error=struct'); } }) ->assert('databox_id', '\d+') @@ -388,7 +388,7 @@ class Root implements ControllerProviderInterface } } - return $app->redirect('/admin/statusbit/' . $databox_id . '/?update=ok'); + return $app->redirect('/admin/statusbit/' . $databox_id . '/?success=1'); }) ->assert('databox_id', '\d+') ->assert('bit', '\d+') diff --git a/lib/Alchemy/Phrasea/Controller/Admin/Setup.php b/lib/Alchemy/Phrasea/Controller/Admin/Setup.php index 10be9a1266..69cb97b9ef 100644 --- a/lib/Alchemy/Phrasea/Controller/Admin/Setup.php +++ b/lib/Alchemy/Phrasea/Controller/Admin/Setup.php @@ -34,7 +34,7 @@ class Setup implements ControllerProviderInterface { $controllers = $app['controllers_factory']; - $controllers->before(function() use ($app) { + $controllers->before(function(Request $request) use ($app) { return $app['phraseanet.core']['Firewall']->requireAdmin($app); }); @@ -87,7 +87,7 @@ class Setup implements ControllerProviderInterface require_once __DIR__ . "/../../../../conf.d/_GV_template.inc"; if (null !== $update = $request->get('update')) { - if ('ok' === $update) { + if ( ! ! $update) { $update = _('Update succeed'); } else { $update = _('Update failed'); @@ -111,10 +111,10 @@ class Setup implements ControllerProviderInterface public function postGlobals(Application $app, Request $request) { if (\setup::create_global_values($app['phraseanet.core']['Registry'], $request->request->all())) { - return $app->redirect('/admin/globals/?update=ok'); + return $app->redirect('/admin/globals/?success=1'); } - return $app->redirect('/admin/globals/?update=ko'); + return $app->redirect('/admin/globals/?success=0'); } /** diff --git a/lib/Alchemy/Phrasea/Controller/Admin/Sphinx.php b/lib/Alchemy/Phrasea/Controller/Admin/Sphinx.php index 42929749e2..6135b9dc27 100644 --- a/lib/Alchemy/Phrasea/Controller/Admin/Sphinx.php +++ b/lib/Alchemy/Phrasea/Controller/Admin/Sphinx.php @@ -29,7 +29,7 @@ class Sphinx implements ControllerProviderInterface { $controllers = $app['controllers_factory']; - $controllers->before(function() use ($app) { + $controllers->before(function(Request $request) use ($app) { return $app['phraseanet.core']['Firewall']->requireAdmin($app); }); @@ -107,7 +107,7 @@ class Sphinx implements ControllerProviderInterface 'sphinx_user_stemmer', $request->request->get('libstemmer', array()), \registry::TYPE_ARRAY ); - return $app->redirect('/admin/sphinx/configuration/?update=ok'); + return $app->redirect('/admin/sphinx/configuration/?success=1'); } /** diff --git a/lib/Alchemy/Phrasea/Controller/Setup/Installer.php b/lib/Alchemy/Phrasea/Controller/Setup/Installer.php index d19836c3b5..3b39303553 100644 --- a/lib/Alchemy/Phrasea/Controller/Setup/Installer.php +++ b/lib/Alchemy/Phrasea/Controller/Setup/Installer.php @@ -150,8 +150,8 @@ class Installer implements ControllerProviderInterface $user_ab = $request->request->get('ab_user'); $password = $request->request->get('ab_password'); - $appbox_name = $request->get('ab_name'); - $databox_name = $request->get('db_name'); + $appbox_name = $request->request->get('ab_name'); + $databox_name = $request->request->get('db_name'); $setupRegistry = new \Setup_Registry(); try { diff --git a/lib/classes/User/Adapter.class.php b/lib/classes/User/Adapter.class.php index 1e3ab3701b..b87730171f 100644 --- a/lib/classes/User/Adapter.class.php +++ b/lib/classes/User/Adapter.class.php @@ -962,27 +962,11 @@ class User_Adapter implements User_Interface, cache_cacheableInterface $stmt->execute(array(':usr_id' => $this->get_id())); $stmt->closeCursor(); - /** - * @todo does usrlist not exists anymore ? - */ -// $sql = 'DELETE FROM usrlist WHERE usr_id = :usr_id'; -// $stmt = $this->appbox->get_connection()->prepare($sql); -// $stmt->execute(array(':usr_id' => $this->get_id())); -// $stmt->closeCursor(); - $sql = 'DELETE FROM usr_settings WHERE usr_id = :usr_id'; $stmt = $this->appbox->get_connection()->prepare($sql); $stmt->execute(array(':usr_id' => $this->get_id())); $stmt->closeCursor(); - /** - * @todo table usrlistusers does not exists anymore ? - */ -// $sql = 'DELETE FROM usrlistusers WHERE usr_id = :usr_id'; -// $stmt = $this->appbox->get_connection()->prepare($sql); -// $stmt->execute(array(':usr_id' => $this->get_id())); -// $stmt->closeCursor(); - $sql = 'DELETE FROM ssel WHERE usr_id = :usr_id'; $stmt = $this->appbox->get_connection()->prepare($sql); $stmt->execute(array(':usr_id' => $this->get_id())); diff --git a/lib/classes/databox.class.php b/lib/classes/databox.class.php index 75ebf4e579..4167f75d1e 100644 --- a/lib/classes/databox.class.php +++ b/lib/classes/databox.class.php @@ -83,12 +83,6 @@ class databox extends base */ protected static $_sxml_thesaurus = array(); - /** - * - * @var Array - */ - protected static $_instances = array(); - const BASE_TYPE = self::DATA_BOX; const CACHE_META_STRUCT = 'meta_struct'; const CACHE_THESAURUS = 'thesaurus'; diff --git a/lib/classes/format.class.php b/lib/classes/format.class.php index dcac76574b..f6ed1771d1 100644 --- a/lib/classes/format.class.php +++ b/lib/classes/format.class.php @@ -62,21 +62,27 @@ class format $separateur = ","; // For mac + $autoDetectLineEndings = ini_get("auto_detect_line_endings"); + ini_set("auto_detect_line_endings", true); - if ($FILE = fopen($filename, "r")) { - $test1 = fgetcsv($FILE, 1024, ","); - rewind($FILE); - $test2 = fgetcsv($FILE, 1024, ";"); - rewind($FILE); - if (count($test1) == 1 || ( count($test2) > count($test1) && count($test2) < 20)) + if ($file = fopen($filename, "r")) { + $test1 = fgetcsv($file, 1024, ","); + rewind($file); + $test2 = fgetcsv($file, 1024, ";"); + rewind($file); + + if (count($test1) == 1 || ( count($test2) > count($test1) && count($test2) < 20)) { $separateur = ";"; + } - while ($ARRAY[] = fgetcsv($FILE, 1024, $separateur)); - fclose($FILE); - array_pop($ARRAY); + while ($array[] = fgetcsv($file, 1024, $separateur)); + fclose($file); + array_pop($array); - return $ARRAY; + ini_set("auto_detect_line_endings", $autoDetectLineEndings); + + return $array; } } } diff --git a/templates/web/admin/collection/collection.html.twig b/templates/web/admin/collection/collection.html.twig index 9595709daa..8bac3c19c1 100644 --- a/templates/web/admin/collection/collection.html.twig +++ b/templates/web/admin/collection/collection.html.twig @@ -1,6 +1,6 @@ {% if reloadTree %} {% endif %} @@ -276,7 +276,7 @@ success: function(datas) { if(datas.success) { if(submitLink.hasClass('reload')) { - parent.reloadTree('base:{{ collection.get_sbas_id() }}'); + reloadTree('base:{{ collection.get_sbas_id() }}'); } } else { alert(datas.msg); diff --git a/templates/web/admin/databox/databox.html.twig b/templates/web/admin/databox/databox.html.twig index 6442eda6e3..13d1d24031 100644 --- a/templates/web/admin/databox/databox.html.twig +++ b/templates/web/admin/databox/databox.html.twig @@ -1,6 +1,6 @@ {% if reloadTree %} {% endif %} @@ -276,7 +276,7 @@ success: function(datas) { if(datas.success) { if(submitLink.hasClass('reload')) { - parent.reloadTree('base:{{ databox.get_sbas_id() }}'); + reloadTree('base:{{ databox.get_sbas_id() }}'); } } else { alert(datas.msg); @@ -327,7 +327,7 @@ success: function(datas) { if(datas.success) { if(submitLink.hasClass('reload')) { - parent.reloadTree('base:{{ databox.get_sbas_id() }}'); + reloadTree('base:{{ databox.get_sbas_id() }}'); } } else { alert(datas.msg); diff --git a/templates/web/admin/sphinx/configuration.html.twig b/templates/web/admin/sphinx/configuration.html.twig index 661b21c5a9..ffcbad706a 100644 --- a/templates/web/admin/sphinx/configuration.html.twig +++ b/templates/web/admin/sphinx/configuration.html.twig @@ -1,3 +1,10 @@ +{% if app.request.query.get('success') == '1' %} +
+ × + {% trans 'Successful update' %} +
+{% endif %} +