hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-12 12:32:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Changes following the review

Browse Source
This commit is contained in:
romainx
2021-01-18 07:43:26 +01:00
parent b7aad78b82
commit 0660736ac0
3 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
base-notebook/test/test_start_script.py
View File

@@ -10,9 +10,8 @@ LOGGER = logging.getLogger(__name__)
@pytest.mark.parametrize(
"env,expected_server",
[
(["JUPYTER_ENABLE_NB=yes"], "notebook"),
(["JUPYTER_ENABLE_LAB=yes"], "lab"),
(None, "lab"),
(None, "notebook"),
],
)
def test_start_notebook(container, http_client, env, expected_server):
@@ -28,10 +27,7 @@ def test_start_notebook(container, http_client, env, expected_server):
assert (
f"Executing the command: jupyter {expected_server}" in logs
), f"Not the expected command (jupyter {expected_server}) was launched"
if env:
# Checking warning messages
if "JUPYTER_ENABLE_LAB=yes" in env:
msg = "WARN: The JUPYTER_ENABLE_LAB environment variable is not required anymore"
elif "JUPYTER_ENABLE_NB=yes" in env:
msg = "WARN: We encourage users to transition to JupyterLab, Notebook support could be removed"
# Checking warning messages
if not env:
msg = "WARN: Jupyter Notebook deprecation notice https://github.com/jupyter/notebook#notice."
assert msg in logs, f"Expected warning message {msg} not printed"