hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-12 20:42:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix according to the review

Browse Source
This commit is contained in:
romainx
2021-01-18 18:02:29 +01:00
parent 0660736ac0
commit 13bf51f6a7
3 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
README.md
View File

@@ -32,8 +32,13 @@ in working on the project.
Following [Jupyter Notebook notice](https://github.com/jupyter/notebook#notice), we encourage users to transition to JupyterLab. Following [Jupyter Notebook notice](https://github.com/jupyter/notebook#notice), we encourage users to transition to JupyterLab.
This can be done by passing the environment variable `JUPYTER_ENABLE_LAB=yes` at container startup, This can be done by passing the environment variable `JUPYTER_ENABLE_LAB=yes` at container startup,
more information in the [documentation](https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html). more information is available in the [documentation](https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html).
This change is followed in the issue [#1217](https://github.com/jupyter/docker-stacks/issues/1217).
In April 2021 JupyterLab will become the default, however a new environment variable will be introduced to switch back to Jupyter Notebook if needed.
Next, and according to the Jupyter Notebook project status and its compatibility with JupyterLab, it could be abandoned in favor of another *classic-like* UI.
This change is tracked in the issue [#1217](https://github.com/jupyter/docker-stacks/issues/1217), please check its content for more information.
## Quick Start ## Quick Start

2
base-notebook/start-notebook.sh
View File

@@ -15,6 +15,6 @@ if [[ ! -z "${JUPYTERHUB_API_TOKEN}" ]]; then
elif [[ ! -z "${JUPYTER_ENABLE_LAB}" ]]; then elif [[ ! -z "${JUPYTER_ENABLE_LAB}" ]]; then
. /usr/local/bin/start.sh $wrapper jupyter lab "$@" . /usr/local/bin/start.sh $wrapper jupyter lab "$@"
else else
echo "WARN: Jupyter Notebook deprecation notice https://github.com/jupyter/notebook#notice." echo "WARN: Jupyter Notebook deprecation notice https://github.com/jupyter/docker-stacks#jupyter-notebook-deprecation-notice."
. /usr/local/bin/start.sh $wrapper jupyter notebook "$@" . /usr/local/bin/start.sh $wrapper jupyter notebook "$@"
fi fi

2
base-notebook/test/test_start_script.py
View File

@@ -29,5 +29,5 @@ def test_start_notebook(container, http_client, env, expected_server):
), f"Not the expected command (jupyter {expected_server}) was launched" ), f"Not the expected command (jupyter {expected_server}) was launched"
# Checking warning messages # Checking warning messages
if not env: if not env:
msg = "WARN: Jupyter Notebook deprecation notice https://github.com/jupyter/notebook#notice." msg = "WARN: Jupyter Notebook deprecation notice"
assert msg in logs, f"Expected warning message {msg} not printed" assert msg in logs, f"Expected warning message {msg} not printed"