From 1936d7356a7a5963b04d5fbaac3350696b07322c Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Wed, 18 May 2022 19:30:39 +0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Tania Allard --- .github/workflows/docker-tag-manifest-push.yml | 4 ++-- docs/contributing/tests.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/docker-tag-manifest-push.yml b/.github/workflows/docker-tag-manifest-push.yml index 774bf071..87761dc2 100644 --- a/.github/workflows/docker-tag-manifest-push.yml +++ b/.github/workflows/docker-tag-manifest-push.yml @@ -1,4 +1,4 @@ -name: Download image artifact from GitHub artifacts, tag it and push to DockerHub +name: Download Docker image from GitHub artifacts, tag and push it to DockerHub on: workflow_call: @@ -30,7 +30,7 @@ jobs: - name: Create dev environment 📦 uses: ./.github/actions/create-dev-env - - name: Load image to docker 📥 + - name: Load image to Docker 📥 uses: ./.github/actions/load-image with: image: ${{ matrix.image }} diff --git a/docs/contributing/tests.md b/docs/contributing/tests.md index 87198a98..1de1d259 100644 --- a/docs/contributing/tests.md +++ b/docs/contributing/tests.md @@ -5,7 +5,7 @@ We greatly appreciate pull requests that extend the automated tests that vet the ## How the Tests Work A [GitHub Action workflow](https://github.com/jupyter/docker-stacks/blob/master/.github/workflows/docker.yml) -runs tests against pull requests submitted to the `jupyter/docker-stacks` repository: +runs tests against pull requests submitted to the `jupyter/docker-stacks` repository. We use `pytest` module to run tests on the image. `conftest.py` and `pytest.ini` in the `tests` folder define the environment in which tests are run.