hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-16 22:42:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

First upload artifacts and then run tests to make sure we can easily debug broken images (#2214)

Browse Source
This commit is contained in:
Ayaz Salikhov
2025-02-17 16:40:37 +00:00
committed by GitHub
parent c6ba9e1646
commit 3ca26744d3
2 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
.github/workflows/docker-build-test-upload.yml vendored
View File

@@ -78,10 +78,6 @@ jobs:
BUILDKIT_PROGRESS: plain BUILDKIT_PROGRESS: plain
shell: bash shell: bash
- name: Run tests ✅
run: python3 -m tests.run_tests --short-image-name ${{ inputs.image }} --registry ${{ env.REGISTRY }} --owner ${{ env.OWNER }}
shell: bash
- name: Write tags file 🏷 - name: Write tags file 🏷
run: | run: |
python3 -m tagging.write_tags_file --short-image-name ${{ inputs.image }} --tags-dir /tmp/jupyter/tags/ --registry ${{ env.REGISTRY }} --owner ${{ env.OWNER }} --variant ${{ inputs.variant }} python3 -m tagging.write_tags_file --short-image-name ${{ inputs.image }} --tags-dir /tmp/jupyter/tags/ --registry ${{ env.REGISTRY }} --owner ${{ env.OWNER }} --variant ${{ inputs.variant }}
@@ -120,3 +116,7 @@ jobs:
name: ${{ inputs.image }}-${{ inputs.platform }}-${{ inputs.variant }} name: ${{ inputs.image }}-${{ inputs.platform }}-${{ inputs.variant }}
path: /tmp/jupyter/images/${{ inputs.image }}-${{ inputs.platform }}-${{ inputs.variant }}.tar.zst path: /tmp/jupyter/images/${{ inputs.image }}-${{ inputs.platform }}-${{ inputs.variant }}.tar.zst
retention-days: 3 retention-days: 3
- name: Run tests ✅
run: python3 -m tests.run_tests --short-image-name ${{ inputs.image }} --registry ${{ env.REGISTRY }} --owner ${{ env.OWNER }}
shell: bash

12
.github/workflows/docker.yml vendored
View File

@@ -458,11 +458,7 @@ jobs:
{ image: all-spark-notebook, variant: default }, { image: all-spark-notebook, variant: default },
] ]
needs: [aarch64-images-tag-push, x86_64-images-tag-push] needs: [aarch64-images-tag-push, x86_64-images-tag-push]
if: | if: (github.repository_owner == 'jupyter' || github.repository_owner == 'mathbunnyru') && !contains(github.event.pull_request.title, '[FAST_BUILD]')
always() &&
needs.x86_64-images-tag-push.result == 'success' &&
(needs.aarch64-images-tag-push.result == 'success' || needs.aarch64-images-tag-push.result == 'skipped') &&
!contains(github.event.pull_request.title, '[FAST_BUILD]')
merge-tags-fast: merge-tags-fast:
uses: ./.github/workflows/docker-merge-tags.yml uses: ./.github/workflows/docker-merge-tags.yml
@@ -480,11 +476,7 @@ jobs:
{ image: base-notebook, variant: default }, { image: base-notebook, variant: default },
] ]
needs: [aarch64-images-tag-push-fast, x86_64-images-tag-push-fast] needs: [aarch64-images-tag-push-fast, x86_64-images-tag-push-fast]
if: | if: (github.repository_owner == 'jupyter' || github.repository_owner == 'mathbunnyru') && contains(github.event.pull_request.title, '[FAST_BUILD]')
always() &&
needs.x86_64-images-tag-push-fast.result == 'success' &&
(needs.aarch64-images-tag-push-fast.result == 'success' || needs.aarch64-images-tag-push-fast.result == 'skipped') &&
contains(github.event.pull_request.title, '[FAST_BUILD]')
wiki-update: wiki-update:
uses: ./.github/workflows/docker-wiki-update.yml uses: ./.github/workflows/docker-wiki-update.yml