mirror of
https://github.com/jupyter/docker-stacks.git
synced 2025-10-17 23:12:56 +00:00
Make the base & minimal notebook containers not amd specific (e.g. support building for arm64) (#1368)
* Dynamically select the right miniforge arch and unpin the ROOT_CONTAINER so that buildx can build arm64 and amd64 cleanup * Remove the commented out hard set of arch * Address code review comments from mathbunnyru * Add setting the owner to respective dockerhbub username * Revert "Add setting the owner to respective dockerhbub username" This reverts commit a8d9c468a7d35dbda33ae902cc524db599519d8a. * Fix up the dockerfile, make the default buildx compatible with the CI and add a comment about how to do cross-platform builds. * Update the docs * Refactor the Makefile to support cross-building images incrementally, add ARG OWNER to the Dockerfile's so people can more easily push to their own, add docker buildx & ARM64 support to the CI * Simplify build-test-all rule * Match patch version * Run prettier on docker.yml * Declare and export seperately per docker lint * Skip CI changes * Revert the makefile changes * Update the Arch comment to match * back out unrelated changes
This commit is contained in:
@@ -44,6 +44,11 @@ Docker destroys the container after notebook server exit, but any files written
|
||||
|
||||
docker run --rm -p 10000:8888 -e JUPYTER_ENABLE_LAB=yes -v "${PWD}":/home/jovyan/work jupyter/datascience-notebook:33add21fab64
|
||||
|
||||
Architectures
|
||||
-----------
|
||||
Currently published containers only support x86, some containers may support cross-building with docker buildx.
|
||||
|
||||
|
||||
Table of Contents
|
||||
-----------------
|
||||
|
||||
|
Reference in New Issue
Block a user