Apply suggestions from code review

This commit is contained in:
Ayaz Salikhov
2021-06-27 12:30:07 +03:00
committed by GitHub
parent a3a0a5b54b
commit 532d3734dc
5 changed files with 9 additions and 9 deletions

View File

@@ -13,7 +13,7 @@ THIS_DIR = os.path.dirname(os.path.realpath(__file__))
@pytest.mark.parametrize(
"test_file",
# TODO: add local_sparklyr
["local_pyspark", "local_spylon", "local_sparkR", "issue_1168"]
["local_pyspark", "local_spylon", "local_sparkR", "issue_1168"],
)
def test_nbconvert(container, test_file):
"""Check if Spark notebooks can be executed"""

View File

@@ -14,8 +14,8 @@ LOGGER = logging.getLogger(__name__)
("conda", "--version"),
("mamba", "--version"),
("npm", "--version"),
("pip", "--version")
]
("pip", "--version"),
],
)
def test_package_manager(container, package_manager, version_arg):
"""Test the notebook start-notebook script"""

View File

@@ -11,8 +11,8 @@ LOGGER = logging.getLogger(__name__)
"env,expected_server",
[
(["JUPYTER_ENABLE_LAB=yes"], "lab"),
(None, "notebook")
]
(None, "notebook"),
],
)
def test_start_notebook(container, http_client, env, expected_server):
"""Test the notebook start-notebook script"""

View File

@@ -16,8 +16,8 @@ THIS_DIR = os.path.dirname(os.path.realpath(__file__))
("notebook_math", "pdf"),
("notebook_math", "html"),
("notebook_svg", "pdf"),
("notebook_svg", "html")
]
("notebook_svg", "html"),
],
)
def test_nbconvert(container, test_file, output_format):
"""Check if nbconvert is able to convert a notebook file"""

View File

@@ -13,8 +13,8 @@ LOGGER = logging.getLogger(__name__)
[
"@bokeh/jupyter_bokeh",
"@jupyter-widgets/jupyterlab-manager",
"jupyter-matplotlib"
]
"jupyter-matplotlib",
],
)
def test_check_extension(container, extension):
"""Basic check of each extension