Reduce indirection when running docker commands (#2265)

This commit is contained in:
Ayaz Salikhov
2025-03-25 09:40:27 +00:00
committed by GitHub
parent 834b6c7e03
commit 57ce6e3f05
10 changed files with 35 additions and 47 deletions

View File

@@ -23,17 +23,22 @@ def test_nbconvert(container: TrackedContainer, test_file: str) -> None:
output_dir = "/tmp"
conversion_timeout_ms = 5000
LOGGER.info(f"Test that {test_file} notebook can be executed ...")
command = (
"jupyter nbconvert --to markdown "
+ f"--ExecutePreprocessor.timeout={conversion_timeout_ms} "
+ f"--output-dir {output_dir} "
+ f"--execute {cont_data_dir}/{test_file}.ipynb"
)
command = [
"jupyter",
"nbconvert",
"--to",
"markdown",
f"--ExecutePreprocessor.timeout={conversion_timeout_ms}",
"--output-dir",
output_dir,
"--execute",
f"{cont_data_dir}/{test_file}.ipynb",
]
logs = container.run_and_wait(
timeout=60,
no_warnings=False,
volumes={str(host_data_dir): {"bind": cont_data_dir, "mode": "ro"}},
command=["bash", "-c", command],
command=command,
)
warnings = TrackedContainer.get_warnings(logs)
assert len(warnings) == 1