From b44537f7a69375058b493a2c57892989686e262b Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Mon, 2 May 2022 02:36:36 +0300 Subject: [PATCH 01/15] Better arm image for datascience-notebook --- datascience-notebook/Dockerfile | 8 ++++---- r-notebook/Dockerfile | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/datascience-notebook/Dockerfile b/datascience-notebook/Dockerfile index 9e3877d1..ef89e642 100644 --- a/datascience-notebook/Dockerfile +++ b/datascience-notebook/Dockerfile @@ -75,23 +75,23 @@ RUN mamba install --quiet --yes \ 'r-nycflights13' \ 'r-randomforest' \ 'r-rcurl' \ + 'r-rmarkdown' \ 'r-rodbc' \ 'r-rsqlite' \ 'r-shiny' \ + 'r-tidyverse' \ 'rpy2' \ 'unixodbc' && \ mamba clean --all -f -y && \ fix-permissions "${CONDA_DIR}" && \ fix-permissions "/home/${NB_USER}" -# These packages are not easy to install under arm +# `r-tidymodels` is not easy to install under arm RUN set -x && \ arch=$(uname -m) && \ if [ "${arch}" == "x86_64" ]; then \ mamba install --quiet --yes \ - 'r-rmarkdown' \ - 'r-tidymodels' \ - 'r-tidyverse' && \ + 'r-tidymodels' && \ mamba clean --all -f -y && \ fix-permissions "${CONDA_DIR}" && \ fix-permissions "/home/${NB_USER}"; \ diff --git a/r-notebook/Dockerfile b/r-notebook/Dockerfile index 4adb90c8..3319a802 100644 --- a/r-notebook/Dockerfile +++ b/r-notebook/Dockerfile @@ -52,7 +52,6 @@ RUN mamba install --quiet --yes \ fix-permissions "/home/${NB_USER}" # `r-tidymodels` is not easy to install under arm -# hadolint ignore=SC2039 RUN set -x && \ arch=$(uname -m) && \ if [ "${arch}" == "x86_64" ]; then \ From 1ec2cdce2f2e7b45bede09e92435386461cfba35 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Mon, 2 May 2022 03:08:35 +0300 Subject: [PATCH 02/15] Add PR template --- .github/pull_request_template.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..121d1316 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,13 @@ + + +## Describe your changes + +## Issue ticket if applicable + + + +## Checklist (especially for first-time contributors) + +- [ ] I have performed a self-review of my code +- [ ] If it is a core feature, I have added thorough tests +- [ ] I will try not to use force-push to make the review process easier for reviewers From 0038a8da6a2e0dc625d02c227fc4d402833c235c Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Mon, 2 May 2022 17:38:36 +0300 Subject: [PATCH 03/15] Simpler julia test --- tests/datascience-notebook/test_julia.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/datascience-notebook/test_julia.py b/tests/datascience-notebook/test_julia.py index d7526ea2..5ed9d1dc 100644 --- a/tests/datascience-notebook/test_julia.py +++ b/tests/datascience-notebook/test_julia.py @@ -10,12 +10,9 @@ LOGGER = logging.getLogger(__name__) def test_julia(container: TrackedContainer) -> None: """Basic julia test""" LOGGER.info("Test that julia is correctly installed ...") - running_container = container.run_detached( + logs = container.run_and_wait( + timeout=5, tty=True, - command=["start.sh", "bash", "-c", "sleep infinity"], + command=["start.sh", "bash", "-c", "julia --version"], ) - command = "julia --version" - cmd = running_container.exec_run(command) - output = cmd.output.decode("utf-8") - LOGGER.debug(output) - assert cmd.exit_code == 0, f"Command {command} failed {output}" + LOGGER.debug(logs) From 2bdc06029aa62ba3751c9cf6ff011f9749881069 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 2 May 2022 16:07:41 +0000 Subject: [PATCH 04/15] Bump docker/setup-buildx-action from 1.6.0 to 1.7.0 Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1.6.0 to 1.7.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](https://github.com/docker/setup-buildx-action/compare/94ab11c41e45d028884a99163086648e898eed25...f211e3e9ded2d9377c8cadc4489a4e38014bc4c9) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .github/workflows/docker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 0f189729..8ad61d8a 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -70,7 +70,7 @@ jobs: uses: docker/setup-qemu-action@27d0a4f181a40b142cce983c5393082c365d1480 # dependabot updates to latest release - name: Set up Docker Buildx (for multi-arch builds) 🐳 - uses: docker/setup-buildx-action@94ab11c41e45d028884a99163086648e898eed25 # dependabot updates to latest release + uses: docker/setup-buildx-action@f211e3e9ded2d9377c8cadc4489a4e38014bc4c9 # dependabot updates to latest release - name: Checkout Repo ⚡️ uses: actions/checkout@v3 From e1fd7acd813e8bde0a4c6fc52bf9ad5239187a3f Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 2 May 2022 21:02:33 +0000 Subject: [PATCH 05/15] [pre-commit.ci] pre-commit autoupdate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit updates: - [github.com/pre-commit/mirrors-mypy: v0.942 → v0.950](https://github.com/pre-commit/mirrors-mypy/compare/v0.942...v0.950) --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 18a167fc..4a74c0b9 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -35,7 +35,7 @@ repos: # Check python code static typing - repo: https://github.com/pre-commit/mirrors-mypy - rev: v0.942 + rev: v0.950 hooks: - id: mypy args: [--config, ./mypy.ini] From 476829f0f47e7b7d57bd105b017d4c07c00319e3 Mon Sep 17 00:00:00 2001 From: Ben Mares Date: Tue, 3 May 2022 15:51:38 +0200 Subject: [PATCH 06/15] Proposed improvements for G_SLICE (#1697) * Try to fix mamba under aarch64 QEMU by setting ENV G_SLICE=always-malloc * Set G_SLICE inside if statement * Write "extract_threads: 1" to /opt/.condarc Co-authored-by: Ayaz Salikhov --- all-spark-notebook/Dockerfile | 8 +++++++- base-notebook/Dockerfile | 3 ++- datascience-notebook/Dockerfile | 8 +++++++- pyspark-notebook/Dockerfile | 8 +++++++- r-notebook/Dockerfile | 8 +++++++- scipy-notebook/Dockerfile | 8 +++++++- tensorflow-notebook/Dockerfile | 8 +++++++- 7 files changed, 44 insertions(+), 7 deletions(-) diff --git a/all-spark-notebook/Dockerfile b/all-spark-notebook/Dockerfile index 3f35e700..684c9ddb 100644 --- a/all-spark-notebook/Dockerfile +++ b/all-spark-notebook/Dockerfile @@ -27,7 +27,13 @@ RUN apt-get update --yes && \ USER ${NB_UID} # R packages including IRKernel which gets installed globally. -RUN mamba install --quiet --yes \ +RUN arch=$(uname -m) && \ + if [ "${arch}" == "aarch64" ]; then \ + # Prevent libmamba from sporadically hanging on arm64 under QEMU + # + export G_SLICE=always-malloc; \ + fi && \ + mamba install --quiet --yes \ 'r-base' \ 'r-ggplot2' \ 'r-irkernel' \ diff --git a/base-notebook/Dockerfile b/base-notebook/Dockerfile index 376bb5fb..7943cbad 100644 --- a/base-notebook/Dockerfile +++ b/base-notebook/Dockerfile @@ -119,7 +119,8 @@ RUN set -x && \ if [ "${arch}" == "aarch64" ]; then \ # Prevent libmamba from sporadically hanging on arm64 under QEMU # - ./micromamba config set extract_threads 1; \ + # We don't use `micromamba config set` since it instead modifies ~/.condarc. + echo "extract_threads: 1" >> "${CONDA_DIR}/.condarc"; \ fi && \ # Install the packages ./micromamba install \ diff --git a/datascience-notebook/Dockerfile b/datascience-notebook/Dockerfile index ef89e642..47a624fc 100644 --- a/datascience-notebook/Dockerfile +++ b/datascience-notebook/Dockerfile @@ -61,7 +61,13 @@ USER ${NB_UID} # R packages including IRKernel which gets installed globally. # r-e1071: dependency of the caret R package -RUN mamba install --quiet --yes \ +RUN arch=$(uname -m) && \ + if [ "${arch}" == "aarch64" ]; then \ + # Prevent libmamba from sporadically hanging on arm64 under QEMU + # + export G_SLICE=always-malloc; \ + fi && \ + mamba install --quiet --yes \ 'r-base' \ 'r-caret' \ 'r-crayon' \ diff --git a/pyspark-notebook/Dockerfile b/pyspark-notebook/Dockerfile index 6be3c924..9a3f5417 100644 --- a/pyspark-notebook/Dockerfile +++ b/pyspark-notebook/Dockerfile @@ -61,7 +61,13 @@ RUN fix-permissions "/etc/ipython/" USER ${NB_UID} # Install pyarrow -RUN mamba install --quiet --yes \ +RUN arch=$(uname -m) && \ + if [ "${arch}" == "aarch64" ]; then \ + # Prevent libmamba from sporadically hanging on arm64 under QEMU + # + export G_SLICE=always-malloc; \ + fi && \ + mamba install --quiet --yes \ 'pyarrow' && \ mamba clean --all -f -y && \ fix-permissions "${CONDA_DIR}" && \ diff --git a/r-notebook/Dockerfile b/r-notebook/Dockerfile index 3319a802..dac8757c 100644 --- a/r-notebook/Dockerfile +++ b/r-notebook/Dockerfile @@ -27,7 +27,13 @@ USER ${NB_UID} # R packages including IRKernel which gets installed globally. # r-e1071: dependency of the caret R package -RUN mamba install --quiet --yes \ +RUN arch=$(uname -m) && \ + if [ "${arch}" == "aarch64" ]; then \ + # Prevent libmamba from sporadically hanging on arm64 under QEMU + # + export G_SLICE=always-malloc; \ + fi && \ + mamba install --quiet --yes \ 'r-base' \ 'r-caret' \ 'r-crayon' \ diff --git a/scipy-notebook/Dockerfile b/scipy-notebook/Dockerfile index 9385e7d7..7bd6caf8 100644 --- a/scipy-notebook/Dockerfile +++ b/scipy-notebook/Dockerfile @@ -26,7 +26,13 @@ RUN apt-get update --yes && \ USER ${NB_UID} # Install Python 3 packages -RUN mamba install --quiet --yes \ +RUN arch=$(uname -m) && \ + if [ "${arch}" == "aarch64" ]; then \ + # Prevent libmamba from sporadically hanging on arm64 under QEMU + # + export G_SLICE=always-malloc; \ + fi && \ + mamba install --quiet --yes \ 'altair' \ 'beautifulsoup4' \ 'bokeh' \ diff --git a/tensorflow-notebook/Dockerfile b/tensorflow-notebook/Dockerfile index 78a8af28..65bf7999 100644 --- a/tensorflow-notebook/Dockerfile +++ b/tensorflow-notebook/Dockerfile @@ -11,7 +11,13 @@ LABEL maintainer="Jupyter Project " SHELL ["/bin/bash", "-o", "pipefail", "-c"] # Install Tensorflow -RUN mamba install --quiet --yes \ +RUN arch=$(uname -m) && \ + if [ "${arch}" == "aarch64" ]; then \ + # Prevent libmamba from sporadically hanging on arm64 under QEMU + # + export G_SLICE=always-malloc; \ + fi && \ + mamba install --quiet --yes \ 'tensorflow' && \ mamba clean --all -f -y && \ fix-permissions "${CONDA_DIR}" && \ From 60b4e4b298ccccf1da88fb030a8f48778e3d40a7 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Fri, 6 May 2022 16:37:02 +0300 Subject: [PATCH 07/15] Update pre-commit hooks --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 4a74c0b9..d6c7ec00 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -14,7 +14,7 @@ repos: # Autoupdate: Python code - repo: https://github.com/asottile/pyupgrade - rev: v2.32.0 + rev: v2.32.1 hooks: - id: pyupgrade args: [--py39-plus] From 93d8207559aad6bf237b6e5f214f733f1110f3f2 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Sun, 8 May 2022 20:23:08 +0300 Subject: [PATCH 08/15] Better markdown-disable rules --- .github/pull_request_template.md | 4 ++-- CONTRIBUTING.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 121d1316..b8ba35d7 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,5 +1,3 @@ - - ## Describe your changes ## Issue ticket if applicable @@ -11,3 +9,5 @@ - [ ] I have performed a self-review of my code - [ ] If it is a core feature, I have added thorough tests - [ ] I will try not to use force-push to make the review process easier for reviewers + + diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 41f55540..e7f70d84 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,5 +1,3 @@ - - Thanks for contributing! Please see the **Contributor Guide** section in [the documentation](https://jupyter-docker-stacks.readthedocs.io/en/latest/) for information about how to contribute @@ -8,3 +6,5 @@ information about how to contribute [tests](https://jupyter-docker-stacks.readthedocs.io/en/latest/contributing/tests.html), [features](https://jupyter-docker-stacks.readthedocs.io/en/latest/contributing/features.html), [community-maintained stacks](https://jupyter-docker-stacks.readthedocs.io/en/latest/contributing/stacks.html). + + From 1a82dc996c76077ea1d8b68da42e2ca7e6bcb467 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 9 May 2022 16:09:05 +0000 Subject: [PATCH 09/15] Bump docker/setup-buildx-action from 1.7.0 to 2 Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1.7.0 to 2. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](https://github.com/docker/setup-buildx-action/compare/f211e3e9ded2d9377c8cadc4489a4e38014bc4c9...dc7b9719a96d48369863986a06765841d7ea23f6) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/docker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 8ad61d8a..9bd14493 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -70,7 +70,7 @@ jobs: uses: docker/setup-qemu-action@27d0a4f181a40b142cce983c5393082c365d1480 # dependabot updates to latest release - name: Set up Docker Buildx (for multi-arch builds) 🐳 - uses: docker/setup-buildx-action@f211e3e9ded2d9377c8cadc4489a4e38014bc4c9 # dependabot updates to latest release + uses: docker/setup-buildx-action@dc7b9719a96d48369863986a06765841d7ea23f6 # dependabot updates to latest release - name: Checkout Repo ⚡️ uses: actions/checkout@v3 From a4aac3ecd33e5aa351637885caf5ffb0815c0a81 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 9 May 2022 16:09:08 +0000 Subject: [PATCH 10/15] Bump docker/login-action from 1.14.1 to 2 Bumps [docker/login-action](https://github.com/docker/login-action) from 1.14.1 to 2. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](https://github.com/docker/login-action/compare/dd4fa0671be5250ee6f50aedf4cb05514abda2c7...49ed152c8eca782a232dede0303416e8f356c37b) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/docker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 8ad61d8a..93cdf7a5 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -112,7 +112,7 @@ jobs: - name: Login to Docker Hub 🔐 if: github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main' || github.event_name == 'schedule' - uses: docker/login-action@dd4fa0671be5250ee6f50aedf4cb05514abda2c7 # dependabot updates to latest release + uses: docker/login-action@49ed152c8eca782a232dede0303416e8f356c37b # dependabot updates to latest release with: username: ${{secrets.DOCKERHUB_USERNAME}} password: ${{secrets.DOCKERHUB_TOKEN}} From ae3e97bd98398539ba948e8b7177b1bf21889879 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 9 May 2022 16:09:12 +0000 Subject: [PATCH 11/15] Bump docker/setup-qemu-action from 1.2.0 to 2 Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 1.2.0 to 2. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](https://github.com/docker/setup-qemu-action/compare/27d0a4f181a40b142cce983c5393082c365d1480...8b122486cedac8393e77aa9734c3528886e4a1a8) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/docker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 8ad61d8a..abca437b 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -67,7 +67,7 @@ jobs: # https://github.com/docker/build-push-action/tree/master#usage # https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md - name: Set up QEMU (for docker buildx) 🐳 - uses: docker/setup-qemu-action@27d0a4f181a40b142cce983c5393082c365d1480 # dependabot updates to latest release + uses: docker/setup-qemu-action@8b122486cedac8393e77aa9734c3528886e4a1a8 # dependabot updates to latest release - name: Set up Docker Buildx (for multi-arch builds) 🐳 uses: docker/setup-buildx-action@f211e3e9ded2d9377c8cadc4489a4e38014bc4c9 # dependabot updates to latest release From 0345f35980977c14a557bad755252fd1e6e47baf Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Thu, 12 May 2022 15:20:10 +0300 Subject: [PATCH 12/15] Unify style --- .github/workflows/docker.yml | 8 ++++---- .github/workflows/hub-overview.yml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 26a0592b..97e61501 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -97,7 +97,7 @@ jobs: - name: Checkout Wiki Repo 📃 uses: actions/checkout@v3 with: - repository: ${{github.repository}}.wiki + repository: ${{ github.repository }}.wiki path: wiki/ - name: Create tags and manifest 🏷 @@ -107,15 +107,15 @@ jobs: if: github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main' || github.event_name == 'schedule' uses: stefanzweifel/git-auto-commit-action@49620cd3ed21ee620a48530e81dba0d139c9cb80 # dependabot updates to latest release with: - commit_message: "Automated wiki publish for ${{github.sha}}" + commit_message: "Automated wiki publish for ${{ github.sha }}" repository: wiki/ - name: Login to Docker Hub 🔐 if: github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main' || github.event_name == 'schedule' uses: docker/login-action@49ed152c8eca782a232dede0303416e8f356c37b # dependabot updates to latest release with: - username: ${{secrets.DOCKERHUB_USERNAME}} - password: ${{secrets.DOCKERHUB_TOKEN}} + username: ${{ secrets.DOCKERHUB_USERNAME }} + password: ${{ secrets.DOCKERHUB_TOKEN }} - name: Push Images to Docker Hub 📤 if: github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main' || github.event_name == 'schedule' diff --git a/.github/workflows/hub-overview.yml b/.github/workflows/hub-overview.yml index f590f63e..63610fbd 100644 --- a/.github/workflows/hub-overview.yml +++ b/.github/workflows/hub-overview.yml @@ -34,8 +34,8 @@ jobs: - name: push README to Dockerhub for base-notebook 🐳 uses: christian-korneck/update-container-description-action@d36005551adeaba9698d8d67a296bd16fa91f8e8 # dependabot updates to latest release env: - DOCKER_USER: ${{secrets.DOCKERHUB_USERNAME}} - DOCKER_PASS: ${{secrets.DOCKERHUB_TOKEN}} + DOCKER_USER: ${{ secrets.DOCKERHUB_USERNAME }} + DOCKER_PASS: ${{ secrets.DOCKERHUB_TOKEN }} with: destination_container_repo: jupyter/base-notebook provider: dockerhub From c1067a67afe3f80df8b7939e97e63dff853c940f Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Fri, 13 May 2022 17:31:33 +0300 Subject: [PATCH 13/15] Fix HEALTHCHECK when GEN_CERT=yes --- base-notebook/Dockerfile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/base-notebook/Dockerfile b/base-notebook/Dockerfile index 7943cbad..4583037e 100644 --- a/base-notebook/Dockerfile +++ b/base-notebook/Dockerfile @@ -166,7 +166,8 @@ RUN sed -re "s/c.ServerApp/c.NotebookApp/g" \ # This healtcheck works well for `lab`, `notebook`, `nbclassic`, `server` and `retro` jupyter commands # https://github.com/jupyter/docker-stacks/issues/915#issuecomment-1068528799 HEALTHCHECK --interval=15s --timeout=3s --start-period=5s --retries=3 \ - CMD wget -O- --no-verbose --tries=1 http://localhost:8888${JUPYTERHUB_SERVICE_PREFIX:-/}api || exit 1 + CMD wget -O- --no-verbose --tries=1 --no-check-certificate \ + http${GEN_CERT:+s}://localhost:8888${JUPYTERHUB_SERVICE_PREFIX:-/}api || exit 1 # Switch back to jovyan to avoid accidental container runs as root USER ${NB_UID} From 8e7741e42fe2abca1a8f1e598f435248802620f1 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Fri, 13 May 2022 18:01:03 +0300 Subject: [PATCH 14/15] Update .github/pull_request_template.md Co-authored-by: Tania Allard --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b8ba35d7..ea182fe1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,7 @@ ## Issue ticket if applicable - + ## Checklist (especially for first-time contributors) From 34a65f66902aa47da745f8814617a747a698cf85 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Fri, 13 May 2022 18:01:54 +0300 Subject: [PATCH 15/15] Add documentation update info --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ea182fe1..f0343596 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,5 +9,6 @@ - [ ] I have performed a self-review of my code - [ ] If it is a core feature, I have added thorough tests - [ ] I will try not to use force-push to make the review process easier for reviewers +- [ ] I have updated the documentation for significant changes