From 1ec2cdce2f2e7b45bede09e92435386461cfba35 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Mon, 2 May 2022 03:08:35 +0300 Subject: [PATCH 1/4] Add PR template --- .github/pull_request_template.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..121d1316 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,13 @@ + + +## Describe your changes + +## Issue ticket if applicable + + + +## Checklist (especially for first-time contributors) + +- [ ] I have performed a self-review of my code +- [ ] If it is a core feature, I have added thorough tests +- [ ] I will try not to use force-push to make the review process easier for reviewers From 93d8207559aad6bf237b6e5f214f733f1110f3f2 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Sun, 8 May 2022 20:23:08 +0300 Subject: [PATCH 2/4] Better markdown-disable rules --- .github/pull_request_template.md | 4 ++-- CONTRIBUTING.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 121d1316..b8ba35d7 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,5 +1,3 @@ - - ## Describe your changes ## Issue ticket if applicable @@ -11,3 +9,5 @@ - [ ] I have performed a self-review of my code - [ ] If it is a core feature, I have added thorough tests - [ ] I will try not to use force-push to make the review process easier for reviewers + + diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 41f55540..e7f70d84 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,5 +1,3 @@ - - Thanks for contributing! Please see the **Contributor Guide** section in [the documentation](https://jupyter-docker-stacks.readthedocs.io/en/latest/) for information about how to contribute @@ -8,3 +6,5 @@ information about how to contribute [tests](https://jupyter-docker-stacks.readthedocs.io/en/latest/contributing/tests.html), [features](https://jupyter-docker-stacks.readthedocs.io/en/latest/contributing/features.html), [community-maintained stacks](https://jupyter-docker-stacks.readthedocs.io/en/latest/contributing/stacks.html). + + From 8e7741e42fe2abca1a8f1e598f435248802620f1 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Fri, 13 May 2022 18:01:03 +0300 Subject: [PATCH 3/4] Update .github/pull_request_template.md Co-authored-by: Tania Allard --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b8ba35d7..ea182fe1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,7 @@ ## Issue ticket if applicable - + ## Checklist (especially for first-time contributors) From 34a65f66902aa47da745f8814617a747a698cf85 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Fri, 13 May 2022 18:01:54 +0300 Subject: [PATCH 4/4] Add documentation update info --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ea182fe1..f0343596 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,5 +9,6 @@ - [ ] I have performed a self-review of my code - [ ] If it is a core feature, I have added thorough tests - [ ] I will try not to use force-push to make the review process easier for reviewers +- [ ] I have updated the documentation for significant changes