hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-13 13:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix comments codestyle in python

Browse Source
This commit is contained in:
Ayaz Salikhov
2024-01-16 16:56:36 +04:00
parent d3e18d975c
commit 86dc0f274f
2 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
images/base-notebook/start-notebook.py
View File

@@ -24,13 +24,15 @@ if os.environ.get("RESTARTABLE") == "yes":
# We always launch a jupyter subcommand from this script # We always launch a jupyter subcommand from this script
command.append("jupyter") command.append("jupyter")
# Launch the configured subcommand. Note that this should be a single string, so we don't split it # Launch the configured subcommand.
# We default to lab # Note that this should be a single string, so we don't split it.
# We default to `lab`.
jupyter_command = os.environ.get("DOCKER_STACKS_JUPYTER_CMD", "lab") jupyter_command = os.environ.get("DOCKER_STACKS_JUPYTER_CMD", "lab")
command.append(jupyter_command) command.append(jupyter_command)
# Append any optional NOTEBOOK_ARGS we were passed in. This is supposed to be multiple args passed # Append any optional NOTEBOOK_ARGS we were passed in.
# on to the notebook command, so we split it correctly with shlex # This is supposed to be multiple args passed on to the notebook command,
# so we split it correctly with shlex
if "NOTEBOOK_ARGS" in os.environ: if "NOTEBOOK_ARGS" in os.environ:
command += shlex.split(os.environ["NOTEBOOK_ARGS"]) command += shlex.split(os.environ["NOTEBOOK_ARGS"])

8
tests/base-notebook/test_container_options.py
View File

@@ -65,10 +65,10 @@ def test_unsigned_ssl(
environment=["GEN_CERT=yes"], environment=["GEN_CERT=yes"],
ports={"8888/tcp": host_port}, ports={"8888/tcp": host_port},
) )
# NOTE: The requests.Session backing the http_client fixture does not retry # NOTE: The requests.Session backing the http_client fixture
# properly while the server is booting up. An SSL handshake error seems to # does not retry properly while the server is booting up.
# abort the retry logic. Forcing a long sleep for the moment until I have # An SSL handshake error seems to abort the retry logic.
# time to dig more. # Forcing a long sleep for the moment until I have time to dig more.
time.sleep(1) time.sleep(1)
resp = http_client.get(f"https://localhost:{host_port}", verify=False) resp = http_client.get(f"https://localhost:{host_port}", verify=False)
resp.raise_for_status() resp.raise_for_status()