hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-10 19:42:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Resolve Docker lint (hadolint) errors

Browse Source 
- Exclude `ppc64` Dockerfiles from the linting in pre-commit since we cannot check their build easily and so fix the lint errors without breaking something (already excluded in the `Makefile`)
- Fix examples Dockerfile to invert root and jovyan user instructions (Last user should not be root `DL3002`)
This commit is contained in:
romainx
2020-08-16 10:24:24 +02:00
parent 9b87b16254
commit ba4b59db11
3 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
examples/docker-compose/notebook/Dockerfile
View File

@@ -4,12 +4,13 @@
# Pick your favorite docker-stacks image
FROM jupyter/minimal-notebook:55d5ca6be183
USER jovyan
# Add permanent pip/conda installs, data files, other user libs here
# e.g., RUN pip install jupyter_dashboards
USER root
# Add permanent apt-get installs and other root commands here
# e.g., RUN apt-get install npm nodejs
USER $NB_UID
# Switch back to jovyan to avoid accidental container runs as root
# Add permanent pip/conda installs, data files, other user libs here
# e.g., RUN pip install jupyter_dashboards