hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-16 14:32:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not bloat spark image with ENV variables (#2081)

Browse Source 
* Do not bloat spark image with ENV variables

* Remove HadoopVersionTagger
This commit is contained in:
Ayaz Salikhov
2024-01-17 13:34:33 +04:00
committed by GitHub
parent d57bf9590d
commit bf33945b9e
3 changed files with 6 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tagging/taggers.py
View File

@@ -12,18 +12,6 @@ def _get_program_version(container: Container, program: str) -> str:
return DockerRunner.run_simple_command(container, cmd=f"{program} --version")
def _get_env_variable(container: Container, variable: str) -> str:
env = DockerRunner.run_simple_command(
container,
cmd="env",
print_result=False,
).split()
for env_entry in env:
if env_entry.startswith(variable):
return env_entry[len(variable) + 1 :]
raise KeyError(variable)
def _get_pip_package_version(container: Container, package: str) -> str:
PIP_VERSION_PREFIX = "Version: "
@@ -136,12 +124,6 @@ class SparkVersionTagger(TaggerInterface):
return "spark-" + version_line.split(" ")[-1]
class HadoopVersionTagger(TaggerInterface):
@staticmethod
def tag_value(container: Container) -> str:
return "hadoop-" + _get_env_variable(container, "HADOOP_VERSION")
class JavaVersionTagger(TaggerInterface):
@staticmethod
def tag_value(container: Container) -> str: