hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-17 15:02:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use correct ServerApp options in examples and tests (#1947)

Browse Source
This commit is contained in:
Ayaz Salikhov
2023-07-26 20:09:47 +04:00
committed by GitHub
parent 75ca54d550
commit bfe5f20914
10 changed files with 28 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/base-notebook/test_container_options.py
View File

@@ -16,7 +16,7 @@ def test_cli_args(container: TrackedContainer, http_client: requests.Session) ->
(e.g., disabling token security)"""
host_port = find_free_port()
running_container = container.run_detached(
command=["start-notebook.sh", "--NotebookApp.token=''"],
command=["start-notebook.sh", "--IdentityProvider.token=''"],
ports={"8888/tcp": host_port},
)
resp = http_client.get(f"http://localhost:{host_port}")
@@ -103,7 +103,7 @@ def test_custom_internal_port(
host_port = find_free_port()
internal_port = env.get("JUPYTER_PORT", 8888)
running_container = container.run_detached(
command=["start-notebook.sh", "--NotebookApp.token=''"],
command=["start-notebook.sh", "--IdentityProvider.token=''"],
environment=env,
ports={internal_port: host_port},
)