From c1a892c6dcaa89aed5a84c27be5fc31d4bed56a8 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Fri, 1 Apr 2022 00:23:17 +0100 Subject: [PATCH] Remove JUPYTER_ENABLE_LAB variable warning --- base-notebook/start-notebook.sh | 4 ---- tests/base-notebook/test_start_container.py | 6 ------ 2 files changed, 10 deletions(-) diff --git a/base-notebook/start-notebook.sh b/base-notebook/start-notebook.sh index ce47768d..4f673d22 100755 --- a/base-notebook/start-notebook.sh +++ b/base-notebook/start-notebook.sh @@ -18,9 +18,5 @@ if [[ "${RESTARTABLE}" == "yes" ]]; then wrapper="run-one-constantly" fi -if [[ -v JUPYTER_ENABLE_LAB ]]; then - echo "WARNING: JUPYTER_ENABLE_LAB is ignored, use DOCKER_STACKS_JUPYTER_CMD if you want to change the command used to start the server" -fi - # shellcheck disable=SC1091,SC2086 exec /usr/local/bin/start.sh ${wrapper} jupyter ${DOCKER_STACKS_JUPYTER_CMD} ${NOTEBOOK_ARGS} "$@" diff --git a/tests/base-notebook/test_start_container.py b/tests/base-notebook/test_start_container.py index fffdf68f..ad45d2ce 100644 --- a/tests/base-notebook/test_start_container.py +++ b/tests/base-notebook/test_start_container.py @@ -15,12 +15,6 @@ LOGGER = logging.getLogger(__name__) @pytest.mark.parametrize( "env,expected_command,expected_start,expected_warnings", [ - ( - ["JUPYTER_ENABLE_LAB=yes"], - "jupyter lab", - True, - ["WARNING: JUPYTER_ENABLE_LAB is ignored"], - ), (None, "jupyter lab", True, []), (["DOCKER_STACKS_JUPYTER_CMD=lab"], "jupyter lab", True, []), (["RESTARTABLE=yes"], "run-one-constantly jupyter lab", True, []),