hazza/docker-stacks
1
0
Fork 0
mirror of https://github.com/jupyter/docker-stacks.git synced 2025-10-17 23:12:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix some grammar issues

Browse Source
This commit is contained in:
Ayaz Salikhov
2023-11-19 02:01:42 +01:00
parent 71e66b2d57
commit d03229331a
22 changed files with 90 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/contributing/features.md
View File

@@ -24,9 +24,9 @@ Roughly speaking, we evaluate new features based on the following criteria:
Is the feature generally applicable across domains?
Does it work with JupyterLab, Jupyter Notebook, JupyterHub, etc.?
- **Fit with the image purpose**:
Does the feature match the theme of the stack in which it will be added?
Does the feature match the theme of the stack to which it will be added?
Would it fit better in a new community stack?
- **Complexity of build/runtime configuration**:
- **The complexity of build/runtime configuration**:
How many lines of code does the feature require in one of the Dockerfiles or startup scripts?
Does it require new scripts entirely?
Do users need to adjust how they use the images?
@@ -36,7 +36,7 @@ Roughly speaking, we evaluate new features based on the following criteria:
- **Ability to support the addition**:
Can existing maintainers answer user questions and address future build issues?
Are the contributors interested in helping with long-term maintenance?
Can we write tests to ensure the feature continues to work over time?
Can we write tests to ensure the feature continues to work over the years?
## Submitting a Pull Request